diff mbox

[dpdk-dev] eventdev: fix eth port in eth Rx adapter internal function

Message ID 1527023202-51808-1-git-send-email-nikhil.rao@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rao, Nikhil May 22, 2018, 9:06 p.m. UTC 
  The dev_id parameter to fill_event_buffer() should be 16 bit,
also rename to to eth_dev_id to avoid confusion with event device
id elsewhere in the file.

Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
Cc: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jerin Jacob May 23, 2018, 5:51 a.m. UTC | #1 
-----Original Message-----
> Date: Wed, 23 May 2018 02:36:42 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function
> X-Mailer: git-send-email 1.8.3.1
> 
> The dev_id parameter to fill_event_buffer() should be 16 bit,
> also rename to to eth_dev_id to avoid confusion with event device
> id elsewhere in the file.
> 
> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> Cc: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 6f70509..273df1e 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -418,14 +418,14 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
>  
>  static inline void
>  fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
> -	uint8_t dev_id,
> +	uint16_t eth_dev_id,
>  	uint16_t rx_queue_id,
>  	struct rte_mbuf **mbufs,
>  	uint16_t num)
>  {
>  	uint32_t i;
>  	struct eth_device_info *eth_device_info =
> -					&rx_adapter->eth_devices[dev_id];
> +					&rx_adapter->eth_devices[eth_dev_id];
>  	struct eth_rx_queue_info *eth_rx_queue_info =
>  					&eth_device_info->rx_queue[rx_queue_id];
>  
> -- 
> 1.8.3.1
>
Thomas Monjalon May 24, 2018, 8:55 p.m. UTC | #2 
23/05/2018 07:51, Jerin Jacob:
> -----Original Message-----
> > Date: Wed, 23 May 2018 02:36:42 +0530
> > From: Nikhil Rao <nikhil.rao@intel.com>
> > To: jerin.jacob@caviumnetworks.com
> > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function
> > X-Mailer: git-send-email 1.8.3.1
> > 
> > The dev_id parameter to fill_event_buffer() should be 16 bit,
> > also rename to to eth_dev_id to avoid confusion with event device
> > id elsewhere in the file.
> > 
> > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> > Cc: stable@dpdk.org
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

It doesn't look to be critical.
So it is deferred to 18.08 (we minimize risks in -rc6).
Rao, Nikhil June 3, 2018, 7:23 a.m. UTC | #3 
On 5/25/2018 2:25 AM, Thomas Monjalon wrote:
> 23/05/2018 07:51, Jerin Jacob:
>> -----Original Message-----
>>> Date: Wed, 23 May 2018 02:36:42 +0530
>>> From: Nikhil Rao <nikhil.rao@intel.com>
>>> To: jerin.jacob@caviumnetworks.com
>>> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
>>> Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function
>>> X-Mailer: git-send-email 1.8.3.1
>>>
>>> The dev_id parameter to fill_event_buffer() should be 16 bit,
>>> also rename to to eth_dev_id to avoid confusion with event device
>>> id elsewhere in the file.
>>>
>>> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
>>> Cc: stable@dpdk.org
>>> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
>>
>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Hi Jerin,

Can you please apply this patch to next-eventdev ?

Nikhil

> 
> It doesn't look to be critical.
> So it is deferred to 18.08 (we minimize risks in -rc6).
> 

> 
>
Jerin Jacob June 4, 2018, 2:58 a.m. UTC | #4 
-----Original Message-----
> Date: Sun, 3 Jun 2018 12:53:39 +0530
> From: "Rao, Nikhil" <nikhil.rao@intel.com>
> To: Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob
>  <jerin.jacob@caviumnetworks.com>
> CC: stable@dpdk.org, dev@dpdk.org, nikhil.rao@intel.com
> Subject: Re: [dpdk-stable] [PATCH] eventdev: fix eth port in eth Rx adapter
>  internal function
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.8.0
> 
> On 5/25/2018 2:25 AM, Thomas Monjalon wrote:
> > 23/05/2018 07:51, Jerin Jacob:
> > > -----Original Message-----
> > > > Date: Wed, 23 May 2018 02:36:42 +0530
> > > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > > To: jerin.jacob@caviumnetworks.com
> > > > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > > > Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function
> > > > X-Mailer: git-send-email 1.8.3.1
> > > > 
> > > > The dev_id parameter to fill_event_buffer() should be 16 bit,
> > > > also rename to to eth_dev_id to avoid confusion with event device
> > > > id elsewhere in the file.
> > > > 
> > > > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> > > > Cc: stable@dpdk.org
> > > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > 
> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Hi Jerin,
> 
> Can you please apply this patch to next-eventdev ?


Applied to dpdk-next-eventdev/master. Thanks.


> 
> Nikhil
> 
> > 
> > It doesn't look to be critical.
> > So it is deferred to 18.08 (we minimize risks in -rc6).
> > 
> 
> > 
> > 
>
diff mbox

Patch

diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 6f70509..273df1e 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -418,14 +418,14 @@  static uint16_t gcd_u16(uint16_t a, uint16_t b)
 
 static inline void
 fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
-	uint8_t dev_id,
+	uint16_t eth_dev_id,
 	uint16_t rx_queue_id,
 	struct rte_mbuf **mbufs,
 	uint16_t num)
 {
 	uint32_t i;
 	struct eth_device_info *eth_device_info =
-					&rx_adapter->eth_devices[dev_id];
+					&rx_adapter->eth_devices[eth_dev_id];
 	struct eth_rx_queue_info *eth_rx_queue_info =
 					&eth_device_info->rx_queue[rx_queue_id];