[dpdk-dev,v5,17/21] rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum

Message ID 152656501757.46638.11326115120446219723.stgit@localhost.localdomain (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 17, 2018, 1:50 p.m. UTC
  /projects/lagopus/src/dpdk/build/include/rte_ip.h:
In function 'rte_ipv6_phdr_cksum':
/projects/lagopus/src/dpdk/build/include/rte_ip.h:
378:18: warning: conversion to 'uint32_t' {aka
'unsigned int'} from 'int' may change the sign of
the result [-Wsign-conversion]
  psd_hdr.proto = (ipv6_hdr->proto << 24);

Signed-off-by: Andy Green <andy@warmcat.com>
---
 lib/librte_net/rte_ip.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Patch

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index c46398548..72dc2456a 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -375,7 +375,7 @@  rte_ipv6_phdr_cksum(const struct ipv6_hdr *ipv6_hdr, uint64_t ol_flags)
 		uint32_t proto; /* L4 protocol - top 3 bytes must be zero */
 	} psd_hdr;
 
-	psd_hdr.proto = (ipv6_hdr->proto << 24);
+	psd_hdr.proto = (uint32_t)(ipv6_hdr->proto << 24);
 	if (ol_flags & PKT_TX_TCP_SEG) {
 		psd_hdr.len = 0;
 	} else {