[dpdk-dev,v3,4/4] net/bnx2x: solve overruns

Message ID 152627428369.53058.11097988033304615943.stgit@localhost.localdomain (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 14, 2018, 5:04 a.m. UTC
  Signed-off-by: Andy Green <andy@warmcat.com>
Fixes: 540a211084a7 ("bnx2x: driver core")
Cc: stable@dpdk.org
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/net/bnx2x/bnx2x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Mody, Rasesh May 15, 2018, 7:47 p.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green

> Sent: Sunday, May 13, 2018 10:05 PM

> 

> Signed-off-by: Andy Green <andy@warmcat.com>

> Fixes: 540a211084a7 ("bnx2x: driver core")

> Cc: stable@dpdk.org

> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

> ---

Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
  

Patch

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index bfd9cce51..3892934cc 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -170,10 +170,10 @@  bnx2x_dma_alloc(struct bnx2x_softc *sc, size_t size, struct bnx2x_dma *dma,
 
 	dma->sc = sc;
 	if (IS_PF(sc))
-		sprintf(mz_name, "bnx2x%d_%s_%" PRIx64, SC_ABS_FUNC(sc), msg,
+		snprintf(mz_name, sizeof(mz_name), "bnx2x%d_%s_%" PRIx64, SC_ABS_FUNC(sc), msg,
 			rte_get_timer_cycles());
 	else
-		sprintf(mz_name, "bnx2x%d_%s_%" PRIx64, sc->pcie_device, msg,
+		snprintf(mz_name, sizeof(mz_name), "bnx2x%d_%s_%" PRIx64, sc->pcie_device, msg,
 			rte_get_timer_cycles());
 
 	/* Caller must take care that strlen(mz_name) < RTE_MEMZONE_NAMESIZE */