diff mbox

[dpdk-dev,v6,01/16] devtools/check-git: provide more generic grep pattern

Message ID 152627399690.52758.13655751186781694008.stgit@localhost.localdomain (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 14, 2018, 4:59 a.m. UTC 
  On Fedora 28, every patch is faulted for
"Wrong headline uppercase", because [A-Z] is not
always case sensitive.

Change to use [[:upper:]]

Signed-off-by: Andy Green <andy@warmcat.com>
---
 devtools/check-git-log.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit May 14, 2018, 4:28 p.m. UTC | #1 
On 5/14/2018 5:59 AM, Andy Green wrote:
> On Fedora 28, every patch is faulted for
> "Wrong headline uppercase", because [A-Z] is not
> always case sensitive.
> 
> Change to use [[:upper:]]
> 
> Signed-off-by: Andy Green <andy@warmcat.com>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
diff mbox

Patch

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index c601f6ae9..2542d9ee0 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -106,8 +106,8 @@  bad=$(echo "$headlines" | grep --color=always \
 
 # check headline lowercase for first words
 bad=$(echo "$headlines" | grep --color=always \
-	-e '^.*[A-Z].*:' \
-	-e ': *[A-Z]' \
+	-e '^.*[[:upper:]].*:' \
+	-e ': *[[:upper:]]' \
 	| sed 's,^,\t,')
 [ -z "$bad" ] || printf "Wrong headline uppercase:\n$bad\n"