diff mbox

[dpdk-dev,v3,24/24] test_table_pipeline: repair munged indirection level

Message ID 152609044297.121661.7057271301350282514.stgit@localhost.localdomain (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 12, 2018, 2 a.m. UTC 
  Signed-off-by: Andy Green <andy@warmcat.com>
---
 test/test/test_table_pipeline.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon May 13, 2018, 8:33 p.m. UTC | #1 
12/05/2018 04:00, Andy Green:
> Signed-off-by: Andy Green <andy@warmcat.com>

May be a fix of
Fixes: 4c387fcdf777 ("pipeline: add new functions for action handlers")

>  rte_pipeline_table_action_handler_miss
>  table_action_stub_miss(struct rte_pipeline *p, struct rte_mbuf **pkts,
> -	uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg);
> +	uint64_t pkts_mask, struct rte_pipeline_table_entry *entry, void *arg);

Why changing only
	table_action_stub_miss
and not
	table_action_stub_hit
	table_action_0x00
?
Andy Green May 14, 2018, 12:22 a.m. UTC | #2 
On 05/14/2018 04:33 AM, Thomas Monjalon wrote:
> 12/05/2018 04:00, Andy Green:
>> Signed-off-by: Andy Green <andy@warmcat.com>
> 
> May be a fix of
> Fixes: 4c387fcdf777 ("pipeline: add new functions for action handlers")
> 
>>   rte_pipeline_table_action_handler_miss
>>   table_action_stub_miss(struct rte_pipeline *p, struct rte_mbuf **pkts,
>> -	uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg);
>> +	uint64_t pkts_mask, struct rte_pipeline_table_entry *entry, void *arg);
> 
> Why changing only
> 	table_action_stub_miss
> and not
> 	table_action_stub_hit
> 	table_action_0x00
> ?

OK, I extended the change to those too.

-Andy

> 
>
diff mbox

Patch

diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c
index 055a1a4e7..d007d55ce 100644
--- a/test/test/test_table_pipeline.c
+++ b/test/test/test_table_pipeline.c
@@ -71,7 +71,7 @@  table_action_stub_hit(struct rte_pipeline *p, struct rte_mbuf **pkts,
 
 rte_pipeline_table_action_handler_miss
 table_action_stub_miss(struct rte_pipeline *p, struct rte_mbuf **pkts,
-	uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void *arg);
+	uint64_t pkts_mask, struct rte_pipeline_table_entry *entry, void *arg);
 
 rte_pipeline_table_action_handler_hit
 table_action_0x00(__attribute__((unused)) struct rte_pipeline *p,
@@ -105,7 +105,7 @@  rte_pipeline_table_action_handler_miss
 table_action_stub_miss(struct rte_pipeline *p,
 	__attribute__((unused)) struct rte_mbuf **pkts,
 	uint64_t pkts_mask,
-	__attribute__((unused)) struct rte_pipeline_table_entry **entry,
+	__attribute__((unused)) struct rte_pipeline_table_entry *entry,
 	__attribute__((unused)) void *arg)
 {
 	printf("STUB Table Action Miss - setting mask to 0x%"PRIx64"\n",