diff mbox

[dpdk-dev,3/4] net/mlx5: solve var may be used uninitialized

Message ID 152600348751.53624.931406344332729888.stgit@localhost.localdomain (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 11, 2018, 1:51 a.m. UTC 
  ---
 drivers/net/mlx5/mlx5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo May 11, 2018, 4:25 p.m. UTC | #1 
> -----Original Message-----

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green

> Sent: Friday, May 11, 2018 2:51 AM

> To: dev@dpdk.org

> Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized

> 

> 

> ---


Missing signed-off-by and fixes line:

Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses")

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Shahaf Shuler May 13, 2018, 4:45 a.m. UTC | #2 
Hi Andy

The patch logic is OK but:
1. since it is a fix patch the title should start with "fix ..."
2. add Fixes tag of the relevant commit and Cc stable if needed 
3. add signed-of-by tag
4. explicitly include the PMD maintainers (Cc'ed now). 

Friday, May 11, 2018 4:51 AM, Andy Green
> Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used

> uninitialized

> 

> 

> ---

>  drivers/net/mlx5/mlx5.c |    2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index

> 8f983061a..4d379fb13 100644

> --- a/drivers/net/mlx5/mlx5.c

> +++ b/drivers/net/mlx5/mlx5.c

> @@ -624,7 +624,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv

> __rte_unused,

>  	int err = 0;

>  	struct ibv_context *attr_ctx = NULL;

>  	struct ibv_device_attr_ex device_attr;

> -	unsigned int vf;

> +	unsigned int vf = 0;

>  	unsigned int mps;

>  	unsigned int cqe_comp;

>  	unsigned int tunnel_en = 0;
Andy Green May 13, 2018, 5:25 a.m. UTC | #3 
On 05/13/2018 12:45 PM, Shahaf Shuler wrote:
> Hi Andy
> 
> The patch logic is OK but:
> 1. since it is a fix patch the title should start with "fix ..."
> 2. add Fixes tag of the relevant commit and Cc stable if needed
> 3. add signed-of-by tag
> 4. explicitly include the PMD maintainers (Cc'ed now).

For a patch adding 4 characters, from a drive-by, it's a lot of overhead.

There's already a V2 of this sent yesterday with the signed-off-by (OK, 
that is not really any overhead) and most of the rest of your stuff 
donated by Pablo.

-Andy

> Friday, May 11, 2018 4:51 AM, Andy Green
>> Subject: [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used
>> uninitialized
>>
>>
>> ---
>>   drivers/net/mlx5/mlx5.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
>> 8f983061a..4d379fb13 100644
>> --- a/drivers/net/mlx5/mlx5.c
>> +++ b/drivers/net/mlx5/mlx5.c
>> @@ -624,7 +624,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv
>> __rte_unused,
>>   	int err = 0;
>>   	struct ibv_context *attr_ctx = NULL;
>>   	struct ibv_device_attr_ex device_attr;
>> -	unsigned int vf;
>> +	unsigned int vf = 0;
>>   	unsigned int mps;
>>   	unsigned int cqe_comp;
>>   	unsigned int tunnel_en = 0;
>
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 8f983061a..4d379fb13 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -624,7 +624,7 @@  mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	int err = 0;
 	struct ibv_context *attr_ctx = NULL;
 	struct ibv_device_attr_ex device_attr;
-	unsigned int vf;
+	unsigned int vf = 0;
 	unsigned int mps;
 	unsigned int cqe_comp;
 	unsigned int tunnel_en = 0;