diff mbox

[dpdk-dev,v4,15/18] app: can't find include

Message ID 152600319123.53146.4272659647114602311.stgit@localhost.localdomain (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 11, 2018, 1:46 a.m. UTC 
  /home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:
fatal error: rte_pmd_dpaa.h: No such file or directory
 #include <rte_pmd_dpaa.h>
          ^~~~~~~~~~~~~~~~

Signed-off-by: Andy Green <andy@warmcat.com>
---
 app/test-pmd/Makefile |    1 +
 1 file changed, 1 insertion(+)

Comments

De Lara Guarch, Pablo May 11, 2018, 11:04 a.m. UTC | #1 
> -----Original Message-----

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green

> Sent: Friday, May 11, 2018 2:47 AM

> To: dev@dpdk.org

> Subject: [dpdk-dev] [PATCH v4 15/18] app: can't find include

> 

> /home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:

> fatal error: rte_pmd_dpaa.h: No such file or directory  #include

> <rte_pmd_dpaa.h>

>           ^~~~~~~~~~~~~~~~

> 

> Signed-off-by: Andy Green <andy@warmcat.com>


As I said in the v3, I think this patch is not needed.
Andy Green May 11, 2018, 11:12 a.m. UTC | #2 
On 05/11/2018 07:04 PM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
>> Sent: Friday, May 11, 2018 2:47 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v4 15/18] app: can't find include
>>
>> /home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:
>> fatal error: rte_pmd_dpaa.h: No such file or directory  #include
>> <rte_pmd_dpaa.h>
>>            ^~~~~~~~~~~~~~~~
>>
>> Signed-off-by: Andy Green <andy@warmcat.com>
> 
> As I said in the v3, I think this patch is not needed.
> 

Do you have an idea why the actual error pasted in the patch is coming 
without this patch?

-Andy
De Lara Guarch, Pablo May 11, 2018, 1:20 p.m. UTC | #3 
> -----Original Message-----

> From: Andy Green [mailto:andy@warmcat.com]

> Sent: Friday, May 11, 2018 12:13 PM

> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org

> Subject: Re: [dpdk-dev] [PATCH v4 15/18] app: can't find include

> 

> 

> 

> On 05/11/2018 07:04 PM, De Lara Guarch, Pablo wrote:

> >

> >

> >> -----Original Message-----

> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green

> >> Sent: Friday, May 11, 2018 2:47 AM

> >> To: dev@dpdk.org

> >> Subject: [dpdk-dev] [PATCH v4 15/18] app: can't find include

> >>

> >> /home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:

> >> fatal error: rte_pmd_dpaa.h: No such file or directory  #include

> >> <rte_pmd_dpaa.h>

> >>            ^~~~~~~~~~~~~~~~

> >>

> >> Signed-off-by: Andy Green <andy@warmcat.com>

> >

> > As I said in the v3, I think this patch is not needed.

> >

> 

> Do you have an idea why the actual error pasted in the patch is coming without

> this patch?


Without this patch, do you see the file in ./build/include?
The file should be copied in there. If it is not there, it wasn't built and that won't fix the issue.
DPDK builds ok for me on Fedora 28/gcc 8 without this patch.

> 

> -Andy
Andy Green May 12, 2018, 12:52 a.m. UTC | #4 
On 05/11/2018 09:20 PM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: Andy Green [mailto:andy@warmcat.com]
>> Sent: Friday, May 11, 2018 12:13 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v4 15/18] app: can't find include
>>
>>
>>
>> On 05/11/2018 07:04 PM, De Lara Guarch, Pablo wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
>>>> Sent: Friday, May 11, 2018 2:47 AM
>>>> To: dev@dpdk.org
>>>> Subject: [dpdk-dev] [PATCH v4 15/18] app: can't find include
>>>>
>>>> /home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10:
>>>> fatal error: rte_pmd_dpaa.h: No such file or directory  #include
>>>> <rte_pmd_dpaa.h>
>>>>             ^~~~~~~~~~~~~~~~
>>>>
>>>> Signed-off-by: Andy Green <andy@warmcat.com>
>>>
>>> As I said in the v3, I think this patch is not needed.
>>>
>>
>> Do you have an idea why the actual error pasted in the patch is coming without
>> this patch?
> 
> Without this patch, do you see the file in ./build/include?
> The file should be copied in there. If it is not there, it wasn't built and that won't fix the issue.
> DPDK builds ok for me on Fedora 28/gcc 8 without this patch.

Hm... so it was there

$ ls -l build/include/rte_pmd_dpaa.h
lrwxrwxrwx. 1 agreen agreen 37 May 11 09:41 build/include/rte_pmd_dpaa.h 
-> ../../drivers/net/dpaa/rte_pmd_dpaa.h

I removed build/include and recooked it, the symlink was regenerated.

As far as I can tell, you're right it doesn't need the patch.  But it 
did earlier in the week for whatever reason...

-Andy


>>
>> -Andy
diff mbox

Patch

diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index 60ae9b9c1..a0fdd0e11 100644
--- a/app/test-pmd/Makefile
+++ b/app/test-pmd/Makefile
@@ -13,6 +13,7 @@  APP = testpmd
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -I$(RTE_SDK)/drivers/net/dpaa
 
 #
 # all source are stored in SRCS-y