Message ID | 1525782629-897-1-git-send-email-ophirmu@mellanox.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECC407FC9; Tue, 8 May 2018 14:30:44 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30041.outbound.protection.outlook.com [40.107.3.41]) by dpdk.org (Postfix) with ESMTP id 0DD457ED3 for <dev@dpdk.org>; Tue, 8 May 2018 14:30:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TRzjC6HbHzMxbivT4Y7BXHNoqBU3XvX+uKZUMyp10G4=; b=pvCVxfukSGWXSUt08xH6krwwC80ddDW07dd29xHZ0v0T1eTnCdln8hPEreugKQ27rFXqAGVUxwhYw7paxpNPScPJZ4vIxb4/tXI6mSj7nCRaPFA1HgWhYSHhs+0CbDufW72v7+jSB0SaViXkEM3Vu5w2csyYMm3J/YG+qnR42ps= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0501MB2309.eurprd05.prod.outlook.com (2603:10a6:4:4c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 8 May 2018 12:30:41 +0000 From: Ophir Munk <ophirmu@mellanox.com> To: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>, Ophir Munk <ophirmu@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com> Date: Tue, 8 May 2018 12:30:29 +0000 Message-Id: <1525782629-897-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR09CA0048.eurprd09.prod.outlook.com (2603:10a6:7:3c::16) To DB6PR0501MB2309.eurprd05.prod.outlook.com (2603:10a6:4:4c::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2309; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 3:tttCFQTcQPo7C8HndP0ijMrrF92Y7yZdMe5VGimpm719BnaDDo1rIRltOGCWtCmCyfSkMdmcLjv4V7TgcjjwsCuVSqY8xPzqlvsZjqoUuII7CytlT5YWtMMgMT3TDpyYKHJ1ksftWdKTXxFiKxwLQChd/qvwFLFY+1+JlwDIHeuLhanwx9zK0E8FMQ/jw8OBU5MeTEHHBlDiAKiP8Kb1Nit2XLu46ojOz+vrK9KEV5xykrIr/tq+uRhFrYvQZmC8; 25:ngYVEQIpBnyX+ISReGigDtX2GIzSnOmiOeRBMpHoHFVfwO/WtY991oleUat4tMf+dDI7f0JTU7CI5xdGnkNPFxv9X+BDG+Y/dB2pazZtWnxMgYsdEnEbG//FjA/XJjCaEyFur8vkVpVKjIl/nrgsvV6QkG4uczgWzWv3H5COjulL+JhaW0DHD5vMVJ1ywNh5/7OOsRy3ApZx5V5Zp79rW/4zON6gMX2KXsdE35kKIYULHNeXe5EsRkCMq2bZ6ZWBLl48kTmlmhJ/flI0CFKG7aB5iHciOzKZUf0dRqgwk58HLNbedHRVGnmZwvL5k4+Ob6NVC/QyrJqiPydwG8UIhA==; 31:MweMqoL6G46FgG6IXMgrQ1GWRCquInGOOC3Pnv0vmp/MVJvI4+TZZhrZEnZ0fX7MY5sjD5bv+ynWQdfCb+bARHR88wLOplyLaMNLTzDUrRmrUHetvs7eVGd9R8Q0N3nJHVMAGndPxGYtC4DqkeqC/1OkNQwZE05lsdz5uIUcN81MvW3kxYZ+hjMP7Yig3NkoONVqQQ+XI3DLQIMKPguI2quE7x8xj0UEvNX4Uz5M6kA= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2309: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 20:dD9Wnki5A6o+qCkACYEkehBovE8py6FC1yVInrVPIIpknW7+SBTQZQNIVBcue4d42HFUcJTmEzEmQawXfg79HMRREUV4udnsdwCaRnYFtU3/T8ol9bs2hTYPIzK2WpzHLY5rEa+cwQPL2uqqEePuUw/2UDsmfOBCXtMVVEnm6+9ySUz7tdJPxlMZsqdMYJj7iVJEXtwmcwiElVv6MfUzZw8OHXjxpX6ME05JaqogbizYilDMAonkdfvW9jf9s+tHjX/8yxWU6C42s3LhLvwZnfGKWoM6sxPMBv7yXZKg4OANwW8ZheOmKHukd/Fx0tw+r8Zta6Z1tAkoTDQQBANGNmD442I6OjoW49ZBhwTThM5Py4jhrm7zHoUJsfcYD3YIi6NS3WtM6EOrl8kzAHTu26s9yQluIVboxtoIg34Y083yElklcVS76B+kGTtPFdwQZTXZGYxRA/vBTQhiwBE/fhJa0HmiJ6GRXlKxNWMF7zoyjeQEt1vX44wZ1GzQj73V; 4:8TVPks6qs0maPY7/AeMU2K6C0XjozgdfoOCgs2p6eDLsERp7zhhPYfaa9aXRX0lUwH6gFtLgGaDW0vX5BGpXvC7hR9Z8QtXpyUh/JjXryIVFKwS0FytB5D47XkYv+m4Ej+e1AtqRWt+Kqws5wX/QXDi4r2DPnih7UhV28xb+ugiH7+GyzxZON0O7JKEe2hzpvkvnX9h01tTnU2xTFDguFXzbJ2oVrf8UQUobxBb/3AdlM4XNusmoA5mZRv+VDdSLCXXG8MtaGG3ZWOmUoTE4dw== X-Microsoft-Antispam-PRVS: <DB6PR0501MB2309BD5192EA4B78C3373ADBD19A0@DB6PR0501MB2309.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR0501MB2309; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2309; X-Forefront-PRVS: 0666E15D35 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(396003)(366004)(376002)(189003)(199004)(81156014)(105586002)(106356001)(316002)(16586007)(478600001)(54906003)(107886003)(53936002)(4326008)(81166006)(2906002)(55016002)(68736007)(36756003)(21086003)(86362001)(3846002)(6116002)(8676002)(48376002)(8936002)(50226002)(16526019)(386003)(186003)(50466002)(26005)(956004)(476003)(2616005)(52116002)(7696005)(51416003)(486006)(25786009)(97736004)(47776003)(66066001)(4720700003)(7736002)(6916009)(6666003)(305945005)(5660300001)(33026002)(69596002)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2309; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2309; 23:l5ajJWgNAsxq22IKfOuDqEB2BQhNtvOh98HLSzb?= 8rk6oD1CgvBdfSsD7Grg7+9XvEiZ4WUqcsnVFUtJPcl7GA0o7/axfOMDRwWYLg5hQJciQMVxoaw/UZkHh6PUQXwfBbocE7zU4h/9rsphI5VgL8hyjboCjQdWfs0Ia/ePdLfn235vlJxmGJvd62cJrXO5dOZuFMMkqoPpyqR44dzQa8SoP6M34rj8aWpwJpGFGpy4upyNImVSqoUIH5lI7/lSD2M9H1VnBI3oSuokUEo/0G/jxpZvyb/4gjTXGDgz05Gyy1mufjESatpivphX3PHIFeYp8AOALtwsMRwcL7T754HwNOQPdEtNC+Qd8R58b6Fgnpt16EDEJMOrPoRBrQJOov4zdWIp/6fN1t+0Hp4h4JRGqkQspr/ygE2sJtILyw4ZTwuuCqq6vAJTNCWMDRzVBJuzvCyl7hjPDd+SzmGeIzGtG65TfUQcCv4GE7CjYt8YN38LIkYL/4QljPEXgUNNuXboRvyG5tOyJff5QB4xYkGxiGTC1bkSR1G8hoz+eDxn/CVOc4uyoLMVfLKYfyh79xU3GbPke4D6IA2emzAqZfqKPU+Z9NK9auhN1vTVoxJUCk9nIsda0b3SRgwrceyGgFYGz7pVpk91zWWIdQdTUYNdpsL4Njmq4NGaMcMRGtrL00XVfKu5RO1dfOtgiOYwpnp0/xzFX2ioat5mQTpIoxYGtcfTFvqt6AJMLFTPTq+hdHiD7skr+fY9ttK9eOTS+MDn8kjMOvNlsVUaijhfE//lTesGqStrjEhMR8ugSEvrS2LY/CoVHoVcVQSGTO/Te+wD0WUsVA/qbdS/g989jAGGeaabD+huFgVGDXFfOFB1KiWAlmW2bFElYg2HmrXlYMEoNZVGday5lUiZ2yaPAebye5+voQIuHjxdohf5Dm7enE0EGYPOSnjKv0074ccw984JDglFes+d2TXrW0/Qzq3RHPwKbZVzStaZcKvAcwRpaYJpW7g397Z3btMikH8jNf5tZBVNdxMt7clqlG2GETkIH6/xnuQvP54e+/xx20U3/y5G+qYmlms3qAKQWiqeAXBan6WHOxanTt9ZXYqMqE2l/H8GEMXNkyz+roGvMvebxwAFA2KNsfKjqwa7V/3JvDtm4CLOxAz+EF1RQ+N49rzLflcVqelMJ4xtof5pSkq2XMCCZZQwwzkWjr1xzo3oDbFNOBW1sWZulBlcX9kJb1uTnyDSmhkpyWZtCL1wi2TpbLIn9iquqfLNQcJQC+2LF X-Microsoft-Antispam-Message-Info: 0sQTMHtD4xKosQePAVpzoLPbf9QKx/2rhtqcikh3IXlS+7A9kGtR5jeYfoFw0AUqxlnuGYqRm7BbEDCJOJebRUNHy0V1jL4tHqeNSwefa+Egr/ssYs9Pcd3FiTonxSuXdeNAcWQ8ycm1X0I9pjo/X3IGYu1mQiPBMdkZ/FgiXi7Gmw1NESdu3H12x5XNMYVK X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 6:P18SSAbOJO66LjlnN6PbrNQeUZ3ZbPLNIYH2FRWlrTtVqYMdFEdQ7vyB3quxWLdOwiCrYw/MCVXTWoWH/Lq6BEC95YXnwhEqWGVniPvUcKxGsUUcPr8iTZEAELvGB8Jt4jIPKkv+VuKVECXRDk9Ih8ees/udAuDElGzAfJbX/AXJDwm/dOpIVcOW8ArrcaYghgcOg0Zke2khx/2Jac5xFacQ52S00LK3VwmEMybB1nXL63k2qaYHuM6t+vv1clIeUT+9yNPr/crNRTHf3owzTZM3RBy/BBKdlmZ9ZwEQ3W+I5yJAOkPbwreh5e+PKVdnj8Q00lAmXwUZbcBMT0g+yEtAm+PosBKPDi4xfV/Pt9EH8Y+73vTNxfGupv/C/eCFNEJLKmjhvaaDH7tywv5TYRkcBfnXHHw7VZJbS8bASd9kjYb6+A8Hvk56HSdOtRz89a3m3F0vfvK7x4+ESA747A==; 5:UfCEblz0Ne2oSHJV1M4p7JJS/8WVFd7YGyz8Xi975ToqJQShXlevxS2iYT8NXyiqb4RvWzVSP/TcsxMAh3l/2xALnNfkTpKjFFYrYPrBmKdksIxdP4iy2yGdBpiSc9A2r0OvxHbTZVlLjGgw/pPGJwpEhRvTfvjFCI2KnO8ebpE=; 24:ya63AUlxfLHOwNPs7syxrrB+CtafHNnv8tlQkEfXRhxqOt16j1liRM5nbUhh4gbAkbJBy+cGCY33vwnbWDWjjOhKDgBBkrAJeT0aKo1YApI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 7:iggVhdVOSDtxlngbP2CgWq0ES1bGz8wisbyOUel1Z8PXACAExDh6rolUPBXcUXAAg1nyy0YRdRYDLqv4K/IkZahlXOgrGCM2BHLXR7jDpvkIXQynvYiRUF8LzvFXz5p3m8GbxOLZenR+tBbB+N8FoAlgQQcxPQ+8absVvW/geG1bEsxT2SwV9Cu6ac8roW6cYrIJ+OZXKXsP7cXvftvO9BZfWWAeA0TWMox8rJs7C5wQ6QAti6oJhaejN0Mcsfjw X-MS-Office365-Filtering-Correlation-Id: 8cb4f8fe-c860-488e-bd2a-08d5b4df83db X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2018 12:30:41.1653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cb4f8fe-c860-488e-bd2a-08d5b4df83db X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2309 Subject: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Ophir Munk
May 8, 2018, 12:30 p.m. UTC
Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
doc/guides/nics/mlx4.rst | 7 +++++++
1 file changed, 7 insertions(+)
Comments
08/05/2018 14:30, Ophir Munk: > +Limitations > +----------- > + > +- CRC stripping is supported by default and this capability is always reported > + as "true". The ability to enable/disable CRC stripping requires OFED version > + 4.3-1.5.0.0 or rdma-core version v18. I think it is better to merge this patch with the one fixing the capability. So we will be able to refer to one atomic commit in the history.
Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon: > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > 08/05/2018 14:30, Ophir Munk: > > +Limitations > > +----------- > > + > > +- CRC stripping is supported by default and this capability is always > reported > > + as "true". The ability to enable/disable CRC stripping requires OFED > version > > + 4.3-1.5.0.0 or rdma-core version v18. > > I think it is better to merge this patch with the one fixing the capability. > So we will be able to refer to one atomic commit in the history. > If you agree Ophir I will squash the two patch into one and merge it on mlx4. OK?
Sure. Agreed. Regards, Ophir > -----Original Message----- > From: Shahaf Shuler > Sent: Wednesday, May 09, 2018 1:07 PM > To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk > <ophirmu@mellanox.com> > Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga > Shern <olgas@mellanox.com> > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon: > > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > > > 08/05/2018 14:30, Ophir Munk: > > > +Limitations > > > +----------- > > > + > > > +- CRC stripping is supported by default and this capability is always > > reported > > > + as "true". The ability to enable/disable CRC stripping requires OFED > > version > > > + 4.3-1.5.0.0 or rdma-core version v18. > > > > I think it is better to merge this patch with the one fixing the capability. > > So we will be able to refer to one atomic commit in the history. > > > > If you agree Ophir I will squash the two patch into one and merge it on mlx4. > OK?
Wednesday, May 9, 2018 1:32 PM, Ophir Munk: > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > Sure. Agreed. > > Regards, > Ophir > > > -----Original Message----- > > From: Shahaf Shuler > > Sent: Wednesday, May 09, 2018 1:07 PM > > To: Thomas Monjalon <thomas@monjalon.net>; Ophir Munk > > <ophirmu@mellanox.com> > > Cc: dev@dpdk.org; Adrien Mazarguil <adrien.mazarguil@6wind.com>; Olga > > Shern <olgas@mellanox.com> > > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling > > limitation > > > > Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon: > > > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling > > > limitation Applied to next-net-mlx along and squashed into http://dpdk.org/dev/patchwork/patch/39461/ > > > > > > 08/05/2018 14:30, Ophir Munk: > > > > +Limitations > > > > +----------- > > > > + > > > > +- CRC stripping is supported by default and this capability is > > > > +always > > > reported > > > > + as "true". The ability to enable/disable CRC stripping requires > > > > + OFED > > > version > > > > + 4.3-1.5.0.0 or rdma-core version v18. > > > > > > I think it is better to merge this patch with the one fixing the capability. > > > So we will be able to refer to one atomic commit in the history. > > > > > > > If you agree Ophir I will squash the two patch into one and merge it on > mlx4. > > OK?
diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index 9564f89..a6bbde8 100644 --- a/doc/guides/nics/mlx4.rst +++ b/doc/guides/nics/mlx4.rst @@ -143,6 +143,13 @@ below. following limitation: VLAN filtering is not supported with this mode. This is the recommended mode in case VLAN filter is not needed. +Limitations +----------- + +- CRC stripping is supported by default and this capability is always reported + as "true". The ability to enable/disable CRC stripping requires OFED version + 4.3-1.5.0.0 or rdma-core version v18. + Prerequisites -------------