diff mbox

[dpdk-dev] net/avf: fix Rx interrupt mapping

Message ID 1525316935-108339-2-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Helin Zhang
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wu, Jingjing May 3, 2018, 3:08 a.m. UTC
Vector used for rx mapping is different if WB_ON_ITR
is supported. The mapping table need to be updated.

Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Cc: stable@dpdk.org
---
 drivers/net/avf/avf_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wenzhuo Lu May 9, 2018, 5:24 a.m. UTC | #1
Hi Jingjing,

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, May 3, 2018 11:09 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/avf: fix Rx interrupt mapping
> 
> Vector used for rx mapping is different if WB_ON_ITR is supported. The
> mapping table need to be updated.
> 
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Cc: stable@dpdk.org
> ---
>  drivers/net/avf/avf_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index
> a1ae3a2..db0eda4 100644
> --- a/drivers/net/avf/avf_ethdev.c
> +++ b/drivers/net/avf/avf_ethdev.c
> @@ -339,13 +339,13 @@ static int avf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
>  		AVF_WRITE_FLUSH(hw);
>  		/* map all queues to the same interrupt */
>  		for (i = 0; i < dev->data->nb_rx_queues; i++)
> -			vf->rxq_map[0] |= 1 << i;
> +			vf->rxq_map[vf->msix_base] |= 1 << i;
>  	} else {
>  		if (!rte_intr_allow_others(intr_handle)) {
>  			vf->nb_msix = 1;
>  			vf->msix_base = AVF_MISC_VEC_ID;
>  			for (i = 0; i < dev->data->nb_rx_queues; i++) {
> -				vf->rxq_map[0] |= 1 << i;
> +				vf->rxq_map[AVF_MISC_VEC_ID] |= 1 << i;
Looks better using " vf->msix_base" here too.

>  				intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
>  			}
>  			PMD_DRV_LOG(DEBUG,
Better updating the debug log either.

> --
> 2.4.11
diff mbox

Patch

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index a1ae3a2..db0eda4 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -339,13 +339,13 @@  static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 		AVF_WRITE_FLUSH(hw);
 		/* map all queues to the same interrupt */
 		for (i = 0; i < dev->data->nb_rx_queues; i++)
-			vf->rxq_map[0] |= 1 << i;
+			vf->rxq_map[vf->msix_base] |= 1 << i;
 	} else {
 		if (!rte_intr_allow_others(intr_handle)) {
 			vf->nb_msix = 1;
 			vf->msix_base = AVF_MISC_VEC_ID;
 			for (i = 0; i < dev->data->nb_rx_queues; i++) {
-				vf->rxq_map[0] |= 1 << i;
+				vf->rxq_map[AVF_MISC_VEC_ID] |= 1 << i;
 				intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
 			}
 			PMD_DRV_LOG(DEBUG,