From patchwork Thu Apr 26 09:05:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Jozwiak X-Patchwork-Id: 38994 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ACD74D3A; Thu, 26 Apr 2018 11:05:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 245C62AA0; Thu, 26 Apr 2018 11:05:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 02:05:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="50962291" Received: from tjozwiax-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.103.104.45]) by orsmga001.jf.intel.com with ESMTP; 26 Apr 2018 02:05:53 -0700 From: Tomasz Jozwiak To: dev@dpdk.org Cc: stable@dpdk.org, anatoly.burakov@intel.com, tomaszx.jozwiak@intel.com Date: Thu, 26 Apr 2018 11:05:49 +0200 Message-Id: <1524733549-3662-1-git-send-email-tomaszx.jozwiak@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] app/crypto-perf: fix pmd_cyclecount_bench_ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" this patch fixes segmentation fault in pmd_cyclecount_bench_ops function in case when state->opts->nb_descriptors is not natural multiple of burst size. To reproduce run: dpdk-test-crypto-perf with params: --ptest pmd-cyclecount --pmd-cyclecount-delay-ms 5 --devtype crypto_qat --optype cipher-then-auth --cipher-algo aes-cbc --cipher-op encrypt --cipher-key-sz 16 --cipher-iv-sz 16 --auth-algo sha2-256-hmac --auth-op generate --auth-key-sz 64 --digest-sz 32 --total-ops 10000 --burst-sz 255 --buffer-sz 1024 --silent Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") Cc: Anatoly Burakov Cc: stable@dpdk.org Signed-off-by: Tomasz Jozwiak Acked-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 8f76160..c8d16db 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -145,7 +145,7 @@ pmd_cyclecount_bench_ops(struct pmd_cyclecount_state *state, uint32_t cur_op, for (cur_iter_op = 0; cur_iter_op < iter_ops_needed; cur_iter_op += test_burst_size) { - uint32_t burst_size = RTE_MIN(state->opts->total_ops - cur_op, + uint32_t burst_size = RTE_MIN(iter_ops_needed - cur_iter_op, test_burst_size); struct rte_crypto_op **ops = &state->ctx->ops[cur_iter_op];