From patchwork Wed Apr 25 16:15:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ophir Munk X-Patchwork-Id: 38957 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5851AA48A; Wed, 25 Apr 2018 18:16:15 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50086.outbound.protection.outlook.com [40.107.5.86]) by dpdk.org (Postfix) with ESMTP id BD1A78E56; Wed, 25 Apr 2018 18:16:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=e9ufzF3dfkbNZoz7dhJB8ru2bWBytCWMr/7/kLwvz8U=; b=AyhGrJxqqUofOv8mI1xzTO17rK3ou3aujBLqcSnBEak9dAPVsQgBzpihdsRfd7LkPoDeoKC2yL/RzvlO0jGICL4k6w05oZCqYkEQSvTf2IMYjzQl6q6HZtUEEnJDSJYJJV/l7ZXCcZ5wEqWWcWlkegV0tZsIJzjqn1VYHzTz9/c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0501MB2309.eurprd05.prod.outlook.com (2603:10a6:4:4c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Wed, 25 Apr 2018 16:16:09 +0000 From: Ophir Munk To: dev@dpdk.org, Pascal Mazon Cc: Thomas Monjalon , Olga Shern , Ferruh Yigit , Ophir Munk , stable@dpdk.org Date: Wed, 25 Apr 2018 16:15:57 +0000 Message-Id: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0112.eurprd08.prod.outlook.com (2603:10a6:800:d4::14) To DB6PR0501MB2309.eurprd05.prod.outlook.com (2603:10a6:4:4c::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0501MB2309; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 3:0sK3GF9+Z0mOUE2hLg8SGQJe3gPU22ehScOl0ZbHIqG9EJsOavr27OmRTnUdRovAnRyuB2Du/l1mYq8dM7pYAk/uWxuwJHXdstvltRf/LY0FhrWBksB3eiBe9Hi+Avr5m6u38cPNekK+bPj/ET3YmVd/FltMoXCwfqUrc2dRQejtMfpSaBEpTkKGxmHJu4Y7sN21vSj/M1kxoJXv6P0/mX84CBOUMHmo8jkEpAaXOQglOY43AGyrDNblXJBeNE+a; 25:oAuTl/b6T4XrwfOWb5eMaZlzTRQNV53sqLd96YYwpFO1U7zMRY/m/PQA9FKZ///sdk3ZwgwNGuXdf6ZmlOE8wLN/IlhOr1c/SUN8I6O4fo4T3BpXKYtMjSLwaHsIyHRqs5G6DvG+5ug8uJkmyo7vn1l0qj+IlT3I87/RiUAS8UCOt33tcewDgG6TF91TttVYuzbJRA7QFTNZJsd7JkG+PvO6kn1k5I9h+8FsODpEW9BZOE6TczgAjBGPBN0kMRB9nex3GkGGPQeawjDXLcxgo13RDpYll5QJBUNOlZ2kaw4KiTBNIFu3B0KfvgOITUs5H43RB410j1uGq4k7H/B36w==; 31:Nb/lZxrcNV/JRh77fNcA0kWzSEPvmfVy0STbGWhhI1SgEhoTxu6r5VhLBuQGTtlZ2zPChvjF3tMxPfgCcpiUmy1h2S0mTmanAJLVjJk2572sAS9ujJiBhSXKFDf1evxpcogz6QJpIp6A9Ivkpif+MmqJ3EY0Xa7C+bGNCVQ/g85U9wi+ULDiPBAK78//EDFrc3F4afcoDTLNoz69wKT+eHYTOBV425HPiwAYfVSLPtM= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2309: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 20:KmJh5L7c9xYEY9ifpWECQWw3wXs8eiNG2p93JNj8KHarBQh7zMHwWZdS06NTjMlucsoEIL8Uxcd2iNIhVYCIqrSAOZZ60713FR1/2pmcln+ObGAxPl+vhZGxj1CcdfSyWd06a3nnOMWO3KeHX7oYBhDs6uzFsLBPeMWrBGpzcYOcvTnuwmtlVZ3flhbAJySkGKoJBJKCfq2iztRPfb4L42UcflU2n5wE/aPg+P9LWXJ5QKqsNt4F+IrIm3ZwLSGYMqAhIsHyB8wGgfZ2fMGXoA2oJYGBSnKtFY/rIv5rfXtlNflKqz8MvjHMag+dtQwyuIYDgmOlI4CW0y4D0sSezzAU2CYUABr8KvsGImNSnLSppLCa68jIVKOwpjcMKnbztCllJYhmGN6EForHWaOt3dCOUEaZWvFeEMEIPMqVs7t2z0PJMcRNOACyxERRgR7InU/BqejU135bcwNQjJp6x6K9lCdZ1+kz8TOxxlSs/QOuVD0pLamPWg+HJwOSJr95; 4:ca5FAxrI9nSV0b32DZlLkU0+7qoloIPOh0v9Ivw7Bh7xpkZoVSsPUwOp3mguCiNs0K/zxGyBOczsnq2wCwYGNzs5ODeyGasuLrGZ6NSPFLfaiBRXDRs+OXKE4Y7X0br5hvvyxv/QPkBaIWjf7Kd2r5gGqR7fFBTaY8Z+334NXbanPi9i1kbqOOBqBGUwb3nsmmmjF6uioxo/FFJm64DwYR0qKKReTqFAfJ1kpT2PzpVA+F1kMwhlu7QWLp+fa32TKEU9QXsi1m7fSQsUuk2jUw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231232)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR0501MB2309; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2309; X-Forefront-PRVS: 06530126A4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(396003)(39860400002)(39380400002)(189003)(199004)(7696005)(52116002)(6666003)(68736007)(53936002)(16586007)(36756003)(478600001)(54906003)(69596002)(186003)(316002)(16526019)(25786009)(33026002)(3846002)(86362001)(6116002)(55016002)(2616005)(6916009)(26005)(48376002)(47776003)(81156014)(50226002)(7736002)(8936002)(8676002)(105586002)(106356001)(59450400001)(21086003)(476003)(305945005)(2906002)(4326008)(956004)(50466002)(51416003)(486006)(97736004)(5660300001)(4720700003)(386003)(66066001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2309; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2309; 23:FP48fyrTSu19EdeoO0Lfi2ELfq0tJbdlYKEjEU6?= YzoYdp/VXnNjfpcO8cDiDyFTM8crOb7vygUmUA0M+6U7txufp+E/d1lPQ9QvWczUheQCYFcQ+akDUQc91HIclqLqJCWtlwNCjLG52GKOVrMR1jeKs4wDNqoeB52U8QmdQpaxjWDYsHGj8JXPT/d1qe1JpdwLeKE5LnkdXXevDayf3TIQsfAVh8RBJa7r+8oI89EQ68/d4QBrUnSmQzXbZZGgrPhIs0ukI9JaL1WoDWQeh0twKap0E6bFSBUVFBZLmPTKyyVeVhnoE7EyYZDszwIO1Gp5/zIpjl0Rpevkx20Ns78ukQE2Jn0alFkKN4cQreDTNIA1mU+4CPpRO5bkRqYNeB+8urDwB7Xb7LH88VO54X9/G8dgvLTjJLYpk7OP3qn9HO16TzOZpZ0342slkM+QC4k9BG6MpegWm9djtV+JvWirPo5DhNKHq26bsDWNo/7VOOyD7pLwnaNzeTW7cR0Vf1cDdlJ1ulP/S879PlVsa7pTcKGF0nvRifjFkA9PkNqx/0HKbEqVloaw29Zy30ez719eDXMDlD+avmgHlYRp/oRIKl1hQmkdzRdSA42JXaTp+rVN1VXM1irwoF5xOq725OGxDPJb0ez64FA6Cdc3OIpJu2wFH3sBK7oqZMUONTVfShSJRcZrnZTjSwVVVibWIubTgTH51bC9TS6aPu5nHIW+edg+A2cdxhGZRhI66QRcyeHWu5EpfVMwFb8KjPYyudG8Jp/pQIkpm19Y9gNVRqw3uTTl43bMv4aTNBsPOy0ckZpewOJ/FiWPN/pnVUNFF33JiNBOQGNsw4tp7JyLvSB46PFjUZFfIyvEPIDGjm6WzXfLJ7TxWEBo11CUuA6FIrMIf1jwV6nSQDADZ40IC7ZtZcKmV/HM62fcMK+QJuD6r+2WIIY0qUP8fyTSf1tQZR7AdVhn9hGWfFKq2Fjzt1CyDqk5/erENq0dfwKsAfGl/zyUDh0lRVTD9Oa58+eEQRYos8UbMkfwjAZsM+wERTVN+x+YqqxXv5VWBnotlV/27bIZsbQ9S5l6axEtcuo0IhgvmgZzxnVulScT/Detihq3ob5S3bvc8zD1SMv2agKpp7S7e6JvwBeA3eJqtqTae8DGf4xNHP//64NSSDkzIN6fbp7egvs9u3KVZNEL4VT9Uz8HYOwLWDI+J1Zw1uH8ob9TmOKl0hNGdV6FC30MJ2lpnIQ41R7DOx+kEIpHMk24= X-Microsoft-Antispam-Message-Info: f6d4+ig0fz7ANrDVsRFI5k8eMKBXQGHU9JBCUXlRskKgDlJmETnv8rPSCfqhisBmmwCweVAkHLQbzKGLOT9thkS05jiFR53k1XP1J3GKKB6kM01OjxE39YT/8LZ0qtXf+akmnBOdseD9EgJHAJEQo3mXFwaEGWEWhgW2ZE/z9xKCEBQnbaJH3/iKzSlgZdTc X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 6:HesdysvmvtTtANHv5uhtOkfSHHi/W/6nROhrXUKvoE5s9F6Bhz18RJF+QLPPRd1vCVWk/zdD7kIimmmktuZKSdFYlVFwQEDN7RPDDtrUWl3Xf518pKp4LbuzcY83sgxKDvlEwn85WLAUQf9dTC0GvzihZz6Rq2c7egVINqZ3WtPIovP2VZdpfecb3X3am/EobOp0UMruiEtwPis2KTYbMZOhfk+3g+ajpnu2sP0bhuWy+7MvELHemrLBdOMrdhMsZOjbR3TEG2jYKm3FWeSvXqJStu1wtnbWdNY94B6Q7LsAfNpxffm9G1vdMKIwRDhGEHrBM8zL/AsAsCYkvyJWvK1n/kLCgwP8SDKSOx91hkuKGfxuqlvmMzVXt+g/jn3/0aWJvoiYEKc15Kxz8PxCdOs6a5hcHnDr/sCxfDX/JjF9Qm2klyi0d/7cvtOx0OifVQTLx29mLInu3AZvKc/iSQ==; 5:xZ6g3VRcLPaTQ+HALNlp8CoAaBbvZkUmUsc9CAa7tJ9316GG2Q//+cTwmrVHXc3OC1akeHd9Llsae2iWJT4wZu+iD0e19wumXEbdtGbp0GmycR1dH6flbYHMFmdcoFW4hIHfjqAstVFFD5S26SUYBIjNf0gPvsUeE4LOnylMJ0Q=; 24:4bj1h7wySqseF3mfElZhMhX3p3jmUBQ3Lcx6aJIcfkNXLptuH1KdD91v4ofCIowve+uo3nM8ieX7QxTL8Dcv+Y52aaj57YcyJ7vYsq2bvWQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2309; 7:csuaZiqrDFRp7nsjbZGoQyylJ64dFh/ZxCkVBZRtEuPsi1p8cka6uuHMMS8KdybgZRX9jNDEoxWdr7xhptV5zUt4tkXA0mieocOMxS1fDUUwGtGNZqS45fVizNG0MD6iK7v4c+2JC1XCC8ptTY0D19sTl34nZTsi7OS3Ufzx+gjjBVUc2bw67/OeCS6OPskLovRU+BCNbqJtGQdSh2kzt1za++BkaA4kbuIvTygf5DkFeSNXhEYXXFg9Hg3FHEQW X-MS-Office365-Filtering-Correlation-Id: fcea5649-5fd0-44f2-1dbf-08d5aac7dc2c X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2018 16:16:09.9229 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcea5649-5fd0-44f2-1dbf-08d5aac7dc2c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2309 Subject: [dpdk-dev] [PATCH v1] net/tap: return empty port offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix report on port offload capabilities to be 0 (no capabilities). Before this commit port capabilities were a clone of queue capabilities, however the current TAP offload capabilities (e.g. checksum calculation) are per queue and are not specific per port. Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/tap/rte_eth_tap.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index fe62ab3..aea73b1 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -269,14 +269,9 @@ static uint64_t tap_rx_offload_get_port_capa(void) { /* - * In order to support legacy apps, - * report capabilities also as port capabilities. + * No specific port Rx offload capabilities. */ - return DEV_RX_OFFLOAD_SCATTER | - DEV_RX_OFFLOAD_IPV4_CKSUM | - DEV_RX_OFFLOAD_UDP_CKSUM | - DEV_RX_OFFLOAD_TCP_CKSUM | - DEV_RX_OFFLOAD_CRC_STRIP; + return 0; } static uint64_t @@ -403,14 +398,9 @@ static uint64_t tap_tx_offload_get_port_capa(void) { /* - * In order to support legacy apps, - * report capabilities also as port capabilities. + * No specific port Tx offload capabilities. */ - return DEV_TX_OFFLOAD_MULTI_SEGS | - DEV_TX_OFFLOAD_IPV4_CKSUM | - DEV_TX_OFFLOAD_UDP_CKSUM | - DEV_TX_OFFLOAD_TCP_CKSUM | - DEV_TX_OFFLOAD_TCP_TSO; + return 0; } static uint64_t @@ -787,7 +777,8 @@ tap_dev_stop(struct rte_eth_dev *dev) static int tap_dev_configure(struct rte_eth_dev *dev) { - uint64_t supp_tx_offloads = tap_tx_offload_get_port_capa(); + uint64_t supp_tx_offloads = tap_tx_offload_get_port_capa() | + tap_tx_offload_get_queue_capa(); uint64_t tx_offloads = dev->data->dev_conf.txmode.offloads; if ((tx_offloads & supp_tx_offloads) != tx_offloads) {