From patchwork Sun Apr 22 14:20:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ophir Munk X-Patchwork-Id: 38673 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D8861E35; Sun, 22 Apr 2018 16:21:13 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10074.outbound.protection.outlook.com [40.107.1.74]) by dpdk.org (Postfix) with ESMTP id 9D4DD1E25; Sun, 22 Apr 2018 16:21:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+vszY+9a0O/3UQDYshZJrspDNAB4eQilW8Ea3ppDcug=; b=CQO2ZdsU5J+jQOvrMWGGR7USZvCd4P8mBvByK0Hrq+bonr2MbFMBeJS8Pk5unTZerzwH5Fm5XhH8+pq9l/T69WFuvbkOVXWzAm2RrjZGyARMTTUODIZcBJ5/lmEQrMPnb6U8slsAf22Ver7Nwo5GoRrCMNlLfaclJKMQ4HX7+VM= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none; dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Sun, 22 Apr 2018 14:21:08 +0000 From: Ophir Munk To: dev@dpdk.org, Jiayu Hu Cc: Thomas Monjalon , Olga Shern , Pascal Mazon , Ophir Munk , stable@dpdk.org Date: Sun, 22 Apr 2018 14:20:59 +0000 Message-Id: <1524406859-29585-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR1001CA0038.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::24) To HE1PR0501MB2314.eurprd05.prod.outlook.com (2603:10a6:3:27::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2314; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 3:QaS/oS4qE6MSnJCSG/gIiP4EXsvha8H0FPcQ50UkUz7GxtyyBPHiWQolYKUDJZ9fK+bTDd/APx3ox1ZmP1iClvJLEsMsckt3zBJmQqCAOImhnRo8X13PuEggelBCv/tChr7+gd0O35md5gEnJt/4387Ai2MQ+8ptTnOt7/y6YqD1H4onU+YOFdzLI3boqbrRplYYToQSkdPB6yZBHyV85m1ojmsEZK4fJJ2GSRAgmvT2E7L1F+5gRrMPMKdExxMO; 25:mj8xzJ1IDx3fwqEdWLOk7Bs+KFRXZ4/7r4YX0kkascaGX+7soj2gP8dADhoe+qexBrdw5RFA1QV5jvSj7bcE5/zXoMuDRYwUwqIDzYjeqdvF4MfgChL9phlmP+L4BSahSIL7Dvc+6Ll+aeLH/hib+3DeHfdWC4UQi74kpT5klkVIlhLc+wCaFOfNog8SUmxm+6/o7LgdCfCpolvnlOwpWDLiG+UoP+Asj7hXd78EN6VcjvPm261I4q5sabL3YrGD6WWvMDrnnnd1Px0tQx0kNt0eWUdUtjC1ZHen+gzZL/bzdAfPZdQpiKbMwGFrsa4zREijJRgduXKPBiMfx8omqg==; 31:wvFQinYHeHv3cGgYv++sfi0p0ycBpFtNZhem4mD8ds2xO5tY3kdgOhE9BjJPX0SO7pvXzQW1WWl7o3niXNLfyHQyX9j98Pet7Grux1ae9X0X2CdSmvYDPmzPEQYLTY3T3QYtKgbwh3RFr28Olv6tkoGdUuDqIG5q0ptnqbFAoug9spoA+ATidSKMqFWYs5m4Pk9qqGyd7AdLHgLTANg/vE7GWy4lAolJWqjBfjkYD90= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2314: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 20:4B7hVlV90MjB3TFi2O5cWGpBmpQuCC7dJJOI6LxE40BqJLTGKwqLNO6In1tY4yFUd096Kt2+3nMbuKUjPJiwrJmqGgw/dipJx6TIkTOaYFgzF64u3MGxg/v6xGdnKIE0BPPMmOyUcfL/fLouN+x3QHvRNYqp5pipfxP6LWqnZ/b8HbHcWX/d82p2Taly06mr5ION54JofGzBgdiu6sGLUgivLQ5nDC/NSU8+1EPTBZOxSBLU2HPl/3hxiaxWPgQJYJc6IPibCPLmZ+KPORbAhL7MkX7BPSDVDt1fCPWz4nib1l+CIls/g0tiUBV8+pqIpLffDInJC6k/g7iUAFugXPuYvmQlvnPq0pTtvUG16IJMHSa3ZdJGYtqYSJrz+F5rgb5a5MZEgXQOWi8MmIZluwmEpxv2rrolCvDLCUTMHvhbvWl3tDhXHEkJoSzwTQGOR78PUBTOx/IS8CkF4xf9isKjth9Qqt0ceLIsFIDd/o7fHks6wPK943fUBh8BqjvG; 4:PDqDygvKOAM/Re42BpG+2bpo9VUsYVLyc97y+g98Rn2zS7ue0kEhwYKnN75psTn/gO5cyoO9CNdY32QiylQnqQv28RdJvehl04xqSjtb2VPV4hgu3x5dnwTW6/7+o05L+dXO7D6klE151EOjAuAovR5F+MokAYx9yPrUriIIlqUX/biKsyTcwAamItEiHGR7GlIrbAMpFigHUIKtur0MEEJixsRXYL0rhJ5w9MZJXyTh6eRWsFlC1q433VfYg9pC39gSKZ1nmJgXyepgUbyWeg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231232)(944501410)(52105095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2314; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2314; X-Forefront-PRVS: 0650714AAA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39380400002)(39860400002)(396003)(8936002)(50226002)(52116002)(2906002)(8676002)(81166006)(7696005)(33026002)(5660300001)(316002)(16526019)(186003)(36756003)(50466002)(26005)(48376002)(2616005)(956004)(25786009)(4326008)(476003)(6116002)(7736002)(478600001)(86362001)(3846002)(59450400001)(6916009)(54906003)(55016002)(53936002)(305945005)(16586007)(386003)(4720700003)(6666003)(66066001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2314; H:mellanox.com; FPR:; SPF:None; LANG:en; MLV:sfv; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2314; 23:2i457apofm49cUzra+//qTCLVgJ0e06fEHRRj9W?= vjU715PuKJN3U6Mu+jfZruqYWBMCuMsRoFdaAR2SMYVkLA51POBTW4Ns3mhm997X+VNe7/En1smDG9+Qb6PoO0eBS+yTNzUwanjNzyKLjODub5KLkuEPqG7d0iqjZFuiO3Xp9uO/v6wEtVgdWth5hU+wJo6d8g8+hFqtRPgVS3FKXeVFizeU7l0xvT1ohAAGIHDIXmcxXWkU068nH6ZUlajbk/LxOvDG6a8UQj08lej5o/wl9piPF/Bkl9nwZKso1w+CROudFPkhJYitaTLce4mql/x7X2k+H4oFCK4ut90USvqA3CSQkP+x5aQCAp8V20cxiPSZzvC/fdCWal0EiOOvUc4zj7nkk+ezVbphN/WArGQPh0DnnTg7qMpcM0OeN+bv3XdoxPFR7AN8najnYjZKgCPfjVUBBXENtahOlu77Do0/QA32O/Ai9QOhb67i5dh0HDDsNp9HrFBRMqUojQY6408zy3HFHrzVl8sPjEExb6Vz5XZ1OyTtqYTx+bFhtvgvS+Wek+QpNrSnXC2RnDrVPvqoMfIhBWdLydvCs68SLGotZpUAQKahZzJIT1CI+aG35xhZT+/QRwhyT1qsLo+IobllYzg1ZIB6K8fwxewxbEncdoxuVFfnEa8MdD9E5lNPnuNzx0jfNWRlvXwyLcBpyV4CzHtGYZkr9SmCGcZv9b1Iea6UGv2YTNwIAKa1xWgLiPgkPkzLxe+mIFlveRIXR0OBW3r3CEO3ZVoKPBN9Xba2VFLownHUO67u8CLCX6UQXNHGENLb9Qkmg2Fqii5T4dc71nCMCVgb117s2xZLR7HIHw4uQdMt1ZtNVb4wBSAJBEF02nECfo25i2yTbWUet8j2jIpxpTnAjFx2EPQmNKhL5qUqqClyHP8jDByei+VBDsxx7mQu6kEfZ3fNUvTZcW4wFBINIr4QYsyKzo0LmVtVqCoDF3xucx5tUeWcw+5gFrGBuCsdJlF0IaWu85NtKsEGIIduT4JYIvoTOacJrBw== X-Microsoft-Antispam-Message-Info: uehVnkUqWTJuwdLT1o2CNo3heuqx6oMilbdxJ0CZMfVp4yiflNHUVffiCevIjj5VKX4R1wH1AgQ6r5QGKGLcWw3l+uehzpxeVu2SkFT9BVPKK5b/sKkGMAipOhTSJGw2iazqeVWMSVayGdKs8ddqkXtfL1s8/qJtHKqIcIOJ/mZ+rh6CJ13EtzWcvnk9/ZGm X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 6:Pij3IOOkMP9FjO7FqdJHQLQMULnTF4102bchFrwhZis0debVyIqBP7sjZM4tjti3cxmnDz31WXYbZcZOWAVo2e+NgI3iBQgxnmSyy6WWITzt++rRo0YnY5o5Y+FwIxF9pDZAYNz0LuII/2z6KcIEqLHrHXyq6eGU6fcDlknSE5RS6UgsUbvBwi8MBXihGpDKgGoF7pMjSUDvE7Rhp0koBMMj6XvJPtlAa6aqZmp1TnlQ/Vct9sDhWK1UdxmDo5Cd/CqF2vWZDl0LwyK93OOTxXFnZESC0lXJRWs/PlooN4huDcE1yQ1Icdr7W953XwHRs16Vw+UQNBGBhs9t2EmoVwrW+/L3Z1FTYwYN5112VD9vD7POg/R3/CGmmx0uEJ7SZJgWCCvaMY3g7Rq42KNMHt4hsbSNkxuT7dCT8fORE/71NKXab33uQe7242ALj4kMgS0rhLReg+c0sZPXzaCyyQ==; 5:chuCS4Uzt35ZejjYLfUsxF8O9DdUcPyGNGfhC8M265m8tUalIfRsCo+K4ByDyT23WOvb+ryDF6llMx5+aWplvifQZ0far0wRR+YrabI/2om5S/IfTTz9cdx/SXYM+tDAeDDM7+07ZuxoJxoATC7er+r/daeSsXMgr1D9J3LBUBA=; 24:A45xx1giNwKlpjZYbUJxBdyUC8pXeEB/QiVLfkRA8OmbxGnZ6Re2vLPJGUZkm2TofGiZhgx6Q74NNHy8etYQA2Z42/55FV3FJgOT3wwf7ik= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2314; 7:PLjtVKe9kVrHVYIKlm6RCVxXD/XirkwqOhwZ6lpPCE3JrLz+rraLF9gNEzhkxZdASiUECLHgaAhpqjm2k4NM23t1syeJfL8+kRDV/rcqMAxRyZClsux6eLlNYk31L1+7oA9+tj83I4w4TbyTO7b33XXwI9BFp28WneCecvU2hJEZiofSYaDM46TSO0YRttvWwBgd+Zm/wOUFMyocHSw30sVIlaebsPjTfcQflhoAJfpByoQruMZMjR0oSJqJK3Ar X-MS-Office365-Filtering-Correlation-Id: 52cb6a2e-f8c6-48b1-5467-08d5a85c4b45 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2018 14:21:08.2179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52cb6a2e-f8c6-48b1-5467-08d5a85c4b45 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2314 Subject: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Large TCP packets which are marked with PKT_TX_TCP_SEG flag are segmented and the flag is cleared in the resulting segments, however, the segments checksum is not updated. It is therefore required to set the PKT_TX_TCP_CKSUM flag in each TCP segment in order to mark for the sending driver the need to update the TCP checksum before transmitting the segment. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- lib/librte_gso/rte_gso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_gso/rte_gso.c b/lib/librte_gso/rte_gso.c index a44e3d4..e9ce9ce 100644 --- a/lib/librte_gso/rte_gso.c +++ b/lib/librte_gso/rte_gso.c @@ -50,12 +50,14 @@ rte_gso_segment(struct rte_mbuf *pkt, ((IS_IPV4_GRE_TCP4(pkt->ol_flags) && (gso_ctx->gso_types & DEV_TX_OFFLOAD_GRE_TNL_TSO)))) { pkt->ol_flags &= (~PKT_TX_TCP_SEG); + pkt->ol_flags |= PKT_TX_TCP_CKSUM; ret = gso_tunnel_tcp4_segment(pkt, gso_size, ipid_delta, direct_pool, indirect_pool, pkts_out, nb_pkts_out); } else if (IS_IPV4_TCP(pkt->ol_flags) && (gso_ctx->gso_types & DEV_TX_OFFLOAD_TCP_TSO)) { pkt->ol_flags &= (~PKT_TX_TCP_SEG); + pkt->ol_flags |= PKT_TX_TCP_CKSUM; ret = gso_tcp4_segment(pkt, gso_size, ipid_delta, direct_pool, indirect_pool, pkts_out, nb_pkts_out);