diff mbox

[dpdk-dev] net/ixgbe: fix missing suppport of multi-segs offloading

Message ID 1523951030-32261-1-git-send-email-wei.dai@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Wei Dai April 17, 2018, 7:43 a.m. UTC 
  This patch adds missing supported Tx multi-segs offloading.

Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Yao, Lei A April 17, 2018, 8:32 a.m. UTC | #1 
> -----Original Message-----
> From: Dai, Wei
> Sent: Tuesday, April 17, 2018 3:44 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
> 
> This patch adds missing supported Tx multi-segs offloading.
> 
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
Tested-by: Lei Yao<lei.a.yao@intel.com>
This patch can fix the vhost-sample launch issue, the virtio VM2VM Iperf
test can pass  with this patch on ixgbe NIC. 
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 7511e18..aed3f5a 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev
> *dev)
>  		DEV_TX_OFFLOAD_UDP_CKSUM   |
>  		DEV_TX_OFFLOAD_TCP_CKSUM   |
>  		DEV_TX_OFFLOAD_SCTP_CKSUM  |
> -		DEV_TX_OFFLOAD_TCP_TSO;
> +		DEV_TX_OFFLOAD_TCP_TSO     |
> +		DEV_TX_OFFLOAD_MULTI_SEGS;
> 
>  	if (hw->mac.type == ixgbe_mac_82599EB ||
>  	    hw->mac.type == ixgbe_mac_X540)
> --
> 2.7.5
Ananyev, Konstantin April 17, 2018, 9:42 a.m. UTC | #2 
> -----Original Message-----
> From: Dai, Wei
> Sent: Tuesday, April 17, 2018 8:44 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
> 
> This patch adds missing supported Tx multi-segs offloading.
> 
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 7511e18..aed3f5a 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev *dev)
>  		DEV_TX_OFFLOAD_UDP_CKSUM   |
>  		DEV_TX_OFFLOAD_TCP_CKSUM   |
>  		DEV_TX_OFFLOAD_SCTP_CKSUM  |
> -		DEV_TX_OFFLOAD_TCP_TSO;
> +		DEV_TX_OFFLOAD_TCP_TSO     |
> +		DEV_TX_OFFLOAD_MULTI_SEGS;
> 
>  	if (hw->mac.type == ixgbe_mac_82599EB ||
>  	    hw->mac.type == ixgbe_mac_X540)
> --
> 2.7.5

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Zhang, Helin April 17, 2018, 4:16 p.m. UTC | #3 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Tuesday, April 17, 2018 5:43 PM
> To: Dai, Wei; Lu, Wenzhuo; Yao, Lei A
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs
> offloading
> 
> 
> 
> > -----Original Message-----
> > From: Dai, Wei
> > Sent: Tuesday, April 17, 2018 8:44 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs
> > offloading
> >
> > This patch adds missing supported Tx multi-segs offloading.
> >
> > Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> > b/drivers/net/ixgbe/ixgbe_rxtx.c index 7511e18..aed3f5a 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev
> *dev)
> >  		DEV_TX_OFFLOAD_UDP_CKSUM   |
> >  		DEV_TX_OFFLOAD_TCP_CKSUM   |
> >  		DEV_TX_OFFLOAD_SCTP_CKSUM  |
> > -		DEV_TX_OFFLOAD_TCP_TSO;
> > +		DEV_TX_OFFLOAD_TCP_TSO     |
> > +		DEV_TX_OFFLOAD_MULTI_SEGS;
> >
> >  	if (hw->mac.type == ixgbe_mac_82599EB ||
> >  	    hw->mac.type == ixgbe_mac_X540)
> > --
> > 2.7.5
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 7511e18..aed3f5a 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2429,7 +2429,8 @@  ixgbe_get_tx_port_offloads(struct rte_eth_dev *dev)
 		DEV_TX_OFFLOAD_UDP_CKSUM   |
 		DEV_TX_OFFLOAD_TCP_CKSUM   |
 		DEV_TX_OFFLOAD_SCTP_CKSUM  |
-		DEV_TX_OFFLOAD_TCP_TSO;
+		DEV_TX_OFFLOAD_TCP_TSO     |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	if (hw->mac.type == ixgbe_mac_82599EB ||
 	    hw->mac.type == ixgbe_mac_X540)