From patchwork Tue Apr 10 13:32:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 37782 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53DA21B992; Tue, 10 Apr 2018 15:32:32 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00046.outbound.protection.outlook.com [40.107.0.46]) by dpdk.org (Postfix) with ESMTP id A3A6C1B96F; Tue, 10 Apr 2018 15:32:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qjGqVAZSsONewh0UNur4/c/GdOcQuB2etXlqNS/Qz/w=; b=A8q9l/wc2JXIFakNeKC5e8cD6efpRiki0o0jRB4HlVzsQDeayrRiwvjym530JyHP+G8xFOuUgD9Q/2gAVHAlEr2NoGxSBt9rrC36J0vSUhV8k5LU8s2KfWenAD5ldgqn4M3B8wX1XxX416K0Sd9TaeFnCy9v/orK1fJm3ZBZbT0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2668.eurprd05.prod.outlook.com (2603:10a6:3:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 13:32:27 +0000 From: Matan Azrad To: dev@dpdk.org Cc: Ferruh Yigit , stable@dpdk.org Date: Tue, 10 Apr 2018 13:32:06 +0000 Message-Id: <1523367128-32317-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.9.5 In-Reply-To: <1523367128-32317-1-git-send-email-matan@mellanox.com> References: <1523367128-32317-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR02CA0072.eurprd02.prod.outlook.com (2603:10a6:802:14::43) To HE1PR0501MB2668.eurprd05.prod.outlook.com (2603:10a6:3:cb::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 821ddc48-cdea-49fb-9435-08d59ee78124 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2668; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 3:nzgYau+G552qpzIo29mBtEXpT9cn074JrTL11gbHAfeNVmBdh6lJKX//xBpNYQ+xQ5pxFCi4ujQv5QTSC2pR4cf2cExj1T+g3nSJDtllXpxCHfPm24QHgpKmA3gocVPp/7FvbvHpAc10Erjl02xEKQGhmFl+1N+PrZiWj4htTo6GAyzCp+P3VU9KVmPhYU9pvA/pEtdc2oVt4adqwcldzJefGds1E6eXUGjMKCF16Ww4Zlk5QLMTgiAEPyNZCiEK; 25:38CgB2Pm5uGvIIb/Z6f05WDZEq99lmGT5329LfENu0LFrKAfHXEtlqD+UwU0SZ9vKqBSRrOpYrwd9498l7HmbPTVlGqemeCSjSxcg/NEUwCcY2kAWOsE8d3549P3XBLyS1gqrs2IODJ65JyN50uusfSZ6LOM3XqyCflMatUP1Mi8MBqCmNyPoPnocNXDp8ze98fQUU/I0eJpvM1U4ApPr8hhl7RQukPpjNoKeUIx47RMlKRuXcOx7Th4p2sZE/+EHR6fDy+W20YyA3+kOnJJ3Zy5yxSsVSG1Ara9SCzFxZ3y+oVPz1xaZ73drw14PihhbuZ2DNDhYS75Y2TRYUkbeg==; 31:EA1v0qrBCljEVlyuEH4IbMjifM2rU+oo7AVsBST3+mBpV3eMRZ4//vbfuzucK4+l88piJVGQJp49Le3vu8VKpHrxKhQp1MUAhr9iBFsxgi2VNbQvg9uEKuI9+RKeNe+nyzw87CCpoXngeNmHWfTASkptdZbFeTVXUly9GkXLodl1jx67JBRhihrZ/NzyvDZ5o5zymj2S94zLQYmfGVFrhw+E9OFYLPVoBFWwBcdgNpY= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2668: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 20:J94RGw/wRk9lOG+n9uNj8pY/QLbD86J+UJ4aJ8s3eC/vPbdB55x8EvvSkNeO9lhEVVMKE5+aaUNiDU6XXqNkvge4JQ/ycBisvk/vQkCFYk/L5Hs3vDnLhQZAre9uETL9wJ9m18A2asg1GAmiA8zb7YbqVc7ETlhWF2mDcB2/Zv8RgKqp/Fe4V6syLEDgAJqfHmSr9SUaL5z8cv/jkb8WMLjqOZuH/lfAkWzp/Bieh5ACfl/r6unjCQqGA9uv153c24rk9gKfl/pkbnix14ueYBtCjtGqY+2ktiYXBUOjeQlijOO/l9JtcTSt8s3SNdIa0DNqhupaErxAQhFkB3rO6PB171i0tZ5xH/rg+8cgMhOHPyqVa05y7hjHxVBoVnsx0m/1J+rPHU3Ar1wfNneaoNO88ZwwrZnZTktdcbiYTDdcggj9eWLz8fckazX4yp7QmY6zAHYk0YMXs4OYEhFYmpU8GfD9beSa7sMqVG7gKGYmbWFBwmVCeorwcKNAA5tk; 4:Df7Oz2wVKsckxbrmtS/JNjk4qYKh+FCbq3rYFaG1TjzCi+bDo/06aMCy1FwzGx1NjiOU1VIqO1+4g1oqmX+7bREtu/87aszHjXon1xYusQJPCURQOik1D/CRvYw/+Ex5lYkwlLwvTJur1MJmXqqQOJ0QkfFsTfQghC7HGurtiBq5d39VXD628Z/VKDdcZpunun6Yy3sD7NZWaBiT8MFzqxaDead1R+rKwMdB93A7iWVgjUH+mDDr6XM7lJO0xPRRVFwmassPGcQJR6sGX6Y7xg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0501MB2668; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2668; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(39380400002)(189003)(199004)(33026002)(316002)(47776003)(3846002)(5660300001)(5890100001)(6116002)(4326008)(48376002)(16586007)(21086003)(50466002)(105586002)(2351001)(86362001)(486006)(476003)(25786009)(2361001)(106356001)(55016002)(7696005)(68736007)(11346002)(52116002)(6916009)(2616005)(446003)(956004)(50226002)(16526019)(186003)(7736002)(2906002)(76176011)(51416003)(97736004)(6666003)(36756003)(26005)(478600001)(53936002)(59450400001)(81166006)(305945005)(8676002)(81156014)(386003)(66066001)(8936002)(69596002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2668; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2668; 23:K7fVa+0A2V1kxzzeTcT+OncGoELNBVSsh6V7TsK?= nDwOy6H6l6tVouJnlCS0Mv+m3lhBjJF/ZdqEOqCV6HFXcuKY25KlXFlj/Ny8ukwWlXOF/Qgw9e4YJiLCwWbVhWmmnglTHQ24kdX6/XAzxsGGVCcmsrY7epkPOUDYzY1GekcbN4k4OniBZWkCwNbzFh0mRar7Mm1zzMLkAq4APX83mE47Blxfy2ZYp7kLS4bEjFprO0r7/KDiHrFzJTb86xHhjhaLPYh1ypakZbuGgWitxmOOmoKF4lDcrB2hnk2KvBs/wIObBjmKmFM1qKTV/he2O2K880UG/D/KisZoQU8GbqI3qS68beDzrtxefoCdo2db9gMfphG6pBzJyWwdlJpwiyQ9CQo/9VhUBAFvZDPvnmQAMIElLy6uaKw9l8GAJzshP/szNgx7mKsg6OV39T2RgTrqeTH58YmMHFqdvk4yBjXt1FTiEvK8wxmMEbQmCGQU6Hvbwx9zjUa8+1bsJpAQViPAvFKBTez5/NkhoOzALohAJkVvzEGE1vupZaslQNDbIlauXcDvU+z3i75uN4dIIg/CRzEiSTvFYEDOQSSISi3huui2baRLalIsJ+MnkJW3VvpyxdatSOyUMKT0ZTMn18l+CtkpSo7+ROmnjp4yojyINIgEJLDJ1EoqS+1v87lDvkYclooNKjR9JFGVRhAhzHTkC9zz3QzI0/adTPVi6q1C4Vkhgk8agSpGsMWLcJYVqezo3zgiyyWsszPt4hMxcgyCXYaDTe7Dvm88pMWdEs9UmbHwuv2llinoK/kVThspX/11Y2TB6pHzPZmH3zB7TymajVmTR1fd0os/GOyjHoLf6x0wxHssTW+S4dwLQN2s+VdwHeBCjU+rjj+HV5VXEZ9yfH737kpfJZWcti9nnOG+vEW5SaKCDjtl37S2O4ryBVMeTn0tJiwJBgWx6VCJf7SB4JpfX59dwHbfkrHz3QUf1t2gBqtsghjuD4CN+l+ZngLKX4TomlgAzX1rCcUkZuaiTHu/4koti83v/vzQVOHgdNMgukxvq8qzAJ8X2X+MzWZSf6TbEMWgMnE6eEEsxg1UgmlRTSdzmXNigk9kPcqSaKrqBBFxe34P/qCznMR0X/a/XmfmkyOvpZ/8ywQ49jnMYv4qkj5QrFGm5HePa0SVlvwRTfZxtLUwRuumKsCEGilIlit7yvkeYYCllqIEbeWZObXSuQTP6ZnzlkkQfr+eG3m16JGTn4rQMEMxGV305B4m2FTeVl2D/bATbcOlRd8pP1+kBb7oRJm/tvGiakdwpqUXVEcgJb1cg8fFM6uA= X-Microsoft-Antispam-Message-Info: aHiQ3HYtnziu1S3BqjPReVvx08ZHn9UXbBa5p/FKHGF9J7cFOadaAWSBgMkpVmVVO1Foi0Edd7hrZvMja3ECpAWecyzY/lTohqgyLugBzIEbALY2XxJ72cYObr4OyEXATf7Lufr8rHtJhQaaMBXSinR3x9PmkAWebfOIzfXLBcLLU+q9lavEA2x77Pyrl8xQ X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 6:UJ/w4/v3DeicDy+3W71PIkFdxsMniU7MvOBJKqWu/LsXLIMrdf7z6y3H+FtEyaY4S/CL6rfrx+iX9A44SzFnkhv5WaJmew6HnP3A6pqlJqY9h9UxjGdg0DRWhvArzHCRxFWa6KUXhmdUc1ezBVEZqpN3EJfHgTtCn5baagnZuyFPrECftYYzZkzicuA2DVCy3SV0S06E8Xs0dg8RSS68xYjT+OO0O8Cbuabw+ehWe4/xM5BVPoXtNBrmJWQCEC3hR45FhLjcn2e0S6yBggLKW0bBiaWc5HPWzwS6UYRPJQTygBsCwB/jKEGTx4dkrELeQ0dFRSqRdaZ8w4wM4NkuQSaMCkHD6ItQiVSCiZWyJDieR7VKZqBV5hj+n+E/wgmZ1gf/M2M9LzUV14Wejb13URqaam4s7Bl/t48jz7CMonz+gbLUqcohu5Ry4OYubrj46Qny17PVFBLLN3UkZdcrRQ==; 5:nkyWzUA698s9uiOJk4gDi5M2AFzoSbRVbtz/PXJDyP3lKMSsmDQ3ZFZUEdijUAiBsUUYT4cX/dJJqQkSqsLFp3/qciVUfKmK7IkbIUK4x0teyIUnE1yoQ05LV0qAx0ZtF5guEciemV9OilzCHsz3tRVRrs2FbQPg4jViYsorLIg=; 24:PaSYwyXAFPgSiO0DtWJE6P5sC8N3Gd0eR248aSLChrLgtkC+4RSxyroxadclYkaVCTi4M65Dy8KiGjI5kC7y2Sv4ZyHng50B7mqBcU+KRYM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 7:Eo4nyBS+PO4yB7xgSoGPx5CdflSYd7ySdeHsQCGmgNlq9UfEi4HFywKKWZVAdlaQf706+6mALdSDkpDkYwS6Dy4u1Ror1cVpb86jqulBL6dQcDSRv7edxVK1IPntIFpk1F9CltDQNGQuiQrjoVT0pbamcGwm9nO9Tde8nG/33lhS6WCw9M2ElxBWPOS8aAwJI6X5BCyTxMyfjFczr6E9yhbFg3RSd0qYkA6DsQdZdmSuUgxTBbiM3Ns77M+RiEvT X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 13:32:27.6741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 821ddc48-cdea-49fb-9435-08d59ee78124 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2668 Subject: [dpdk-dev] [PATCH 1/3] net/vdev_netvsc: remove specified devices IP check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If the netvsc driver starts in blacklist mode, it does not automatically probe IP associated netvsc devices. Therefore, the only way to probe them is to specify them by the EAL command line, using the "force" parameter to skip the IP check in the driver. From now on, the user does not need to add the "force" parameter if he specifies an IP associated netvsc device by the EAL command line, and the responsibility of the IP check is now in the user's hands. However, in the absence of any specification, the driver still skips IP associated netvsc devices. Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 10 +++++++--- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/vdev_netvsc.rst b/doc/guides/nics/vdev_netvsc.rst index 55d130a..a2d49f4 100644 --- a/doc/guides/nics/vdev_netvsc.rst +++ b/doc/guides/nics/vdev_netvsc.rst @@ -89,12 +89,16 @@ The following device parameters are supported: - ``force`` [int] If nonzero, forces the use of specified interfaces even if not detected as - NetVSC or detected as routed NETVSC. + NetVSC. - ``ignore`` [int] If nonzero, ignores the driver runnig (actually used to disable the auto-detection in Hyper-V VM). -Not specifying either ``iface`` or ``mac`` makes this driver attach itself to -all unrouted NetVSC interfaces found on the system. +.. note:: + + Not specifying either ``iface`` or ``mac`` makes this driver attach itself to + all unrouted NetVSC interfaces found on the system. + Specifying the device makes this driver attach itself to the device + regardless the device routes. diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index db0080a..d2c41a5 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -569,7 +569,7 @@ static LIST_HEAD(, vdev_netvsc_ctx) vdev_netvsc_ctx_list = /* Routed NetVSC should not be probed. */ if (vdev_netvsc_has_route(iface, AF_INET) || vdev_netvsc_has_route(iface, AF_INET6)) { - if (!specified || !force) + if (!specified) return 0; DRV_LOG(WARNING, "probably using routed NetVSC interface \"%s\"" " (index %u)", iface->if_name, iface->if_index);