From patchwork Thu Mar 29 20:13:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduard Serra X-Patchwork-Id: 36733 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 436D45F22; Thu, 29 Mar 2018 22:13:17 +0200 (CEST) Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 6B69B4C99 for ; Thu, 29 Mar 2018 22:13:16 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id 201so3766729pgg.3 for ; Thu, 29 Mar 2018 13:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=eMS/f1SMzbqnj3sdLSVk8s1WbBVi5bBRq34ntzOpj7Q=; b=mOLD8hJykPfMaw+H4qHw199TNtNhCws7AWhZHw5kfjJ/HmDinLsE0XMjb5nufejemy 2CRTZzRe9OMYxj3Ypt0rM/D3hto2Vhaiw+PWYY73Ytz3+6cdH/M7jBgB00ZpLW5rrV46 3loVVZq3RRMj+iPssJwe/g1gY6MKxqYMutdI4TvzbqP/Ep4Q3qBAxD7hhDFtL3YVESNZ A7EPbebb1TLhH+Nkk5iLnzJQGI1zB7hZzBTVdI+bYyh60zCUNlGDtlXeSouK1VIIK2Od 0DrgBEGZDzUgUHekAvwGnSnzd8Ih5bz/SfGfDzsSq4QC/bUS0FvOdVsnTgbVt1HrOhsb hzIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=eMS/f1SMzbqnj3sdLSVk8s1WbBVi5bBRq34ntzOpj7Q=; b=bovsXRf72nHNdoZQNF9cAH+z/mRusdQxHmN4FvFP1rw8zav4IOhukC4lvYlfw74vrU WAcsXzhEBYb+kptWGysyrJ/k1ABG2wlSsd9rphG4/mT1fCVDxK2TLDU7Q4Zsw9nGwcaR r3Z6LPckQcEcrJPxK74vAApDl08/xRGtU64RBHRWjkHKY+Ud64su3WuZvQTJPUGnv1mE CdB97Xysoo7y2S/zNnGEy0v7Uz/TiO3PDpbY4Ev8hFjeLX/ShNYB7x/IlXKs6aGJzBWQ GVknuvnFfePmwEWPnj59/f7012s3I5tJ/XCeRybcBvEXRqRPcxvYxTH1MZDicwB0UdBR k1Jw== X-Gm-Message-State: AElRT7GZMPfCECMr+RlHp6i10ouIbV2MWbH3W3FA0XYqqzNODWW8kJDf kIc2jim7QvQfZ0P1nS6GmaE= X-Google-Smtp-Source: AIpwx4/dPj0U8+D9T/cs0zx6xycvzg+Y79yIawCpofcd32CWAxjoCXpBKR8BaBr5RuLm1RCoeN1YUQ== X-Received: by 10.98.157.6 with SMTP id i6mr7557927pfd.52.1522354395472; Thu, 29 Mar 2018 13:13:15 -0700 (PDT) Received: from dev.localdomain ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id g9sm11893845pgo.22.2018.03.29.13.13.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Mar 2018 13:13:14 -0700 (PDT) From: eduser25@gmail.com To: qi.z.zhang@intel.com Cc: dev@dpdk.org, Eduard Serra Date: Thu, 29 Mar 2018 13:13:27 -0700 Message-Id: <1522354407-90598-1-git-send-email-eduser25@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Eduard Serra Scatter RX (scattered_rx) flag is currently not being resetted when new configuration is suplied to reconfigure a port, rendering the rx callback logic to always fall through the scatter branch. Signed-off-by: Eduard Serra --- drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ drivers/net/i40e/i40e_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 750d849..a072154 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -1750,6 +1750,8 @@ i40evf_rxq_init(struct rte_eth_dev *dev, struct i40e_rx_queue *rxq) if (dev_data->dev_conf.rxmode.enable_scatter || (rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) { dev_data->scattered_rx = 1; + } else { + dev_data->scattered_rx = 0; } return 0; diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 1217e5a..8698747 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2561,6 +2561,8 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq) /* Check if scattered RX needs to be used. */ if ((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) { dev_data->scattered_rx = 1; + } else { + dev_data->scattered_rx = 0; } /* Init the RX tail regieter. */