From patchwork Thu Mar 22 12:39:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 36426 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 740285F34; Thu, 22 Mar 2018 13:40:12 +0100 (CET) Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 17AF25F2D for ; Thu, 22 Mar 2018 13:40:11 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id g12so3191808pgs.0 for ; Thu, 22 Mar 2018 05:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OqokjQX2pWCwVjkoz8/iJuByw8ED6uWJxs83Hc4s/y4=; b=inqeVTwfu0kdlD/Q/iG/AcpcaKGB/q4ZGrIG0vGeH69aHzofHy8JVPR87kvoC/nlIx dzfDVw8dk9fhS8jHzj03UstdqDTXKD2xLohzVt0bDg0qR140cbqrzWG4GqiQYceBmKG+ 4DHWXFTvOxTgO5VvrAzUQaHJyWygCNgz7NPTk2U/8cQcdd0TDwvWzxXHev0LAxizBdT/ c2Q8aP++MhCuHYVbIIbgtnjTKH3D6Xx++Cflp1lAzFg6J++9qIO1POKYpnDXzl6cQslS gto+VswnQNCxJHRRyDTAstqIJ5CNeWLOzpx2GLs0mUNYOOarvvSaPB4DTW4WPocvQvN5 m88Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OqokjQX2pWCwVjkoz8/iJuByw8ED6uWJxs83Hc4s/y4=; b=SsUkHit5IctFcVlWZdnlhpfj0x1dEeAnS+smLvrVA/KTV9jnpHbu6r6K21Lc9nntqn m6GcRzZt2fkGR0qiSELTN0EEYa8jKpzj9nQRQSA8K/vr5uyV4ibQ+xAjGA61YzVhm0/I rn3nu330J5Pl/LlV7ABz56zQEaW8NIKyw64MzVCYbYbmFZNWFQLYpa1Rdn+1lkKoMmpw av9Z2SZdeEhwr+L1b5PW5Jxt7VAc3qhoMEJGFOk7FtRZSGYzi2efIhoWM5XDvvzVQY88 mWna4ottgVP8gyQ3B7C3GSPAg7QzEeviIQDo+y4WOXag/WcNbdibigm5xVPUIrRyKlNq Kbag== X-Gm-Message-State: AElRT7EzanZ62UkCpZ91XZw8qrmuwkmFXXDoOxht3z4LJ42xlcBmf3s2 1gmszrv+ho+ZtXy2kzXcbGE= X-Google-Smtp-Source: AG47ELuI4u99RkwaQtM9746rVaKtLy7GAfdR0eO8999higZ9hBFzbIaPY50/5pYphHM9xT9r/7LpuQ== X-Received: by 10.98.97.1 with SMTP id v1mr20567232pfb.119.1521722410322; Thu, 22 Mar 2018 05:40:10 -0700 (PDT) Received: from local.opencloud.tech.localdomain ([13.94.31.177]) by smtp.gmail.com with ESMTPSA id w27sm11554680pge.20.2018.03.22.05.40.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Mar 2018 05:40:09 -0700 (PDT) From: xiangxia.m.yue@gmail.com To: jianfeng.tan@intel.com Cc: dev@dpdk.org, Tonghao Zhang Date: Thu, 22 Mar 2018 05:39:57 -0700 Message-Id: <1521722398-93353-1-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH 1/2] vhost: make sure vhost fdset-thread created successfully X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Tonghao Zhang When first call the 'rte_vhost_driver_start', the fdset_event_dispatch thread should be created successfully. Because the vhost uses it to poll socket events for vhost server or clients. Without it, for example, vhost will not get the connection event. This patch returns err code directly when created not successful. Signed-off-by: Tonghao Zhang Reviewed-by: Jianfeng Tan --- lib/librte_vhost/socket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 83befdc..8ca01df 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -831,9 +831,11 @@ struct vhost_device_ops const * if (fdset_tid == 0) { int ret = pthread_create(&fdset_tid, NULL, fdset_event_dispatch, &vhost_user.fdset); - if (ret != 0) + if (ret != 0) { RTE_LOG(ERR, VHOST_CONFIG, "failed to create fdset handling thread"); + return ret; + } } if (vsocket->is_server)