diff mbox

[dpdk-dev] crypto/mrvl: add missing library dependencies

Message ID 1521625478-6368-1-git-send-email-tdu@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation fail Compilation issues

Commit Message

Tomasz Duszynski March 21, 2018, 9:44 a.m. UTC 
  While trying to do a shared build one will get linkage error
since a couple of library dependencies are missing from a makefile.

At some point there was a batch update of all PMDs but mrvl crypto was
missed back then.

Necessary makefile changes were introduced in
commit cbc12b0a96f5 ("mk: do not generate LDLIBS from directory dependencies")

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/crypto/mrvl/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

De Lara Guarch, Pablo March 26, 2018, 8:57 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> Sent: Wednesday, March 21, 2018 9:45 AM
> To: dev@dpdk.org
> Cc: dima@marvell.com; nsamsono@marvell.com; jck@semihalf.com;
> jianbo.liu@arm.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; stable@dpdk.org; Tomasz Duszynski
> <tdu@semihalf.com>
> Subject: [dpdk-dev] [PATCH] crypto/mrvl: add missing library dependencies
> 
> While trying to do a shared build one will get linkage error since a couple of
> library dependencies are missing from a makefile.
> 
> At some point there was a batch update of all PMDs but mrvl crypto was
> missed back then.
> 
> Necessary makefile changes were introduced in commit cbc12b0a96f5
> ("mk: do not generate LDLIBS from directory dependencies")
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/drivers/crypto/mrvl/Makefile b/drivers/crypto/mrvl/Makefile
index bc5c227..9870f02 100644
--- a/drivers/crypto/mrvl/Makefile
+++ b/drivers/crypto/mrvl/Makefile
@@ -58,6 +58,8 @@  EXPORT_MAP := rte_pmd_mrvl_version.map
 
 # external library dependencies
 LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
+LDLIBS += -lrte_cryptodev
 LDLIBS += -lrte_bus_vdev
 
 # library source files