diff mbox

[dpdk-dev,01/13] net/bonding: fix library version in meson build

Message ID 1521545187-27096-2-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andrew Rybchenko March 20, 2018, 11:26 a.m. UTC 
  Fixes: a0ace286a60b ("net/bonding: build with meson")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/bonding/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Bruce Richardson March 23, 2018, 9:31 p.m. UTC | #1 
On Tue, Mar 20, 2018 at 11:26:15AM +0000, Andrew Rybchenko wrote:
> Fixes: a0ace286a60b ("net/bonding: build with meson")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon March 27, 2018, 4:43 p.m. UTC | #2 
> --- a/drivers/net/bonding/meson.build
> +++ b/drivers/net/bonding/meson.build
> @@ -2,6 +2,7 @@
>  # Copyright(c) 2017 Intel Corporation
>  
>  name = 'bond' #, james bond :-)

Ah ah ah, I had missed this important comment!

Unfortunately I think the real name is "bonding".
Does it mean the full name should be james bonding?
Bruce Richardson March 27, 2018, 8:26 p.m. UTC | #3 
On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote:
> > --- a/drivers/net/bonding/meson.build
> > +++ b/drivers/net/bonding/meson.build
> > @@ -2,6 +2,7 @@
> >  # Copyright(c) 2017 Intel Corporation
> >  
> >  name = 'bond' #, james bond :-)
> 
> Ah ah ah, I had missed this important comment!
> 
> Unfortunately I think the real name is "bonding".
> Does it mean the full name should be james bonding?
> 
Nope, the name of the driver when built is "bond", according to the old
build system anyway. The name of the directory is "bonding", hence the
override here.

ls x86_64-native-linuxapp-gcc/lib/librte_pmd_bond*
x86_64-native-linuxapp-gcc/lib/librte_pmd_bond.a

Ideally, I'd like to be able to get rid of that "name" parameter entirely,
if we can just rename all directories to match the driver names exactly. In
this case, if we do want the driver to be called librte_pmd_bonding.a/.so,
then we just remove this override.

/Bruce
diff mbox

Patch

diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build
index b90abc6..44d5fd8 100644
--- a/drivers/net/bonding/meson.build
+++ b/drivers/net/bonding/meson.build
@@ -2,6 +2,7 @@ 
 # Copyright(c) 2017 Intel Corporation
 
 name = 'bond' #, james bond :-)
+version = 2
 sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c',
 	'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')