From patchwork Tue Jan 30 03:32:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingjing Wu X-Patchwork-Id: 34678 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD45F1B371; Tue, 30 Jan 2018 04:41:51 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4FF741B370 for ; Tue, 30 Jan 2018 04:41:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 19:41:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,433,1511856000"; d="scan'208";a="14458499" Received: from dpdk2.sh.intel.com ([10.67.118.195]) by orsmga006.jf.intel.com with ESMTP; 29 Jan 2018 19:41:48 -0800 From: Jingjing Wu To: wenzhuo.lu@intel.com Cc: jingjing.wu@intel.com, dev@dpdk.org Date: Tue, 30 Jan 2018 11:32:58 +0800 Message-Id: <1517283178-36925-1-git-send-email-jingjing.wu@intel.com> X-Mailer: git-send-email 2.4.11 Subject: [dpdk-dev] [PATCH v2] net/avf: fix uninitialized variables issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes the coverity UNINIT issue. Coverity issue: 257016, 257036 Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Reported-by: John McNamara Signed-off-by: Jingjing Wu --- v2 change: - add fix for 257016 drivers/net/avf/avf_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index cf7bbb2..7eacb8f 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -191,7 +191,7 @@ avf_init_rss(struct avf_adapter *adapter) vf->vf_res->rss_key_size)); /* init RSS LUT table */ - for (i = 0; i < vf->vf_res->rss_lut_size; i++, j++) { + for (i = 0, j = 0; i < vf->vf_res->rss_lut_size; i++, j++) { if (j >= nb_q) j = 0; vf->rss_lut[i] = j; @@ -760,10 +760,10 @@ avf_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask) err = avf_enable_vlan_strip(adapter); else err = avf_disable_vlan_strip(adapter); - } - if (err) - return -EIO; + if (err) + return -EIO; + } return 0; }