diff mbox

[dpdk-dev] net/mrvl: update MUSDK library build instructions

Message ID 1516953745-26545-1-git-send-email-tdu@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Tomasz Duszynski Jan. 26, 2018, 8:02 a.m. UTC
By default both static and shared libraries should be created while
building MUSDK library. It turns out that this will not happen if
host parameter is not explicitly passed to the configure script.

Specifying host makes sure configure will detect support for shared
libraries.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 doc/guides/nics/mrvl.rst | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit Jan. 26, 2018, 4:37 p.m. UTC | #1
On 1/26/2018 8:02 AM, Tomasz Duszynski wrote:
> By default both static and shared libraries should be created while
> building MUSDK library. It turns out that this will not happen if
> host parameter is not explicitly passed to the configure script.
> 
> Specifying host makes sure configure will detect support for shared
> libraries.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>  doc/guides/nics/mrvl.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
> index 892097d..77b2d66 100644
> --- a/doc/guides/nics/mrvl.rst
> +++ b/doc/guides/nics/mrvl.rst
> @@ -221,14 +221,13 @@ Usage example
>  Building DPDK
>  -------------
>  
> -Driver needs precompiled MUSDK library during compilation. Please consult
> -``doc/musdk_get_started.txt`` for the detailed build instructions.
> +Driver needs precompiled MUSDK library during compilation.
>  
>  .. code-block:: console
>  
>     export CROSS_COMPILE=<toolchain>/bin/aarch64-linux-gnu-
>     ./bootstrap
> -   ./configure --enable-bpool-dma=64
> +   ./configure --host=aarch64-linux-gnu --enable-bpool-dma=64

One more flag is required for crypto PMD, right? Is it documented somewhere?

>     make install
>  
>  MUSDK will be installed to `usr/local` under current directory.
>
Tomasz Duszynski Jan. 26, 2018, 4:46 p.m. UTC | #2
On Fri, Jan 26, 2018 at 04:37:27PM +0000, Ferruh Yigit wrote:
> On 1/26/2018 8:02 AM, Tomasz Duszynski wrote:
> > By default both static and shared libraries should be created while
> > building MUSDK library. It turns out that this will not happen if
> > host parameter is not explicitly passed to the configure script.
> >
> > Specifying host makes sure configure will detect support for shared
> > libraries.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  doc/guides/nics/mrvl.rst | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
> > index 892097d..77b2d66 100644
> > --- a/doc/guides/nics/mrvl.rst
> > +++ b/doc/guides/nics/mrvl.rst
> > @@ -221,14 +221,13 @@ Usage example
> >  Building DPDK
> >  -------------
> >
> > -Driver needs precompiled MUSDK library during compilation. Please consult
> > -``doc/musdk_get_started.txt`` for the detailed build instructions.
> > +Driver needs precompiled MUSDK library during compilation.
> >
> >  .. code-block:: console
> >
> >     export CROSS_COMPILE=<toolchain>/bin/aarch64-linux-gnu-
> >     ./bootstrap
> > -   ./configure --enable-bpool-dma=64
> > +   ./configure --host=aarch64-linux-gnu --enable-bpool-dma=64
>
> One more flag is required for crypto PMD, right? Is it documented somewhere?

You mean --enable-sam? It's mentioned in the crypto PMD docs.

>
> >     make install
> >
> >  MUSDK will be installed to `usr/local` under current directory.
> >
>

--
- Tomasz Duszyński
Ferruh Yigit Jan. 26, 2018, 5:18 p.m. UTC | #3
On 1/26/2018 4:46 PM, Tomasz Duszynski wrote:
> On Fri, Jan 26, 2018 at 04:37:27PM +0000, Ferruh Yigit wrote:
>> On 1/26/2018 8:02 AM, Tomasz Duszynski wrote:
>>> By default both static and shared libraries should be created while
>>> building MUSDK library. It turns out that this will not happen if
>>> host parameter is not explicitly passed to the configure script.
>>>
>>> Specifying host makes sure configure will detect support for shared
>>> libraries.
>>>
>>> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>>> ---
>>>  doc/guides/nics/mrvl.rst | 5 ++---
>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
>>> index 892097d..77b2d66 100644
>>> --- a/doc/guides/nics/mrvl.rst
>>> +++ b/doc/guides/nics/mrvl.rst
>>> @@ -221,14 +221,13 @@ Usage example
>>>  Building DPDK
>>>  -------------
>>>
>>> -Driver needs precompiled MUSDK library during compilation. Please consult
>>> -``doc/musdk_get_started.txt`` for the detailed build instructions.
>>> +Driver needs precompiled MUSDK library during compilation.
>>>
>>>  .. code-block:: console
>>>
>>>     export CROSS_COMPILE=<toolchain>/bin/aarch64-linux-gnu-
>>>     ./bootstrap
>>> -   ./configure --enable-bpool-dma=64
>>> +   ./configure --host=aarch64-linux-gnu --enable-bpool-dma=64
>>
>> One more flag is required for crypto PMD, right? Is it documented somewhere?
> 
> You mean --enable-sam? It's mentioned in the crypto PMD docs.

Yes I was mentioning it, and confirmed that it is documented, thanks.

> 
>>
>>>     make install
>>>
>>>  MUSDK will be installed to `usr/local` under current directory.
>>>
>>
> 
> --
> - Tomasz Duszyński
>
Ferruh Yigit Jan. 26, 2018, 6:14 p.m. UTC | #4
On 1/26/2018 8:02 AM, Tomasz Duszynski wrote:

   doc: update MUSDK library build instructions

> By default both static and shared libraries should be created while
> building MUSDK library. It turns out that this will not happen if
> host parameter is not explicitly passed to the configure script.
> 
> Specifying host makes sure configure will detect support for shared
> libraries.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst
index 892097d..77b2d66 100644
--- a/doc/guides/nics/mrvl.rst
+++ b/doc/guides/nics/mrvl.rst
@@ -221,14 +221,13 @@  Usage example
 Building DPDK
 -------------
 
-Driver needs precompiled MUSDK library during compilation. Please consult
-``doc/musdk_get_started.txt`` for the detailed build instructions.
+Driver needs precompiled MUSDK library during compilation.
 
 .. code-block:: console
 
    export CROSS_COMPILE=<toolchain>/bin/aarch64-linux-gnu-
    ./bootstrap
-   ./configure --enable-bpool-dma=64
+   ./configure --host=aarch64-linux-gnu --enable-bpool-dma=64
    make install
 
 MUSDK will be installed to `usr/local` under current directory.