From patchwork Tue Jan 23 08:46:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 34302 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D40F71B026; Tue, 23 Jan 2018 09:46:37 +0100 (CET) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 7C5EE25B3 for ; Tue, 23 Jan 2018 09:46:33 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id r78so239553wme.0 for ; Tue, 23 Jan 2018 00:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HvDBR/t3uVLOcsvDxhWIgCl3SbJMStwX1XYA8xsOlII=; b=HduiCOAkAAm4zS0axFRhPWBZnGh8GfTeiJbXiBaifjJqNx/ox6TN6NecsncAg8cMca 11jm3boHPkDAnY7U9oVR1s11zNAFQ78fOI+Z0DwzltK7ojZeW7VfaWQZGQm4Gc8YBBxw c30zzZhviZwW9VJYPBjkVULDOELrDDBBXooSY6c9MmIC3PuNAbjPyKj+pDI3sNMel2Ea GELJBvDzVDaj0Wp4rGRB6qtbDoMmk25jnA7gZtpHFD1qriGFiNP98toN/wxqVasF8Fuh 2z4ZVGNyvzSasLFbimDx44m5zCzllfgly4DJ+VBcW2Yb39RGB99ji25RH+i7WXnSC1iR sQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HvDBR/t3uVLOcsvDxhWIgCl3SbJMStwX1XYA8xsOlII=; b=R6j8K5OAhB8AO7QgTltOx2dHNi5GNi0h+3NG97AwU21fP7hHt3hs0pXU/NrWrG2epX QdT5l1N7XQi9Yfk97t9/Oy1gcyUBkQpJkL7UAz/LYQDWRN3u6PRY5w89kfkWXjEMPUFQ I+74HYsj0DMt9dH6oLwNbo+ZXMlm+nPd9qR1/C6eKO6WX4u+X7jP/EP7CG81Ud7h2AlV FcGEbhmfvgKKn7pXEVgamM8rQHBjbaLY/6CrS+deuE0QsPUeOIG1rsT1hcnOqFP8QW9l OIeQl6pT9AOev5TJBUOk0+3IYT8A7wOO3BVReUSTcpUiETlWP+HrEZm8Yrluuc8vmAev qI9Q== X-Gm-Message-State: AKwxytc+KrnGVbwmnrkw7CxDeV0eWgVTAMO3QhOnpPDCrSzyIeVTNHs1 HbmwpZzAZCxE9JoLoSTaJsp0WOtZpXE= X-Google-Smtp-Source: AH8x2272dkE+Ol07x7KnJkXMXqUKXHx0Usw6+Cj5ybfnLazOufocAR/lTEWg95ZRhUThupom/6EfAg== X-Received: by 10.80.137.50 with SMTP id e47mr18212993ede.3.1516697193044; Tue, 23 Jan 2018 00:46:33 -0800 (PST) Received: from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id k11sm13054104eda.22.2018.01.23.00.46.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Jan 2018 00:46:32 -0800 (PST) From: Tomasz Duszynski To: dev@dpdk.org Cc: mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@arm.com, jck@semihalf.com, Tomasz Duszynski Date: Tue, 23 Jan 2018 09:46:15 +0100 Message-Id: <1516697175-31235-3-git-send-email-tdu@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516697175-31235-1-git-send-email-tdu@semihalf.com> References: <1516622670-21120-1-git-send-email-tdu@semihalf.com> <1516697175-31235-1-git-send-email-tdu@semihalf.com> Subject: [dpdk-dev] [PATCH v2 2/2] net/mrvl: switch to the new Tx offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since the old Tx offload API was depracated update the driver to use the latest one. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 52 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c index c313bda..af8f215 100644 --- a/drivers/net/mrvl/mrvl_ethdev.c +++ b/drivers/net/mrvl/mrvl_ethdev.c @@ -100,6 +100,10 @@ DEV_RX_OFFLOAD_CRC_STRIP | \ DEV_RX_OFFLOAD_CHECKSUM) +/** Port Tx offloads capabilities */ +#define MRVL_TX_OFFLOADS (DEV_TX_OFFLOAD_IPV4_CKSUM | \ + DEV_TX_OFFLOAD_UDP_CKSUM | \ + DEV_TX_OFFLOAD_TCP_CKSUM) static const char * const valid_args[] = { MRVL_IFACE_NAME_ARG, @@ -1134,9 +1138,8 @@ mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unused, info->rx_offload_capa = MRVL_RX_OFFLOADS; info->rx_queue_offload_capa = MRVL_RX_OFFLOADS; - info->tx_offload_capa = DEV_TX_OFFLOAD_IPV4_CKSUM | - DEV_TX_OFFLOAD_UDP_CKSUM | - DEV_TX_OFFLOAD_TCP_CKSUM; + info->tx_offload_capa = MRVL_TX_OFFLOADS; + info->tx_queue_offload_capa = MRVL_TX_OFFLOADS; info->flow_type_rss_offloads = ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP | @@ -1477,6 +1480,42 @@ mrvl_rx_queue_release(void *rxq) } /** + * Check whether requested tx queue offloads match port offloads. + * + * @param + * dev Pointer to the device. + * @param + * requested Bitmap of the requested offloads. + * + * @return + * 1 if requested offloads are okay, 0 otherwise. + */ +static int +mrvl_tx_queue_offloads_okay(struct rte_eth_dev *dev, uint64_t requested) +{ + uint64_t mandatory = dev->data->dev_conf.txmode.offloads; + uint64_t supported = MRVL_TX_OFFLOADS; + uint64_t unsupported = requested & ~supported; + uint64_t missing = mandatory & ~requested; + + if (unsupported) { + RTE_LOG(ERR, PMD, "Some Rx offloads are not supported. " + "Requested 0x%" PRIx64 " supported 0x%" PRIx64 ".\n", + requested, supported); + return 0; + } + + if (missing) { + RTE_LOG(ERR, PMD, "Some Rx offloads are missing. " + "Requested 0x%" PRIx64 " missing 0x%" PRIx64 ".\n", + requested, missing); + return 0; + } + + return 1; +} + +/** * DPDK callback to configure the transmit queue. * * @param dev @@ -1488,7 +1527,7 @@ mrvl_rx_queue_release(void *rxq) * @param socket * NUMA socket on which memory must be allocated. * @param conf - * Thresholds parameters (unused). + * Thresholds parameters. * * @return * 0 on success, negative error value otherwise. @@ -1496,11 +1535,14 @@ mrvl_rx_queue_release(void *rxq) static int mrvl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, unsigned int socket, - const struct rte_eth_txconf *conf __rte_unused) + const struct rte_eth_txconf *conf) { struct mrvl_priv *priv = dev->data->dev_private; struct mrvl_txq *txq; + if (!mrvl_tx_queue_offloads_okay(dev, conf->offloads)) + return -ENOTSUP; + if (dev->data->tx_queues[idx]) { rte_free(dev->data->tx_queues[idx]); dev->data->tx_queues[idx] = NULL;