diff mbox

[dpdk-dev] event/opdl: fix build using C99 mode

Message ID 1516528119-720-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Andrew Rybchenko Jan. 21, 2018, 9:48 a.m. UTC 
  RHEL 7.4 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)

‘for’ loop initial declarations are only allowed in C99 mode

Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
Other option is to move declarations outside of for loop.
I just want it to be fixed.

 drivers/event/opdl/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Jan. 21, 2018, 10:52 a.m. UTC | #1 
21/01/2018 10:48, Andrew Rybchenko:
> RHEL 7.4 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
> 
> ‘for’ loop initial declarations are only allowed in C99 mode
> 
> Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Other option is to move declarations outside of for loop.
> I just want it to be fixed.

Yes, other option would be to comply with DPDK coding style.
Let's fix it with std=C99, waiting for coding style fix.

Applied, thanks
diff mbox

Patch

diff --git a/drivers/event/opdl/Makefile b/drivers/event/opdl/Makefile
index 747ae5b..a8aff2c 100644
--- a/drivers/event/opdl/Makefile
+++ b/drivers/event/opdl/Makefile
@@ -7,6 +7,8 @@  include $(RTE_SDK)/mk/rte.vars.mk
 LIB = librte_pmd_opdl_event.a
 
 # build flags
+CFLAGS += -std=c99
+CFLAGS += -D_XOPEN_SOURCE=600
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 # for older GCC versions, allow us to initialize an event using