From patchwork Thu Dec 14 06:36:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 32252 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 423731B024; Thu, 14 Dec 2017 07:36:26 +0100 (CET) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0080.outbound.protection.outlook.com [104.47.37.80]) by dpdk.org (Postfix) with ESMTP id 224871B018; Thu, 14 Dec 2017 07:36:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E1velwMDZpyCrsek5JMX2bctr5vswbWUHYc0WyF+rg0=; b=F2DBr1aMwEoTs576w6XxyqUFT/AyjpTWIsrBqYTEuNncxMcGVnNSrr9aAiCh3UNWVAX7odD10fFV+uaHy53iStKA3kEbYcu+iY+AmywTtxZLQ9PwZOaY3RoBKrNza3q8HAOA+TG8IpS+GepA56hpOR0UUtBbioYr31objmF5TPA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3830.namprd07.prod.outlook.com (2603:10b6:4:7f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Thu, 14 Dec 2017 06:36:21 +0000 From: Rasesh Mody To: ferruh.yigit@intel.com Cc: Harish Patil , dev@dpdk.org, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Wed, 13 Dec 2017 22:36:02 -0800 Message-Id: <1513233363-4241-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com> References: <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BN6PR11CA0021.namprd11.prod.outlook.com (2603:10b6:405:2::31) To DM5PR0701MB3830.namprd07.prod.outlook.com (2603:10b6:4:7f::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52faf6d1-58f7-4640-f107-08d542bcfdbc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307); SRVR:DM5PR0701MB3830; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3830; 3:cOvczc+xbk6iI6yqKqJbo9PIQ5LiralKH6+0/5BH2uEWRGRY5Yb2p03emtSPFowylAwtubmOEZMDk3n8+JMOr+2uzoaqD50BFZF3idwx//1uDL1It6valQlZHnByL2/nbb0j2EexlIjhmlAI+7SsQCG0GUTzP5vAEaadKIhW23kW34s0JT8cTSx+oK0LASjDwj6kot9lIMRoXQDsn5bOvHafHW8rqTzl7MHT43fXHXS9ZdVNk+C5n603UUkrr9Xo; 25:lcR5j7zk5kJhET96tiyeGvGr4aFs3oa3qMbah9vwanTFAYEHUX3bQosdg110/hn2AlplXuummrjdPZ8zMqVHRyIGKhOJhTOIWwUMp0fkzsH6ElQy/KEriXA7+/x8SaE3IaZdf+pgWi6Nl4tKdxnQkOKSHa76tnl69LCSvP0rk3oEKdenaFA6wYh03BAPqKkOqTceiOiYzuMnhKEfKT89qqfM9Gm9crj7qrAJvafFNKBbgmztvidEfSQCcB00kLr1Dl6suOIpJAKsg0JIgNhK0LmPI76YDoa12/EXdTlgJFCDdvW86KVHxS23w6IcCJTEr710ycxqROUMW+S84b+hXA==; 31:KbPV5cYMwnMiWaD+GqWw2QwG/As2FVYYFxXc1nyJ/QzylQJM4UBMiHSfrlEbv1/otN9cHRyDH8c9XprafMCt6MW0kL5VwDSn2qrjWXD6fcuUAj5K2QB+DNGHkLAEQN4TlbammVo6yTJp7qcadWDxIF6qGrBUTlWl1MqmkSbMT/3g8jlRG0ITQ7poe8QJGyJoIKHyaQHP4ohoRoIUHmq9FbmbnwZkjEqhsZjgsV+hu7Q= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3830: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3830; 20:L9Bdg1gO/mCZLYWUUT6h0XsNIWxrPYHr0RW96JM3eQad8AXcyiziDMkK3ODyKyiFVsjHLhHzUZL8JJ8YqwmTe33Vbv31QxlIAtZv0VUyKBTRdKsVGNeL2V8C0ggQ8xGCD80pCExqPTnakll/ZhjDWmld7HBaINPN8nDXbXtloh/o8nqGEBi+o9kMxU4bLsUJJmu9agMvWKTJeLjrrMyuuVxS8L9uQ1BuBlPZGAy9ZnI1EgkMtYdksc23jhiD0rXS3131d7fdCrN5pvct0Y4ztTV+rY9JfIsP2VhlAg7SmrEYbSxbRpFZ0+glPcre+1aXWmhx9gMokVNnoKOKa9EOcrzvayY+lQFhnlrEnqXuttFSS4qABbWrqq0IVsUEa+oyDNXVXH2vpv2P1i3TWUW73723v7257ZXtQRAYn4negE8QB4mtKGw1Bls0s5BnvMCJrh5rCUav/1ZEUB2c/6ThEh+Tqyd0GfmKlY3yeY70/QLdJhmZVu5egxfLsywoPl3g; 4:kXDb4dwukaRA25acQZumqCcxZs7whSMEd/Bx8XXb/yERxpcMBV1yzlOrpuRX6ll0lGmEYVLB1zYaJcfU3xGgKFstSKQsEEfKofnRZb5TUs7LDFjEYrJepizLwVw7C5Hgpqmjzl3rwrczcYWoE1/P2+op7OV2Ix7G5HGhhZPnUZ/4QnSzQ8wCziJWG75msHceXzKNEV00i9ZXbQBXQBNHIjIiFb8942Afvpwvtwa4APj3tWwpBhW1TFaBkWg+CRBy5/TsAxx72Ok1glDEoo0s9A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231023)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR0701MB3830; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR0701MB3830; X-Forefront-PRVS: 05214FD68E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39860400002)(396003)(189003)(199004)(53936002)(76176011)(2906002)(50466002)(68736007)(51416003)(36756003)(55016002)(47776003)(478600001)(16526018)(7696005)(105586002)(2351001)(4326008)(305945005)(7736002)(66066001)(6666003)(8676002)(6116002)(81166006)(25786009)(3846002)(316002)(6916009)(72206003)(16586007)(2950100002)(5660300001)(4720700003)(52116002)(69596002)(21086003)(97736004)(86362001)(106356001)(50226002)(81156014)(8936002)(48376002)(386003)(2361001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3830; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3830; 23:1acNLB9ujza9Z8ZLABahiQamFrz3YVEuCRy8hCR?= kSFMFYodHMVFyltEKo4vxAIi1oTc4rggu7ADUB2y92jE07I9RUd4tBIqZFPwelPsVhiKISJkE/ObwPshRqwc+lL+guf/82KWsIKhXsFuHvEreIbRrbFq7Xr2yyPtLN+86H2SnuBfcDUwYeBQTeeKG1SDUGuEZQ/xCYBp5SNPSSEyzd96IPOCFi1k3/zi0XJBZT7kXgimVXdQeXwrSw8thH7AEMZmJrl0Xwh2Mlq0n05xjKSmyQs18YZxKgVVHpIcJJ6jlYhf7bj1heLWGzP67iMaXK4HrAmJa7euINdTH1zgVgvokJ0z9zvf/bkSC7ksxjliKXu79CINayjvJv+TJHM7DlANBSCylDTjR8VVCJR3OHLbR1sTzf+pB2T6A/HoCbhmqj1JWfaZXjt1DzFAo9P/i3VKPja2bPblLny6iKfUe1++CyVy6Qf2aSkWXvclKmQdBMbFJEq+od1qAYb93s8CXzDpP0lKuSFlWreVpYL8hrN22aeJ+FVVQtEqWoJPJRy2/EMpCfqvkhIVSHZbUWKK8Zc3xjZmJYTV9vRaKH4D9lD3bD9M/i7ozQJXeNS9BW1hHBqIsr/9cp5hi4rbc+uWKKLa1b67FINBiSLvQf/HD6WTjYVEvj1MX/qTWwpzvn2NO4RXhPF+Yb0/yggGAX4XZ936wHipZdGpaPcPg+7mvRxGkqtN4oUkFrwCRcp4qTvPKK3vYp2aKOxTorrmeJw3EjrJANlmTfr83yF9YwFj8G3FdCGFp0K2SKlQadDCMRYyZECsidGFTvVs4tWJ0m6Z9X+FyOukD6o5KWZBBp9T9tG9/0d0nh1q6D7IefQcN8jB0+ncYOHD7fjqENTVdeAmweomoMOoFuuqeObmovdEJVCLsrPapLkSfPfXsZ2AHP1KUTwsMiIo+H4rv146yV4wa2Y7dLFnGoVYQQt+zDYrzonpYmVmixkhQMVNcP4gsrulALJOjbCNkiXGTVk9HXCF9wJjfoqejN+7CMn4vHeN1QmVcMlya1rWKBI9LaZH488HDnpCYxhs3nqbAiuBulBf2EZbiLm0VMDsA55UzE/FfnapPOl5C+Mleqiy7/UlUvoMF2rf2YmEBhLclsQfBDZgxJhcIHKOA76npNK0OskAYiA== X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3830; 6:5RKE9HE9z9AuUH9JcJqWgqIFTAvqaxM/UfAY/JSc3C1cFHaNLPmpAUbjYB9a/sLWFFMCiCvspXQoNmZm4xbJQO5mM81SMDRGPP9KaFhjXm93645coltjcpJT+ASvsZz+6yUn52nzsnVxbwoX7Sw2lM+mO5U156MVwn64k8hBlkMzwS+w97+Zl6bHQhShh72ltoAg6e9gUytpTHGvGCz4eEBU8lDp8zpa8OYrsZrE5H5G0Ip0+LAXFB5iOw/F0WkeRjq4Pnl8mG/FZrWBqEk3jOpB0+G1C40+jLG5l7+zpR+G2F7DQuIrEN68fsc9j5hgXQhH5cxSzLIEIRDLtn97JHDrL74HTzFZEoCE0JgJJgg=; 5:T9FmZZNfZ7sdT231ixLtvdEv6FUEv9iHo/2GkizXq6F5itxkLry9IHpICxIc7T6raaJ5C6ITyMeo2c+s2TeOOhLPyu7WbvuZOcek6lHYBxy3xMW0CH72sk0Hk1pGIUfdun05mbtrIGM/Tq2Q9Nej9cISiPO60qA65Npro3xzbnA=; 24:gCvfsX70w8QHajbfFGFUcaRAjvP2G/bAcReZXZIWgjeT9oz6agVecONCD40pviTlZMVQFe84ZuRC5HCVg92QAgAsp6qKvRXzAY0zC4rA9qg=; 7:wSiGb1Uikt8v5WkbyUOXZDOmhzDsbqWDjanwvFg6Q4lmyl673yoE6/DjOeH7JQvnG34Rhxr97i6u/gou4PRCSzBcwNYB+hd5Z6mcqWF5gH6Fk4QEOKCK+MVh39NoepYwY0cXopE+GX4TTtdV6uOYr+cysqw04CCbkF7jOp052Zix4dr0J6h0mae8iGGscGskvTjwpzMCPKw/abCpaxfvaa0FxWlj9DhNcxJLeEd/DAqehYB4sVEzLjmImleU/Zc9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2017 06:36:21.3439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52faf6d1-58f7-4640-f107-08d542bcfdbc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3830 Subject: [dpdk-dev] [PATCH v2 2/3] net/qede: fix to reject config with no Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Harish Patil The qede firmware expects minimum one RX queue to be created, otherwise it results in firmware exception. So a check is added to prevent that. Fixes: ec94dbc57362 ("qede: add base driver") Cc: stable@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index cc473d6..0128cec 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1233,6 +1233,14 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) } } + /* We need to have min 1 RX queue.There is no min check in + * rte_eth_dev_configure(), so we are checking it here. + */ + if (eth_dev->data->nb_rx_queues == 0) { + DP_ERR(edev, "Minimum one RX queue is required\n"); + return -EINVAL; + } + /* Sanity checks and throw warnings */ if (rxmode->enable_scatter) eth_dev->data->scattered_rx = 1;