From patchwork Wed Dec 13 19:32:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chunmei Liu X-Patchwork-Id: 32243 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFC4C7D06; Wed, 13 Dec 2017 20:32:37 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DD0D62030 for ; Wed, 13 Dec 2017 20:32:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2017 11:32:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,398,1508828400"; d="scan'208";a="1349243" Received: from otccldstore01.sc.intel.com ([172.25.110.24]) by fmsmga002.fm.intel.com with ESMTP; 13 Dec 2017 11:32:34 -0800 From: chunmei Liu To: dev@dpdk.org Cc: chunmei Date: Wed, 13 Dec 2017 11:32:32 -0800 Message-Id: <1513193552-159561-1-git-send-email-chunmei.liu@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: chunmei ceph async messenger has some run time error with this dpdk library, 1) need init mb->next= null when allocate a buffer other wise rte_mbuf_sanity_check will report error. 2) when check the size, can't calculate mbuf_data_room_size because async messenger dpdk will allocate this part later not at create mempool. Signed-off-by: chunmei Liu --- drivers/net/ixgbe/ixgbe_rxtx.c | 1 + lib/librte_mbuf/rte_mbuf.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 1e07895..30fdbc1 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -1589,6 +1589,7 @@ ixgbe_rx_alloc_bufs(struct ixgbe_rx_queue *rxq, bool reset_mbuf) } rte_mbuf_refcnt_set(mb, 1); + mb->next = NULL; mb->data_off = RTE_PKTMBUF_HEADROOM; /* populate the descriptors */ diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index 0e3e36a..c01da19 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/librte_mbuf/rte_mbuf.c @@ -102,7 +102,6 @@ rte_pktmbuf_pool_init(struct rte_mempool *mp, void *opaque_arg) } RTE_ASSERT(mp->elt_size >= sizeof(struct rte_mbuf) + - user_mbp_priv->mbuf_data_room_size + user_mbp_priv->mbuf_priv_size); mbp_priv = rte_mempool_get_priv(mp); @@ -233,6 +232,8 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header) } if (nb_segs != 0) rte_panic("bad nb_segs\n"); + if (m_seg != NULL) + rte_panic("bad m_seg\n"); } /* dump a mbuf on console */