From patchwork Tue Dec 5 09:39:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 31931 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADC1C1AEEB; Tue, 5 Dec 2017 10:39:45 +0100 (CET) Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id 6916E199B0 for ; Tue, 5 Dec 2017 10:39:42 +0100 (CET) Received: by mail-lf0-f65.google.com with SMTP id 94so22448628lfy.10 for ; Tue, 05 Dec 2017 01:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H5NmEhSt9PegF2Cn0MhKInwGUIIjlofDU0aDMFsRtUY=; b=GOfKr7lhZz4QAiENP1pRni+KELXArZzlno9VPS+fc+qskB2MwVIJ/0PEuY3E0e1Ky1 8fdzxPEiySiefJ7CbcI2gD5Dhoyhz7cR03cxm2K1RxmV535F1gru8Dk77mpSBVvNY/hI y7WCLPWKPhLPTHpizaW1L0tuWWTzAmQmORwUIQq4btidGmzjktLRrV0S6O7Hu6kFTLsg eIdQ2ESbM7cn6mM9bH0U+jR07VG0K5f+ovLNKWuaqIacENP7Zsnx08JNzs3uig9N+eXk TTFvpio6RufNVSNfJyVaDmJNjpnlMMmCCCx5pYMwzf4FodsOOSx9R4gDvrVWEfRVfL7c +wBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H5NmEhSt9PegF2Cn0MhKInwGUIIjlofDU0aDMFsRtUY=; b=cCPukF74MKwoF1XcaLASmgoYyw8ZAayKwdlKGPOLlnUIXC6wS/PzRJybsDLybyRtWk FQxy0KdFAPWFzYr/ka5KuiZokL/qvZr+E8mYtCNLTl8snllGJRkxW5jDF/B8nX0KSMSB FwrkY+IYF8R9C/2Z1Xaz62/HYeBfI8EyhtNyx+wEG/sP+V6+1Tw6vpUaAOSe9xHgj87i ZNPseHPKQfRSHHPahK8KBdX/9h+xg3U/Q8AGLJJ93jKtnJbmsNWd1Yp5fHnVvWi7yI1n Mx1C+XzxCJKUWr5AC+1rydXgOA1yM1uK1vKxslQoi9ERpBMzBdsdk1p1UQkusXCMp/V5 KN2w== X-Gm-Message-State: AJaThX5vxF2HgwJVRlivfUAQp9gkSrSZkMvIab9u5E2wX9vfAJRSVgXD pGM/UohiuIG+ZtqbpF0vyeXQvIbMWz0= X-Google-Smtp-Source: AGs4zMbPuR0qVdb0a18oHc5PGxT9k8y896fOMAtR7Ab1OgkrTJ22zakB1/tQPuCfHYNHoOVySQdVCg== X-Received: by 10.46.5.80 with SMTP id 77mr10901347ljf.186.1512466781644; Tue, 05 Dec 2017 01:39:41 -0800 (PST) Received: from tdu.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id p5sm3334975ljc.7.2017.12.05.01.39.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Dec 2017 01:39:40 -0800 (PST) From: Tomasz Duszynski To: dev@dpdk.org Cc: mw@semihalf.com, jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com, jianbo.liu@arm.com, Tomasz Duszynski Date: Tue, 5 Dec 2017 10:39:20 +0100 Message-Id: <1512466762-1982-6-git-send-email-tdu@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512466762-1982-1-git-send-email-tdu@semihalf.com> References: <1512141592-16695-1-git-send-email-tdu@semihalf.com> <1512466762-1982-1-git-send-email-tdu@semihalf.com> Subject: [dpdk-dev] [PATCH v3 5/7] net/mrvl: add extra error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add extra error logs in a few places. Signed-off-by: Tomasz Duszynski Acked-by: Jianbo Liu --- drivers/net/mrvl/mrvl_ethdev.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c index 40f2ead..127ce44 100644 --- a/drivers/net/mrvl/mrvl_ethdev.c +++ b/drivers/net/mrvl/mrvl_ethdev.c @@ -426,8 +426,10 @@ mrvl_dev_start(struct rte_eth_dev *dev) priv->bpool_min_size = priv->nb_rx_queues * MRVL_BURST_SIZE * 2; ret = pp2_ppio_init(&priv->ppio_params, &priv->ppio); - if (ret) + if (ret) { + RTE_LOG(ERR, PMD, "Failed to init ppio\n"); return ret; + } /* * In case there are some some stale uc/mc mac addresses flush them @@ -462,17 +464,20 @@ mrvl_dev_start(struct rte_eth_dev *dev) if (mrvl_qos_cfg) { ret = mrvl_start_qos_mapping(priv); if (ret) { - pp2_ppio_deinit(priv->ppio); - return ret; + RTE_LOG(ERR, PMD, "Failed to setup QoS mapping\n"); + goto out; } } ret = mrvl_dev_set_link_up(dev); - if (ret) + if (ret) { + RTE_LOG(ERR, PMD, "Failed to set link up\n"); goto out; + } return 0; out: + RTE_LOG(ERR, PMD, "Failed to start device\n"); pp2_ppio_deinit(priv->ppio); return ret; }