diff mbox

[dpdk-dev,6/7] devtools/test-build: add MRVL NET PMD to test-build

Message ID 1512141592-16695-7-git-send-email-tdu@semihalf.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tomasz Duszynski Dec. 1, 2017, 3:19 p.m. UTC 
  Add MRVL NET PMD to test build tool.

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 devtools/test-build.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit Dec. 5, 2017, 12:48 a.m. UTC | #1 
On 12/1/2017 7:19 AM, Tomasz Duszynski wrote:
> Add MRVL NET PMD to test build tool.
> 
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>  devtools/test-build.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 092d3a7..78609c9 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -197,6 +197,7 @@ config () # <directory> <target> <options>
>  		sed -ri           's,(SCHED_.*=)n,\1y,' $1/.config
>  		test -z "$LIBMUSDK_PATH" || \
>  		sed -ri    's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> +		sed -ri           's,(MRVL_PMD=)n,\1y,' $1/.config

Won't MRVL_PMD also require LIBMUSDK_PATH?
For this case check doesn't cover it and will be enabled always.

>  		build_config_hook $1 $2 $3
>  
>  		# Explicit enabler/disabler (uppercase)
>
Tomasz Duszynski Dec. 5, 2017, 8:38 a.m. UTC | #2 
On Mon, Dec 04, 2017 at 04:48:51PM -0800, Ferruh Yigit wrote:
> On 12/1/2017 7:19 AM, Tomasz Duszynski wrote:
> > Add MRVL NET PMD to test build tool.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  devtools/test-build.sh | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> > index 092d3a7..78609c9 100755
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -197,6 +197,7 @@ config () # <directory> <target> <options>
> >  		sed -ri           's,(SCHED_.*=)n,\1y,' $1/.config
> >  		test -z "$LIBMUSDK_PATH" || \
> >  		sed -ri    's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> > +		sed -ri           's,(MRVL_PMD=)n,\1y,' $1/.config
>
> Won't MRVL_PMD also require LIBMUSDK_PATH?
> For this case check doesn't cover it and will be enabled always.
>

Good catch. Will be fixed in v3.

> >  		build_config_hook $1 $2 $3
> >
> >  		# Explicit enabler/disabler (uppercase)
> >
>

--
- Tomasz Duszyński
diff mbox

Patch

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 092d3a7..78609c9 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -197,6 +197,7 @@  config () # <directory> <target> <options>
 		sed -ri           's,(SCHED_.*=)n,\1y,' $1/.config
 		test -z "$LIBMUSDK_PATH" || \
 		sed -ri    's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
+		sed -ri           's,(MRVL_PMD=)n,\1y,' $1/.config
 		build_config_hook $1 $2 $3
 
 		# Explicit enabler/disabler (uppercase)