From patchwork Tue Nov 28 12:19:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 31722 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A75B17CEF; Tue, 28 Nov 2017 13:20:22 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0059.outbound.protection.outlook.com [104.47.1.59]) by dpdk.org (Postfix) with ESMTP id 63FCD3259 for ; Tue, 28 Nov 2017 13:20:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pZTIbpxsi5Cwy6Q03AO0LSbss6/PxoVbAxzloxohYg8=; b=t8DKvuCkIZ2rN3llHy2eCfYZmf6QEfa00BtHgbiKpMfC5BqTOV59aaNpNVPhVa0TZV3p37wnEr23c0yxs+Z87gFnWkfV/Rj7Ujf3hbJRQOb279kkLgUsFVCi8u5ao6H5ZKm1fMApMm85p9O1Smpe29+2lenHBH815D2WWQt0Hgs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3653.eurprd05.prod.outlook.com (2603:10a6:209:9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 12:20:09 +0000 From: Matan Azrad To: Adrien Mazarguil Cc: dev@dpdk.org Date: Tue, 28 Nov 2017 12:19:30 +0000 Message-Id: <1511871570-16826-9-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1511871570-16826-1-git-send-email-matan@mellanox.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6P193CA0012.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::22) To AM6PR0502MB3653.eurprd05.prod.outlook.com (2603:10a6:209:9::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dc67a5df-94c9-41a2-3eaa-08d5365a5e8b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603199); SRVR:AM6PR0502MB3653; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3653; 3:0uJ2badxgP2yRs+U2dYgWwBE68wrS3AkY1D7A5YjKMkbqfXZAe8z3Ct5nr2yp6+1pksjYruYdElUOzC+StRreZmJ1ePxF5RCeaKkBFA05qn6WcOBfAAfyrEo3kfMihzVT+Y0gM8sQT7fSYrzpASbdoLfVKg0V1w8FJoubByLvUbo5PheC6KKn/bdq6jyN8Ns8Ugp0ykvSERbJJhDHhpq7d8ahOPw8V3nHcWGOd5eZvhcYn2nmIA6VF9crwjQJKun; 25:6E/7GrcqipFtNC6tmHAgDol4j1E/khjVKHJXzMmDPGV9kVq10zCFGXcoPUQ3IcbZitp6KO2fU9PJi/7nxYxlf6Rc/x9oFCLWWeQugPEhKbvMIW9Eo5LpRk/0O74a/Zt/PFY4Ii4zDJrtKn19fjczcNJ0rfPIXo6WZcp/tZ6gGuCd67YpgkUQOnAQBVeSKA8FvjSfyGhfZlQ7qhz+XfzHKbceKqaz7/oEC71KWr7ENxaJ3LSdCLj67aqydvqTAWuT4OeMrBiWvyPLCKVdhdcGprmB+LMC4IVXhiTOiSdTPQiJcXotqmKdEz4St2BTDDSqPQ2Kj6R7uP1a3QKLh9YRAf89EcN/dEzEpFmSDJ4aYO4=; 31:Oem+1D6CBRg0nnwoYPy+F8iB0taDOmDIcxko2NnYdF0SxKkGs4AnO+pbeCKqs1GHRecYXmH1wswo0ZbhtMljZh1NyC5td1Kp9WuLzWnK/WPf2m0oi8BNM3+hws8LAM5l/tGjqoeuPZF4t8Yh6UUCLUDz+ttK+wlvcPYpIPF7DBQD0FbgVIfNr6stoaeONRDW+82X0bx41+Y4+tdF3ieQpecLWi8EK3z6UMM5O1vmEA0= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3653: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3653; 20:vKRH+hPqAoaJLnFjFDOaOGUl/Xy0Ea+mUICYeAwmcCGnAhasW7M1pPewGCh8NTRxOF965yS1oyvlg21Yxu/zPrP/I8mV5sGpQN9+1+009xgyLLDhWJ1BvTOoqqpKdh4gE6duQx4jUs4/PnvZgi9gBrTwWcu9/pGF3H/qnn9HvYUEnckfg+CDdZ3VEUq75HLmqLOnBvhvSLnNY5TSEOfWIQvozHxaIpVs35oAaucOLwiZfsXhWp4s5AnnY9oFxCFwr1XRxiaNkQf2Whc0kXE1ioFwQBVSDuP6Kc0J1jXvvxEj46APw4gDLnARtjX26zYgH3mrs8CA3tsMD1R4JtP0Y891JQ67NYYT7uIjutEb7SEVzd7g+6UxsUiNFlROYDhTFs0clW5DTdeBq8OwLVMK52o8wIOUEgWhFZZ0zk+llQupSI+VZTRmRp41soNI+OrOAm1jARyejOu2CZFMv7LiMHvVFsYxFfEbSe5tQkL9Nuf8BuM4lHnfXmWH6LRqGajo; 4:LJDkuz46L4KUr1NhdwY16CmKSxqlZK5NNKCU2Rl2W+PpeX4XyFvOS+UN2G3HfOA5urty4Vcw9YbqLH7ss0rnRUGKBRm21vW8HXTX4bg/m8Hf8rxoHQ/fRn1MV+piVOnPbpsYpymwdBi2CbEllnvfmRgQWRnLpGiRnIqhjos2R8QexiewpfHVPG77eHSCAdBs8U/cjCPh3IciPKq0hxjyVz10yWzGAwxsUAY5YjPn8TTYuTgo7lbJcD4+Am+0BDjJJ7AnfnxSDjvaMVXuBnxPG1brnlKtcpKZl261Wa69l5x9eiQ1DnpWbDM+U9oIax2d7F7njJmEBKPqFdAaxgwVBeIPok2MJATnlnNkJC89BKQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(131327999870524)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM6PR0502MB3653; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3653; X-Forefront-PRVS: 0505147DDB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(366004)(39860400002)(199003)(189002)(101416001)(76176999)(86362001)(50986999)(4720700003)(8676002)(81166006)(81156014)(6666003)(36756003)(55016002)(33646002)(106356001)(105586002)(2950100002)(6916009)(4326008)(478600001)(189998001)(48376002)(25786009)(68736007)(2906002)(50466002)(52116002)(21086003)(53936002)(8936002)(47776003)(33026002)(66066001)(5660300001)(50226002)(6116002)(3846002)(316002)(7736002)(305945005)(97736004)(51416003)(69596002)(7696005)(16586007)(16526018); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3653; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3653; 23:BrJpqngNU31666DQZ7Z7eYrok7ghHR/dIP6DJ1+?= hnu7sN3HPNymPs47EHJi4vJRVuvPqajs3yxSoQJa3ZU3TXwURU7Yg+dq91hPTNeG/ZUnf4/W1W6kn929Ze/gUi34qRtT/iilDN1dH9Kusfl7Un6UM9RSUu/o6mI1+h23BLtLzs/BEIjIojIjhaXMqm18CL4w1eoRIIJZL4dSPbV4nEYBHJyZ1StvLpsIulxw832kp7lfyOkylKbqgEl4WdKQ/C1MLQgNI+dBesCyZo9gFM5JTBOIykqq9pkgtncJGEKNSvGguBrVhsi2yxk3uRxwKXiJQ/+P24urFTDFCT25t+5xQhOwbE0uY9b3oZZFZ4bkBu4EfE3FX8dhTmKkMI0eoZRkXCiJ39qmI/0X8nRyV8msbUc/xvt0QTdCam9eMONCicRgwg9xRBKa5ktZAZmzA2MhUsdsZulwR1zcWLjHWn0t0KL/aK5I99HmeXL9Y5TaVKJ5EHgAlAyHmJCuGEt/cpNmzOzbc+3/0h46QBCZXNm+SCQwN4o6vuI6ME3HR6gp4sswOhpIPsrNaDwFepPpvaK15Lp5SNJd3W1OVZ+Ugnq7kEbM87Ctb4NHF/SeVlLepvXuRUa3WmFrlTjtO7DcxvJ4Zzqll6Vro6oqMDClYxR/1xg+n4287II3Z4x7BIGheXf2jsbxQH2o7eKqPnNIrt5fDWLAO/0hpwmAWgB0sHNbz/hAdA3K0B/HHkdrPF6JnA8rM6QUbSsNxIwJJyIILtGUxgM/JpHNigQaQC8k2Cww+ApQt39IlRPOgUB1Zw3xQu2OwJ2vKnHZUhQmZCUfB5fhDc2HC9QzCh3McDd5QbimI1Hjqr3Awja8cWM7Sks81Yg+USBVkdlMWt0gZi+w6UsmfxcZV6llXfdYOGN8YUnNQJ2rCEJsDSUxDOmNKeJ6QUj/rB7+K0h5Lk5Pwrro8vpjbrpImWunDIdXwjSlbUxjcSrcFqseu71ZedZaHXBUzzanQfmRyyxFJjt9JyJkQ8jgCffOy/cv0U08A1er+tHOpHSzKgOtbpAwsbMiVA3SBClesNiA1JDomq1eKkvTMGq7QLf3RZ+6RYm0ctFKBoP33nZis0JSDQSP4OuS97NtHsborDuBeesL3D4dvytZVMt95DkXcRVe4aVOoCDC79vxiksdLxqBiQkKElcBkPLw= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3653; 6:EUuCjZ1Miijc/55lliywJWCSQFQTJMvmyQnb6u5cfozYSUjmwbY2r2/wXHI4HgfDVWnYBBWjkBmBZf567Yje81G8Kn/TqVtSe8R4/d+cdLSfzTfAotY/4eK/smaOzlbuSHyUCPBkAz+gN5oIlsDn4LMdZQfGB0NrSv1fEEsmLYd1CnoCvVqDoix3FgM5CwogdKbvUXlkzEFURwAx/5vD1Uf12M5zKaiTONCYydXrI7jV4AoR3j3MmsgR/Xa0s1DLx5ouJu9n2J5RYaPJe2786FnqvNqP7WtnpzsvNHIfOpAT8TSPbmzQ9dXsn5YAPZdt/NC/JAUTZIfpW05OA3k2+Hw0n+V5taMpZ3qahtGc+6Y=; 5:sDPkTtZ1j7pvFuQYxFXWoGvDlDygiDajPRLp1LpOhWd2SszQP0RfAg8TDNQFnEzWs7BFLs4jCliY4h7B484YYfh8vXnSkexnxAlz2AMzvTvlR/yXK+dGrF61R5P66U4wiogjN5gflOrD9maoQwr2/P0GyBPFCzZPsOssZvGwPeU=; 24:X/KBdOEbychF/P09Y+VQNuWa7IZBSRmyemh3ZJ81GMKzBntzAZoOjkDSqudQhm5OryFBKi/xgscvmN9V2q1Gx2GC/V9V3sUXZfOJTPWTnLE=; 7:CC+cfwmPPElLK8P7dqK8PyfXsDFyP5F0tW6oLUjdsg5gCdvN1QFMz0DLefXw2d5QYNzuY/R3PXNWZMKnAtLcN/YMhlzdoFob0V3dk06GnT+W9PRqrrhEDp4yxsBJhqWnfdbBzxdcwmcaCQtWbDiNWNKi2omP5Ops0vGtaGfq8OMyVa2hFxREz1eAlTvvECwgYuA3iiBTWkHzqNCEaP5lcEocodvEA80ln2hIp3BwPbkLssPesBFGea4yrSeKlxND SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 12:20:09.8308 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc67a5df-94c9-41a2-3eaa-08d5365a5e8b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3653 Subject: [dpdk-dev] [PATCH 8/8] net/mlx4: remove Tx completion elements counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This counter saved the descriptor elements which are waiting to be completted and was used to know if completion function should be called. This completion check can be done by other elements management variables and we can prevent this counter management. Remove this counter and replace the completion check easily by other elements management variables. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 8 +++----- drivers/net/mlx4/mlx4_rxtx.h | 1 - drivers/net/mlx4/mlx4_txq.c | 1 - 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index b5aaf4c..b7b8489 100644 --- a/drivers/net/mlx4/mlx4_rxtx.c +++ b/drivers/net/mlx4/mlx4_rxtx.c @@ -363,7 +363,6 @@ struct pv { /* Update CQ consumer index. */ cq->cons_index = cons_index; *cq->set_ci_db = rte_cpu_to_be_32(cons_index & MLX4_CQ_DB_CI_MASK); - txq->elts_comp -= completed; txq->elts_tail = elts_tail; } @@ -535,15 +534,15 @@ struct pv { const unsigned int elts_m = elts_n - 1; unsigned int bytes_sent = 0; unsigned int i; - unsigned int max; + unsigned int max = elts_head - txq->elts_tail; struct mlx4_sq *sq = &txq->msq; volatile struct mlx4_wqe_ctrl_seg *ctrl; struct txq_elt *elt; assert(txq->elts_comp_cd != 0); - if (likely(txq->elts_comp != 0)) + if (likely(max >= txq->elts_comp_cd_init)) mlx4_txq_complete(txq, elts_m, sq); - max = (elts_n - (elts_head - txq->elts_tail)); + max = elts_n - max; assert(max >= 1); assert(max <= elts_n); /* Always leave one free entry in the ring. */ @@ -689,7 +688,6 @@ struct pv { /* Ring QP doorbell. */ rte_write32(txq->msq.doorbell_qpn, txq->msq.db); txq->elts_head += i; - txq->elts_comp += i; return i; } diff --git a/drivers/net/mlx4/mlx4_rxtx.h b/drivers/net/mlx4/mlx4_rxtx.h index 9d83aeb..096a569 100644 --- a/drivers/net/mlx4/mlx4_rxtx.h +++ b/drivers/net/mlx4/mlx4_rxtx.h @@ -125,7 +125,6 @@ struct txq { struct mlx4_cq mcq; /**< Info for directly manipulating the CQ. */ unsigned int elts_head; /**< Current index in (*elts)[]. */ unsigned int elts_tail; /**< First element awaiting completion. */ - unsigned int elts_comp; /**< Number of packets awaiting completion. */ int elts_comp_cd; /**< Countdown for next completion. */ unsigned int elts_comp_cd_init; /**< Initial value for countdown. */ unsigned int elts_n; /**< (*elts)[] length. */ diff --git a/drivers/net/mlx4/mlx4_txq.c b/drivers/net/mlx4/mlx4_txq.c index 253075a..b310aee 100644 --- a/drivers/net/mlx4/mlx4_txq.c +++ b/drivers/net/mlx4/mlx4_txq.c @@ -273,7 +273,6 @@ struct txq_mp2mr_mbuf_check_data { .elts = elts, .elts_head = 0, .elts_tail = 0, - .elts_comp = 0, /* * Request send completion every MLX4_PMD_TX_PER_COMP_REQ * packets or at least 4 times per ring.