From patchwork Tue Oct 24 12:35:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moti Haimovsky X-Patchwork-Id: 30785 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD41B1B7DD; Tue, 24 Oct 2017 14:36:29 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0066.outbound.protection.outlook.com [104.47.0.66]) by dpdk.org (Postfix) with ESMTP id B944E1B7CF for ; Tue, 24 Oct 2017 14:36:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HhPVZ/TArWwfnAxCknlHrXN1um+4O4UFjj0xeiMskgQ=; b=wjfFmdk216DI7AxHgz0SpwAaXgNelKZIhA/owVRmkqHLmMqwrn133iT2mUrPBHXWyAJ5WiMnsdAj4rDVr9kLNaAqNhOga67U2L8fWxPY76eiy37Z45c/ibip+pnUW/h10dRWj0dGFaTlwGt1VDy5UwuLsU3orpKTUKXENO3RX7k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR05MB1920.eurprd05.prod.outlook.com (2a01:111:e400:7b79::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Tue, 24 Oct 2017 12:36:24 +0000 From: Moti Haimovsky To: adrien.mazarguil@6wind.com Cc: dev@dpdk.org, Moti Haimovsky Date: Tue, 24 Oct 2017 15:35:33 +0300 Message-Id: <1508848533-180885-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB3PR0202CA0005.eurprd02.prod.outlook.com (2603:10a6:8:1::18) To VI1PR05MB1920.eurprd05.prod.outlook.com (2a01:111:e400:7b79::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4bccf31e-c363-4f7b-7d3e-08d51adbd762 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:VI1PR05MB1920; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1920; 3:QKs4BXvhipcZcy82XDnXXcpTVpdgLn4YnxYGpR2vW2kAwJ7G7Ul/AJM/Fw2QTLV/qgegf6JIbCtBs0Hp0sCV1ZftRinlZaIvpO0pEYIqCpYQxXH9QaDnTHxTMJqoqvpMOBNBN5KJElWmrOA+Nln3vUf+kKSpqnWXKKEUpcm1Ab0rmjpnW2svli0psBLg4j+0L7LJ7v+jQ5iIYUc+eg9tD6SjJg3mnAI/3lG5M6mG56nFOotTOzMdxkwJi10dYIP8; 25:yYj0ZJQj8pDqRcZ/Zw70XZ7DIYuuf60ZHq1UYpOCbk+kgGrlGBMNB6WW+M5u5Ma2wrOH3ba2E852/0s8A96ne8L6SYEB5OKNek5DnTdlwNsVmo3aWNZdyghfOSSc/ESlTbcq59/g56Es2xSZwaJErH4U57NIpLY+sEQfSjWFnQlFLb/KLrJAu1FDW+XCUGFzULSIzmpOx53Az5ovZJHOMeZOVe8LUYfj2GQuZoeSL/TIGw98W+F7mepkvHEP4qngnhjC2VnuvffiJe7lzfFB94dHQCQV/wfpryWVnqbzAIrSHo57KvT37zBhNUc6z/bDaMB+vGEJXq19vGoZUvwItyrFAHGqEzNadSuefThnE20=; 31:uwf8O4KOmX1U31d6w/q0YdI5M2+gByA/U1Dd6NzQSMIi0TUHicycWuzkTKOr9LorkzyZ43QVWbH10bWlD0FSJL3bLGxUDnSgp5119PxhKh4L8AjzmfU0tYVzXVmFcxiY8xU9Ct82iZbfYRgliXewolWkVbOjYj69PxtF8aBiVqYG1QVzc6D8lRIioG7Gad9q+WJ+x2G+ERI2kvyfUdRqHidaT8LEqDVP96+zcWNmGPk= X-MS-TrafficTypeDiagnostic: VI1PR05MB1920: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1920; 20:2TObTo2RLYITf9o3G9kb9RSG1Fq5TJ+7M1//Xsu+Tn4k9oO+BqywKtaNlWQID3Uq/UBB+Jh2zizrW59z1roaMYmB+T9/2BjS9DFhrfFbciLZMWebx5zbOI3Zt2ZPp1ObJzzxqLhyM5au+Ci1frb+xNUochDPPPsU5LctRkzbWJvlazPAcvzKefgyx/XDnhuH47fPYRG3t75XBaVcwtmtMMu5MFuOyKYKuTuQ2dqJCDdx5iVHC2ktR6LdLEUmy35C/nXGtVgJUJsPyMILi6gClw/Ddn4UXDl4ndDkp2CqGxTZjb1sG+xq74Zz/UczhjuiVEzVnqD7ptbDr2w/RVeo8aLqaMZsqTFdwAXgfnb7uiqVCpltPk1J+ly1RoM7hZWwPFvExY6g+/oPdolI0cE1/+vDDOdV9af2WFJkrX/5m/ICl7xw7jH3bJXbaLGBpXkJl97PijaU4ItamQgJLiEreUkbxJxqxCnKxa19rRLFfzTHgO26WaNdXbmqodc47j6X; 4:S8hfeY+hYTrLC4z/Wdaaaa3UhnmLlWexaAnqIAxPEP0Br9FwillXSLX9YqV7eC0cAht0cQ0gbxLA0xbwxwLjz0ed6DAE0CkHLsl1OrrqgshFlYHKE/SrVLhY4O0q3M3IWW2SHVTWZzwRbltp5KzSGNFWUNwdzWGNZd3GiW55kNITkDGUI2tRQJ5LjBbwjx7QdBPmCjzaF4FvSEttu6niLUtCCzipHuYVyBWVAdQG68aXQawMSc8cmWF5lSE13mn5 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3231020)(3002001)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1920; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1920; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(199003)(53936002)(36756003)(7736002)(55016002)(305945005)(4326008)(50466002)(25786009)(478600001)(316002)(48376002)(16586007)(2906002)(86362001)(66066001)(81156014)(8676002)(69596002)(8936002)(50986999)(50226002)(5660300001)(2351001)(2361001)(47776003)(105586002)(81166006)(4720700003)(68736007)(101416001)(33646002)(106356001)(6666003)(6916009)(189998001)(97736004)(3846002)(107886003)(21086003)(16526018)(6116002)(5003940100001)(33026002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1920; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB1920; 23:6A+8o7+svTeVQxanZbTas4/OzX1f62lNP+KpmEGKG?= 975fGC5vKUTzIaBpPi/rpkVFs3AgodbxNwPqdNcrzVL2kBKoE8F+1X9aVWSrNHk0BmsB5l6h8AumWXAVfumN5Q+W0FzPR09uOL0WjVmyN8r1qIo30ncuzw2weFOokP74NcOdFPJn9elVYFNJy66fXXRz//ZmtQ26XK6G3xV1hDgvPKmk6zi2ZHcfe1ILVv1cO72Gb5JxdXj+8WL1idn7c9PfCg4BfK5N7MZWBz4rnyBKg85oAnrWufrWhdGjyU4d3xgEKFQQYuZzuiocuKFmMINNbdaG+7SeqEJccrz2B5RarBnCNGWwt6r9BJbytOo8HO1wrkRD5xSvlgLfAbK1NaUvDvVXDzWOv9QCv/62iz0HtpkVc4EqPzbPA/YFxE5cTJgSUHOjTowp1AIzDbebj0daCzSYJ+ATh1XRrD4FGkYprj2asYx/m1jbuAnyS3PVbL0kAZsVACUa7vbYiJuCdPlU3lUtFrEK5cyBBbKbSckonSZd/FTic4jEFB6tabe6siGAEQ6XHnKlcWCILeLp72VMs1lWGHE4sPBleDD3q57+VRbDJP4Bl8n7KQltFL2d+H64TjE6aQqoDaDibzCQ/I1DuMH34oRDeozP3Ve3j+aTaamCH7elJnrHhP1wOdz/ei0Pr1yBzs/rt7deVmfgLWGJqsC1jg1LWJ5zpRtJ0pQRAlfhzskLKCnlS7Q3MgZ067XxXXfGb/2b2PcEJ4oRQJywTpyqJp37qNKIovLcs5i2va6DE6hTWi7Djc6wH8J4jFPD7t1EEzOe/mQSISGdTwGHbZDpjgjZl6GeCeoKK9dJMN+Lr4P+M1Gi2OHp5SSNqMdALf3bsfZ3ftVpBMe0FzhAVKxhZ7wcnHOvwn7+ZHM10VmHvFfdpaleN081AWLIdrq9w1/xGRFzuLqrh1QWCfjB2OPx/Il2d5PQo4FXjgSLvf4FRoFle2NZjYfrDRnCnVqCp3FMMamL7/PX70/wwvcYJUvXSSzP49BSu2XFEi7Ww2YRZ5JtX1MmSftVt8vZv0cxD6OBOX9n4sTryk4/JtAPZ0pkO+0+iLtK3F0a+1hifd0XpQrZHPwmRjfsf48Xg3sF66KsdleIr3u2Y30bOf0AiMyNyDig51J0151qCNd2w== X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB1920; 6:E+VOJL7oSSsIvFOyWwTkBQXvz5cVF6fHCAx/ShgEqasu94ZmPpGoLOVA48iMiWOxqkOLnlHXI+PCuPK7W+G0+6Cl+MECrisgqptFYQKpws3FYa4OsPhB5c6dMuQJICxrXhK1t9hushx/YVIWKDFJTPPHcbhTEieEEB4j4dKO1ixYXV8/7/o4IZo1PCvrQpd6HDBJ1EcJDgoIpruATcdOUbFsmCWatdYiLFmaBW/AGovDnzcYr0lOhKYDiVZjp6UL7mk1IQWz3YDxGtEomo+ybLMRrN7jFgYfuJC1SgBft+AinjfRjAeAcnwxvXluZkAVanpzxlYaPGE6N/XkYgmTEw==; 5:kR6JQ58qa94A4Djd7OCJVdi33ywz+v+BI/d46EzgsrlqI6mHDHb1BkkZQmu/Xn+onRJ8jPTIh1sbCXSv7AW1vKfxQP4K3+MZyNLwqe99vCeZVUHjIX08yrvMT6C1AXVkEuhtzB4pqjghS0Sw65ZYgg==; 24:7uN7ZQo5oZyptBE4hz9FOOoRb9VVeOgY+zETlNcztLJkQku7fqkXnKdA8OJYa/rh7knzM89WqhbB8R2P/GiI29ul0T+JmST0xVyLYqrjW0g=; 7:WuDGS3hvAS82mQJbjoZIUP8UJHdFUJ5zYerfd1UAK5PibFsXbtJpbCE6+xM0v8V2JtNdrBLtwvqUpYWWMxj8g0YJj6VeQ+M5++tbeUDlcDDo8YtXazSJ9ZOVkjVSGElYo6vB/gJLGwwAe3n6t8E+Ti8XZYYVo5TRQLFvr+GVQz2/4yOzOJy1uAR8LgWWoRdH0PdExVzldWT+AePrzP89T5AGyYL4iKDSsai/OxwXCPE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 12:36:24.8696 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4bccf31e-c363-4f7b-7d3e-08d51adbd762 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1920 Subject: [dpdk-dev] [PATCH v1] net/mlx4: fix missing initializers for old GCC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch works around compilation issues seen on RHEL 7.2 using GCC 4.8.5: [...] In function 'mlx4_rss_init': [...]/mlx4_rxq.c:433:19: error: 'wq_num' may be used uninitialized in this function [-Werror=maybe-uninitialized] Fixes: ff3397e90080 ("net/mlx4: relax Rx queue configuration order") Signed-off-by: Moti Haimovsky Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c index fb28290..4c50077 100644 --- a/drivers/net/mlx4/mlx4_rxq.c +++ b/drivers/net/mlx4/mlx4_rxq.c @@ -417,6 +417,8 @@ void mlx4_rss_detach(struct mlx4_rss *rss) if (wq) { wq_num = wq->wq_num; claim_zero(ibv_destroy_wq(wq)); + } else { + wq_num = 0; /* Shut up GCC 4.8 warnings. */ } claim_zero(ibv_destroy_cq(cq)); if (!wq) {