From patchwork Tue Oct 24 10:05:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 30773 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95BA61B79B; Tue, 24 Oct 2017 12:06:18 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10081.outbound.protection.outlook.com [40.107.1.81]) by dpdk.org (Postfix) with ESMTP id 03B691B79A for ; Tue, 24 Oct 2017 12:06:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QZQ667AvBFDxxjqz6AtkAgfaHRbLLPBrTDa7EGF0JlY=; b=bsqP4jYlRcTplO4fzcDQJ34/SxuJeKicdpOz+G7SMErSFkXjFHxaTlNuRe9LRgU8k2dBNcmdr/QnZCfxZz6m083xFJn84xxA2EoEiMixtQpUxEeBw1T/Q9qfWwe9TVxOOlW/gS/qxdUKcPlJ460paO2SPBJec76tcJWo7TpRbDs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3657.eurprd05.prod.outlook.com (2603:10a6:7:85::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Tue, 24 Oct 2017 10:06:14 +0000 From: Matan Azrad To: Adrien Mazarguil Cc: dev@dpdk.org Date: Tue, 24 Oct 2017 10:05:59 +0000 Message-Id: <1508839559-1568-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1508834730-30271-1-git-send-email-matan@mellanox.com> References: <1508834730-30271-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR0202CA0024.eurprd02.prod.outlook.com (2603:10a6:4:29::34) To HE1PR0502MB3657.eurprd05.prod.outlook.com (2603:10a6:7:85::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65cfe3fc-2d52-47ed-f159-08d51ac6dc94 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:HE1PR0502MB3657; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3657; 3:SmdXDXErn7MkIa7FpwyiHf105P0hdB5KtWrBX7FWtoO5X3dG/lOT3/dkGSytu6mQ7+KfPDOrPMZ7guUuTcoqmPkoVUVsZpGxlAOdkL0cUmjCyIi9H2nZIwnchDS2SM7deReC5BSytOetc4JA4iJAWjtjrhjhQWKggwS7ObrE27I1qDfgLilKfLsO252mZ1vIsAVIJ99yx/gbT+bpZsPkz7cccNpnBfAzLuIqNbvbMs4Wbj51akpFqRuT81hwlAsz; 25:dJA0J/INYaPnwPb5BxiGmr4jAokzjfwjfGTiRVP9y+YyMSLPw9xhyZnvTEb7EhAb7M6m9K53qUmPRkMjFAtXqoW0oU6bKpBCjHb3CsgeJBqT7nm0aqHhPvSMXQtAxbljg5gftwI/X4BnYmBJCIYYQ9yI73lbAZOSZZgXAz1aMd2TulCbc43aq+3Mpua70jLVDTCuTQBYAU9sy72UIHldcQvxYibqr9FjwV/QRsPhxrGUZ/7V6U/ng5co5PbSXrQYvqw4Y2QupHxwGHIjBuTz/JDCcngPTBbuqMdy3ZID/t7rEzVIfXHSuXut8FYkKU59cO5dB2DL4RoQbPfUteFBow==; 31:LsVdefK7Ftjd4Bt6DXCqP0/aV+x65U7DLsN48v14ckinpVSLnQzTf9kNiAtABKUgW715hBvxoOzKM3rhH1jdw5PsxgCNgdqIfGBIxpOJXS56JfJSDwlbeFiTMro7RLsrJv3VufoKZm+YINc4R05rWRc4/jrlPVPRM2FuDuVttFW9GtX8B/BcmBhDXipEPf7f3ND0wcIFaal2O/G2Jlnj8/10xzFPTm02TfcX8kl43yA= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3657: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3657; 20:fSHeaaEHLMBeb43t3hCICUPa22e/tCUJWzNpt6DE5tW8v15QmoAe7Cwq9fS6iYQavoQXSiSgiA/oDkwRGaysZTTVWoDv9Pki7Vpq4RQ1Z1MIjAQeQbRo5TXv34zfNjV6XVRykIm08n1fd/F19cZYWqfji02ta6QfBQq8g+CFchw0vxPADIm3dpSrdCPkxJgjzkpgKoxQFSTlkJ9Vt0pPttMeEg2cJILadtb9lrDKzfnlxtzSDp3nVPU/XKUKqQXuYrlfmw3XPdddISM+EsmZF0fbzjZ30ZDiwowVEW2zrky/GgyoDysGGQlJuLtGPgy5rW6r2VpS64gCA4c8r/UpySe8TePVD7H83EKACyObhxRRg4Bxzw+XGZeWp9fpbhZi/dTA8ZJthAhy/PWBVN029nMd8nB4lkz4Mfg5tAnUfmMGnwJEcVhwg5HnhGVLoZDSoIPHFMwFL/PNStqZ4w7Z/1/ESrY8Nn35MkxcMu1bQMzP1RR70q+PZ3L73SrUkNzv; 4:Jq7Se945rh/vKm4rZoBfeDoB8qJT70qj9jWcPi63Lmk92S566aKVAoFPh3ynw1Ud2ntpLEpNRwzP1z4DPeXXRbrQVT9U4M0Bs1rZ7f4Ypr2hhTogmSWSEtffqe1J+vPOxafeeQ2E6W7gnA1oxAXE44HaBFr2hnlVcHy2BC0DdqeTNSJjVeqNTywMM8W7Dxyod/CNUFJ02GyiQr20s2vvrbx5Ed45T3kCTgWvLBcEpaMAzOwIJhkkR1LpgykbWdKu X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3231020)(3002001)(6055026)(6041248)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0502MB3657; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0502MB3657; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(106356001)(21086003)(53936002)(33026002)(5003940100001)(50986999)(6116002)(4326008)(55016002)(8936002)(3846002)(7736002)(8676002)(47776003)(33646002)(76176999)(81156014)(105586002)(97736004)(305945005)(16586007)(2906002)(69596002)(50226002)(6666003)(36756003)(2950100002)(6916009)(101416001)(81166006)(575784001)(16526018)(66066001)(4720700003)(5660300001)(25786009)(86362001)(478600001)(48376002)(68736007)(316002)(50466002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3657; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3657; 23:4rV5WHheYpRUliWoW+dPDDotlfmQa7xEZFqZ2Uf?= 9/EzgqbBQDAnfzvrUS3/2d5zw4PiHnLkP6ZNgmlWZeTMSyRM4V8BZHnwe5BjtJ4vJAe8m8QIadrSD2042SyHC2dJsqAQx4cTuBgLkjThYSalHNjxegAkuGS1eCzNQ4fxoY3Tc4xgekfOTwh6s96IgY847UW7C/rm6z/3wg0B+5T+APgNp7yWmNa0kqirRghDxKM9hEnRXjP/RPpVrqImInPRwXBJO7gZ3UC9Bd2GENhwuBEoD0maqUg/i0py8AYomS+JVYlgjUsR0COG3xac9vAwWf6D5zcqlz0kaPIN0Wj9PObhLoB2AMXi5jla12VF1zmF9y+T8TpfuCO7H72HlD7DXxJYGzysBw0Rayag1NXTZBXQRd7xOeBdoHvyeavJ6EHaFFr6/orf5EwX4stGQabiQTyxFCA5drtjVYcqm4fTzVRCy465+8P9YLik/1e+25cw6VC1DhX+IJVAWyXIByJ3hfe8+Y9oI9t3jFOxe985I11wASGePgpe1unZs+OQB7xXtP0eqNqrgwlLhwQ5AOr8dZouVnr//ab0ymWI8E4OVs0Z8y3SNf0+VffhYU37H6/mtlRMwbXG6wPYn3rOrkJIcSHQ+ubttjarsFtMYkmYNXrd1XZtwCBS2CXfmGnOM/t+N1I13U3F1Mv6Rx3CQ1wMmGGpUMPFI5PI+sMk0eUdMGBocUaqhRDUCPKcSTUtUxHX/VeQI4j6E5psSucZawghRyYe4y6d1OOW0uB864sE0ri0G2M/3CXwo4spUG1UsD0L2WrtviMClU+4sbf6CadWxRmMlr4E/RvjNsvXBm2WW3mUYfy8gg6VHgNL6ztH4iXYYmzszSo4plN2q43mZunZDiqMz218ovdWbfgKChUhL43LAVxc5b5/gDajDM2II/4a9Qm3bm1sQXWK4M0yW0OQn2WYgSgW3AfCJ/O8XCSsfwvpEN6nWX0Q6Mze/CkycTXuN8EYC8/2dvec8xm8/zmBRFGvQcqMEO8YkEU9v2AVv5RqRtLnAuMbxkp2uFpoNL8iMyqb4nn3tDiD6pa8Pu6fLnevEH17jqWOARit/IrTE8Nhczemw/ssXgrCoRrOkuXbP772tVL/V+ScPWnUo3p+WqDP5Xxasj1Nt7J6IwAmi7Q== X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3657; 6:on3ptTKgrMxu0PuIQLSo2OnKyqfR8COQMLZ6M1v8EZvEosyLHpplZE5RJrwpYC6LY7HYZrnHDAqjtHTtJ5UdVL7unY+ArI4ODZWgHb/yErc5GVCLjE3rrnyh0xljTdPxNEYO47ffAP3QAuHz+DjwiTrS1kMOMxMRl4UkURyZITvd3UVtFjzdl1UXv7m2wNWu5efkl3SsIk55GNkp3VWzki6RA4VMzpM908gHnJI4R4jWGcLAe1szBuUspEnQQ/WAMFfY+uam6Aksodoi02HjCnbFyn5R9sEt1iseY5RQuSeRXgZxZ05Y/7wDViKb+boVaOQm8kiVCX/LK7o4RO3Wrw==; 5:x45QiFewwv/YkawIHUTHNIodSzrOzNHqpK5vLCRuGvquzBpdWWPTckE2FnhtOdgG7DrhgtYGdgKqr7Wd6rc4dsphT+wTrBD6Gxgdza1y2RBBuF/LAepooyJ9bk1ZzBwMHgWRmjDPMk6eijK85Om3/NZvplhi/HzqztUhyMdef8E=; 24:aQNJ3irSPIGiZMNlYy+kBuehR+qClPc2F3DuNyoNpfjiW723/GXRyUdkOQU/2IBBNbVVryyHyPw+1CIFXpJAnTBAiG2BcUJr3/kakCq+Uww=; 7:UeTxBoUfEc5QJ15hUFidq4ePrhfK8YqjjOt/Ji6J+Ec5fn6j5Bkqthu2LNHdnUUUmzIdv2KijiS64eu+c3Zg8P4tG08cKMGaaMF+89GQZ0k+58DKnvvbKCLY8gta+L+dTvsmUYLImiTJ2+GMqUtnEsj+fJP4J9p5qWq+MgVxYu7yQ8pRL7eGg2ceqnszS29Obn4SqIJku4cElVW8SvHgzqGsBdkcHfYaDPO2F7Dxx1Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 10:06:14.2513 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 65cfe3fc-2d52-47ed-f159-08d51ac6dc94 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3657 Subject: [dpdk-dev] [PATCH v2] net/mlx4: fix targetless internal rule creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The corrupted code allowed to create internal rule with no any target queue in case the rule creation occurred before queues creation. For example, when user calls rte_eth_dev_default_mac_addr_set after probe and before dev_configure, mlx4 fails because the RSS queue number was 0. The fix prevents internal rules creation before queues creation based on future creation before traffic start. Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API") Fixes: bdcad2f4843a ("net/mlx4: refactor internal flow rules") Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_flow.c | 3 +++ 1 file changed, 3 insertions(+) V2: Fix typos in commit log. Append fixes line. diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index a0f431b..7a6097f 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -1290,6 +1290,9 @@ struct mlx4_drop { unsigned int i; int err = 0; + /* Nothing to be done if there are no Rx queues. */ + if (!queues) + goto error; /* Prepare default RSS configuration. */ *rss_conf = (struct rte_flow_action_rss){ .rss_conf = NULL, /* Rely on default fallback settings. */