From patchwork Tue Oct 24 08:45:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 30762 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B5AD1B763; Tue, 24 Oct 2017 10:45:50 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0070.outbound.protection.outlook.com [104.47.0.70]) by dpdk.org (Postfix) with ESMTP id E6F3F1B756 for ; Tue, 24 Oct 2017 10:45:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LtaEjfwdc3cf4doIXsRQjcF9ZBjnBuNtDlrs1VLYEeU=; b=jP7rGwTt/9f2rSEeuTByq1YJjs8AZfLNicLwdxZHU0IpaB32TjO8e8+7G4vd06AvneE7Qua8m2PzHEJrYv9v/7E0kG8NTuh7IQcXmK1PN2a60mXC2U4+tZvYTtxQd+JpodonbkLRUEc0AdRilYydv69RqvpnLn6fuTagbS3lat4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0502MB3663.eurprd05.prod.outlook.com (2603:10a6:803:f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Tue, 24 Oct 2017 08:45:46 +0000 From: Matan Azrad To: Adrien Mazarguil Cc: dev@dpdk.org Date: Tue, 24 Oct 2017 08:45:30 +0000 Message-Id: <1508834730-30271-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR05CA0273.eurprd05.prod.outlook.com (2603:10a6:3:fc::25) To VI1PR0502MB3663.eurprd05.prod.outlook.com (2603:10a6:803:f::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc3afc9e-de37-41c5-53e8-08d51abb9ecb X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:VI1PR0502MB3663; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3663; 3:jlmCHFnZAoqnQai8qrx+2/vFD/lOLyQVS72KUFPZPPCs2pGGRiibajeZew6g668xAIACfu3stEcHlDu26o+mvS719zW3wO6qzOtNKxLawzFK3xtzL54SN7+plVmt9fF/Mej106ZVjhRNoQ3JOjrjhMthcZkz6UKbN/I5wsdXX57wn7B3upBGM4AElu4xOxCgVVFa85aQp/FCIETKDviMapYy8O1v4EELaHvqCmBuq9WiZR9iXiXRYozPWEZQhnZo; 25:BR8JXOvs7pNBvFfnKU9qzThmTJYcfWdrNV4+JjZNnb7GB5z69wjSTuz7C944T9itfv1ElGAxHb44Rze5V3zsBaKN7mEbbzg0u5NbGRAxaOqTTCR+3HS0dQT0u5UvVLHU16KmYoN2gqMcOA/zeW+pAkEQanSnFs6zLIQQGtSRaij7Lshuxl0W4F3hcL6ZSlISVYfg331sAdkIbdLZIDJ5ynG1d1vQRCKWZ350UlyrMtSg722nWPUr9XwPN/ZAGNryJh8uJNR1xJwwiImg+gFrmzCwOR73rr/Gg5rm5JwrugYC2QzOKlzm3NArFfm8n6NC+9ZMnvcDP8YIiOFifPP+Dg==; 31:tjoVpsytxzS7jMTyBg5ovbqJ733kbVrvPCNzgCS2uSklElvX7NHduK8CBbQRfqg7xnbtMSxPeNGS2GQ6F4xRLAF9EUA0sKRoFeQMK9b5nCqN2/MvSZ5GINJwyydPYHebOR1ko1hfQEkdPFlF3EQ8PS31YnuO0ISdxf+VPSVBj1tnN3WL8RMKbYtItxlJOUfgDJolNUaSmptZ34l3lrlp0HDHhAC1nBTriCo88az7o2Q= X-MS-TrafficTypeDiagnostic: VI1PR0502MB3663: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3663; 20:6pA3gjEf4+/6p0P7mv09VfZpHH17CpnONR587Xdl5Ui8WolFJ+W9eehPHV3aTWM8DzSYKyxXIjUTDSXFaCRj28KKgwFhYT1yPYn4iXFynseZe0dJp7V39bba7jCFYVc8T5K7OXM0gh6keIt4kQqwxTpqkkVnvL0fRXAnPYjuCsyYwowMZZ5pDgOiRA94bza+fu93Xy3C9wEePUi9KtpW3Yvc9AfJtf15CODo4TDna4WG9FuE4wp+Dz1LwO3MI71zRDpkb9Njxz8rqHf+1NCJm+hA5cEuQD2M2fAHtjkJ+D2M6uNXKVJmsK/eQlqdTXUwVvgqf3Hf8EJ48jISExC03i2+ekswzeg6HRPC2r3ea+dOwRw6Xtnx8rXVb0Q2zNZ7RiT93zlEiju143/TsaFQ6lCYnUct62SZBwFmGTBV6hNVngtfp4toLrOjShMzZjMDzRukkEOHxvcUpYYm/dQv2vlZvYP3xOINLU6zfom1kKQLwM16xRf2ZjryG9bcUa9h; 4:AhcALuz8l5r6mvS2X+CYF597Wgidt8dt/1m/F7EXkVRZVrPXI++X1T/M2DbLF/NI526Lz5+BWVoGn9OqV1BPs0RrdKCC5HiNo+VddXZDn7nEeLGBZUHrA9REEmSKPlJyxp8v9Q6ebrPI+J1MZVQcJEVFhSsO+BrlKxr0++LD3bsmBIKwm1LHziKCMsm2VOyu5hxFutmZ2xEZv7w3YCmkyjN81aiSgx/tncoVnWYJb91nShgnRkm5WMs/1wyIAbpy X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(3231020)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0502MB3663; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0502MB3663; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(199003)(189002)(50466002)(48376002)(5660300001)(47776003)(53936002)(4720700003)(86362001)(97736004)(105586002)(478600001)(55016002)(106356001)(33646002)(305945005)(16586007)(3846002)(66066001)(101416001)(6116002)(316002)(7736002)(575784001)(6666003)(21086003)(6916009)(16526018)(4326008)(50226002)(8676002)(25786009)(36756003)(5003940100001)(81166006)(2906002)(189998001)(81156014)(8936002)(33026002)(50986999)(69596002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3663; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0502MB3663; 23:M2iHWEoHJQZK9WOjRtPhzG7G0gxYN3IbKBMdtU7?= fAFw0ZONDHATInTreH6+GAcseSvnvwmzvGWKw8lg5W+nagRTa8pwwEMBnELisiIZP1lfqyC3uTQ7ntVCBhm8Buk6H1YdckAXx4Npet7/CTIWk2CfqDGw3lsrhUKiRNsggTXFa/UAUFzA3draw/UzQMdAqHMeXw8hXqfE3XchoN3e0PAxabNnIJxCVpo0qDZ7kkDCllngjXOtTWymuBv+TC2C5nGQ/LV1J+2BIjO1QjEavAWIMAbkPuerUz/oKcCe8vd+MO8UCxvR40z4dn5zruEo+BzsFeR5VRbd3vkvQCCFqwWaIRPYKuFtnDDqcPjW1ByYzSrGHR52zPF7BNA1raEf+IRjOeehP+Vpx05QjCl9JMuRtKax2TNH+IdMOwDF+hg7Pn6ZJ1NzWojJj5JV3OND8hV0VtbydoTHCV5bGGpo6i7J8zgoLrMPQRcno5TRLNMxzWbd0z2Spw13fnlikXq9nu4Ip3G1ZiuB0C1M3xES5/v1WFoxhdfBaabgtrwVsb2GL8Nu+AYnYO+A6RLtMK83yQ4bvuEE8Wrn9EeOc2XJmGLg7jMzus/EjuAR7hCRz4U7wBHb2pa7jGbrn29dLVTQa+9CBWECEyYrXtyxmFGpL4sP4AJm7nZMDmwl0UqZG2qzHhfVxqBOaGwHhlbPUMoK01RFnT6hXt9VYbD72C6/WFoRb1m0KRLXj3fwxkQWtLHHaVfAGI5Dtzsb3y5uA5DAAujH+lRwNL8e55fzCajxkEVTXs097jkzJox+LhoQPEXJulmjHuRBCljJX8sH5/LDAHVlEWTjDypHxQwk0NjE+VQ4fzeMKMMmdQeaG25S1XZF+Ey6LVkwchmoPKppYlCsDRPot0nxycjncs/M2MNfA5BXZnTAjR0qM51gngNK+IILvN8p+ZZv0jimT/P06ChKishUrlyGSmD1Z60BhFGOzv4hsxzap50tcaLFoEB2EQxSUxEvqrH5pRaDaSI6clmTV1hSnqmZA0pYesXqfxaGaiQm6VOKV1EZfUC0VmJhn3UF/h2rqoeZ/o8N5EztM5+lWwIgccdu683wOjHHsUDxc1aI3LcoxUnearrXJK20Dpac= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3663; 6:DoqAwz+HxDAoE+4w8NL5CWTIWn6TuhmF73gs9rw7Z9mzR5ycu4xHYmYRcURyhlA33NRL3SmlVBbLk9XWtzSH5Uhkx+IJlxpyZhqCp7EmwO8XDs2WfGnIWEIOg1+tICLtaKxKAJYzUDD+uzJi+IXrnjWw+zMDjhDFIG7rjEQBsgIhBNh1pEn13l/Is3XyL4xR7FgObwxKscMonmIm+KWX7HBwZryie1VNKBtBmLRpwnfasH5UIUKeh2zMFrllTb2K3RltXVQQJVZONwPf263tdsYD/zxVOIrcVoQ0NLyTHcSZowhan0AYgGjus2AiN2dt+MDC84mlqDaQ9kf1Mi2vfQ==; 5:FvO3CJCmGH6IHOqO0xyq0gbmpo9k/Asqt4BqqgVemoSHJj7xqqyubXYzcDh9sDxhcYrKZXXr/OsFTrfEiENW94LiQRAf3lrZjDXG05tNQobau6qJbhdtvwO8IyZDyx6R1zwbrIdTQpSx+YaeOK0GQQ==; 24:6BMXXVpoHiDbjjSG1mV84H0hrQOIS5FSYgL9j3B6bRFAQL7WiyigSfALMzKF80xTtwXB36qxoy8PvZrtISroeubCRTctiEDf2L63XuJK/lk=; 7:H+qWtZhSaOGeZspKalIix1mOc6GS8ontzzp+g7+FVNG8ERtSQ5J2WV5BMNFrfmzZ34EEOGWNm+UCphKl01gbxgjPuA0lUJ77Be4dC7mW084UWMAKmaPvFWF3e88baS9gNuP8rJ8DTpMEPBzotQWQJ88ivID4miFlvy0G0BWKVG5y8Q/TJGeNCk6qpGsxH2RLbOwXTv2Ph6y9qi9kz5dp7UmLKHxwaqPnz14+cRjoCIM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 08:45:46.0937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc3afc9e-de37-41c5-53e8-08d51abb9ecb X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3663 Subject: [dpdk-dev] [PATCH] net/mlx4: fix targetless internal rule creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The corrupted code allowed to create internal rule with no any target queue in case the rule creation ocured before queues creation. For example, when user calls rte_eth_dev_default_mac_addr_set after probe and before dev_configure, mlx4 failis because the RSS queue number was 0. The fix prevents internal rules creation before queues creation based on future creation before traffic start. Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API") Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_flow.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index a0f431b..7a6097f 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -1290,6 +1290,9 @@ struct mlx4_drop { unsigned int i; int err = 0; + /* Nothing to be done if there are no Rx queues. */ + if (!queues) + goto error; /* Prepare default RSS configuration. */ *rss_conf = (struct rte_flow_action_rss){ .rss_conf = NULL, /* Rely on default fallback settings. */