Message ID | 1507042556-9839-1-git-send-email-matan@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 677951B3B2; Tue, 3 Oct 2017 16:56:17 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50063.outbound.protection.outlook.com [40.107.5.63]) by dpdk.org (Postfix) with ESMTP id 010A01B3A9 for <dev@dpdk.org>; Tue, 3 Oct 2017 16:56:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9xRVsuEdLMdEVUpVeIy83+VKN0+Wv3Gyo+PtYvJEMRo=; b=hAJI23UPk3UDmHtqe1NTFDPWLU2EfYDEzuiefdTXDARp4N8CEB0/QGh/myiEZZ+ycqmXk2ikHyUaNEzUGT03DPy54ZrO8r6lBQ9sq0uLDuXT53WT9ktGoCZscGgUgFHeq4p1l2yz6gOVhBYJJ6eG02gelr648NIlQs02XSZ9Yco= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0502MB3048.eurprd05.prod.outlook.com (2603:10a6:4:9f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 3 Oct 2017 14:56:12 +0000 From: Matan Azrad <matan@mellanox.com> To: Pascal Mazon <pascal.mazon@6wind.com> Cc: dev@dpdk.org Date: Tue, 3 Oct 2017 14:55:55 +0000 Message-Id: <1507042556-9839-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0101CA0055.eurprd01.prod.exchangelabs.com (2603:10a6:800:1f::23) To DB6PR0502MB3048.eurprd05.prod.outlook.com (2603:10a6:4:9f::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 296131dd-08be-476a-c658-08d50a6ee449 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:DB6PR0502MB3048; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 3:BWn0KqdpM+KfiC6wrJh1xHMitQM0VvvxrdKoh7zjUjcJ/Wyo//wT78n/f3tTKSVizdrCRRH96t+MSuyED4Q9FAbRXk1pm6CdB2npZ0uPyaY6cmeYc1+GVbanW3749zv9pXiE8whXZ9yf9iYH85Bqt/hhGK9njNvIo/wKWy6rmo9gxR5P59Uhxbrr2+dLyV9XYZLwxXtbHI8RnfDWekSypuY1seKIXyf+L4uk1iPh4r/vxrbIGNTpmMrb/J4k/M05; 25:5JYxrFcgcyM/GT1DjkEXnyVdG+DVbCm8Lf4wVtQhVCPxguFngi8av2XZE3AHvpDDCLLSQumi4KPaljaN6ooJJ/ypp5wsqlXL8MUMBSQkoREtcdHuunV5ZksYq7NMErF9sLkYYo7KtKMVQzyNKSq9c57YyoR2JBlYkuUvH+limqbgkm8Sb6hzy/SrF7MdZ3THPSr0S/iqiR0DiGlfSHWtuicfxwlD2+oIfdE2/3rMJY0Ky/iOslADibXBs1VceS5U+Oc74poTBkRE3XR7fuCXSEeWQhs4Gfo0+0yKkMFThKJ8i+MF4oFVOjPQkrBl7HenJzZWFUz393BoQdxouEzJgA==; 31:mLBv9lZZggNt6PvHO1OAGqtQjbyyl0SNFxvI2BYqtmgfhCJiFNivfme47wCCG9XJ9XM4OHDOgclA9DEreVLlQpFWAywBLvGvWeGSi3VA7/m3OerYkctk86VGgorlWH4rDGr4cch2QHU4ckAztXg4p+U3Q++94eAjM6/Jt9EDqrhVLBlhi4XSe+SKP1zgO03OXNhw0rikcZ/EBTLh6uiGLDBUjD2jAXrsOwFHvpL+2AA= X-MS-TrafficTypeDiagnostic: DB6PR0502MB3048: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 20:iLrNN0Zo9+4Lwft2pP0J24ph0NNjHbCNRDEW7SzNOwg0YWxcP8M7TvFnM3es/HR05xbISKV9heTJg3mM0k0qvTjpjJAGRKF4O3MCV2pSAOAob73j81QgWw4cMe13eFp+BzGRzHSM3BuDMXUFVsm/KN7gcTgkt7hJRQuqfA+mMyex4ipkdXBuj+MPQXIkfe0W3p1PVRL/0a0PFlZKsCA8U4Sb4Jlq30ZNGYsXa6dUpO8lS86Z5eKtZ1q3PqOSxweZmOuclPX2ProFc6NyRVct8u/+Ce7aqaV9TMVuhM82j6VwjnxtdJlaY1SWcgmFhUxZG8BsPZLKiR3YzxYdHuXn0YESr3FXSozG4Didgw6WnRvyuolRNsSKNHPeeYXeKIjTxuC26ayscXI6uv8sFLOUi0hwmCLQNRRhmkBjV2zPb9YDyFNCXDcu1zzdaolacfP8CPCn2mSa+xvmdYVUtWb1nOWDuHdorcHFdU1+PXGq4rpxk4NGVfRguvfXgq40vDRT; 4:fCh/GMrH+OrRx5TJmn9HP8Yn/N8tXm+rdmfGvaRCIUbwcr02H9S8/KBBend54qn3QVeUCNyK04a/Urbd8kdILT/VExhDMxDLwu+1M+ZOX8bDLCMvfYO3fUkq+0L9nT/5IID914EB3Sa8k81H0fiKnkxmQz8tQvpvP3MQcfkMNw3f/1Umbbz+dbkal4NJL6Zwb3bVTizppJDrZ0vdceJPrd0lJtS28ua151gKTR1LGjEyt+rikiZ+ihg4tTBzglkZ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <DB6PR0502MB30480EA3323A17753600BF15D2720@DB6PR0502MB3048.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB3048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB3048; X-Forefront-PRVS: 044968D9E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(199003)(189002)(5003940100001)(4720700003)(316002)(6666003)(50986999)(66066001)(3846002)(33646002)(7736002)(48376002)(16586007)(68736007)(16526017)(189998001)(8936002)(50466002)(81166006)(305945005)(86362001)(81156014)(8676002)(478600001)(4326008)(25786009)(2906002)(53936002)(55016002)(47776003)(33026002)(6116002)(69596002)(97736004)(21086003)(36756003)(6916009)(105586002)(5660300001)(106356001)(101416001)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB3048; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0502MB3048; 23:LdFcsNdnckx7Jy/O704AUnpQFuMcl97ExlczqHs?= MKY5lRrRt8izVE0SSvnM314QeL/zqOrwVFn9hp89TRSq0sIO8c7XvfivkrsH/7hB/N4xKXvZk9tQh/NEbH4ciHEY4BZgX/lRV4lYa1rbHIFR7nk6fy0GLJTDcP/j5f7pJAz8s9Rp+gzTMf8dx+u397crR22nX6YXQgCE5+JbLy9JnU0jqkAByXgQ9asnEC9qnacOj/FCZlvwHQ3C7OvIk7MlXXsQqOcUHRJXVgbnNyqOPZ2qBM46sYyvvuoovhk3Cb4IqL92/N4q5P/lxZYJlPeYHIDyium9LIImY9xzwpSuQFXrFMQ5LJ2wG6SFX8PT8oKFbl+y8G0ekz5Ywo27xMTBMlhS/uHQhAob/UIXCZa+/oyU+WV7VQbbcK20BfggJcJUIDpGGQ4Fpm9QTjlt2+JW4gF5IRyWVBkJeKDb5DgnDNXMSHGr4/A+I14Gbo/jwf4Lq3TyiTFkzO5rHrPiP+SLqZXZGLDSMCr7WgFiwFX6/YV/qUiyiXmACf4ZjdYOvXnaNlD9BlHH9Ec7EEuaAZ+PNaRErmHXt0hnMa2kmMyEaifzUZ9e35nzZ3pbf0vG+s8DtEioZq3VmBAYCTEIiUgze6FsIAZB2ptZPAVr5ua4N/O313IDskgTceexGoXWZzbaXpARWKBGGbXGnRi58WXLJfbs+QBZhhlJt7QaeE37gUd7iB0xeN4OkW51BJzIbq5bJXmZlufhVj+FCJhxpANGoFMaAAXK2Y4tlSqN84+Ai2XzC4N7eVtrjK0QtBLUNuxA2kCKz9lX2hLeJY+rA4DC9Kf1o9eEPmGuS2pdSVa7SLcztBKAQpkNjoyQEhyrQeou7tl+72eDqgYfA9RTa00L4oyc73RFaUxYFlrGeP40FFETdNU3r4BlMi2XydSjCFReXhJBcBQYQ+2ZJVc7lfVbTDdpSrPaggN0TB6g5hDhCiTt/XwhCYgtGNGokjA2N5G1/hsGcFZ/JoQR1BpZY/GSLgT9xxXE7bXJhhca1t+JphQrBYMyPdhMkGVQTtQ692Mar7rthFnQpl8JTxejzmm+s2dTqiGn4FS+nf7nHd8vDAw== X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 6:jO+0kn9kuly6bVaR/aU8CPiSv9GvHKWN4BCnnoQGe6mAxstxbR2W3D6fIQwNIR4aIBLabsq4pslKwViKF+9Eo0nqjiOYsW51aqzzvEo4blq37/R5nluQpU7JY6dZFy6H+1pvOdsO7IjOdEOYRPuCnDDvIvVKdmXUItYZtktsPW4khX3R6IYt1H2ktIoLG9aNQDLE4gLmO2N8qOsz4JssctbW0wiemm4HigyTBQ03a3tSYNW00T/MyJWX8EBQJAOpgM1lQmrJOyKPvyydjK+eP0pX5JwQ3w1CGS0lpONtDbm47rewqmCTcKCGwTzbkYrbFuUhPj1TL7iSxVXZokUelA==; 5:6K97g1yR2NZUTBIBbI3qyMlWEHe4/tMiHCbrfRvt9lHVan0Uv/4ZMjndpW4mwsYp1DQWMeIUVuGjTxTVKqYRKsLAWgJ4LzGuFRIy79VYROdJqudZ/NbT6FjTt0IzyzwdjET83TbYtuw/iK9Ok6LhEA==; 24:HPZivyoJ+mPrVkWilL36daCo+XkhePAajZ3JYBU2fBwHrfFl3w4GWzqkYYl1MpgbeBLJFx7jFQ0jx/4Dqn2XPRyCLIzxjw92u/Jx1fm3FA4=; 7:pgwVHb8g6DGRYv1KE59ztsa9ue1uubuE+yeW0PMoepYTXyyzs8JdKtwHTNrY/2pjjY4J8ekMFTXEqT1jStcI7o0CuFM9Tv0qZdM9oflcBOUvrnFRdKErKGflTzCkV+yqWb8PpuNyJPByC4r0MQ/EuhlKDoAZbM61iRtqomewt+gzv86ndef1Uf+ucezlqfqVhQ5IN7LeFkTRh0txQMmubpZ/FEo6f/XfkGfr1UxrCDY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2017 14:56:12.9576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB3048 Subject: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Matan Azrad
Oct. 3, 2017, 2:55 p.m. UTC
Missed 4 spaces were added after break if line.
Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands")
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
drivers/net/tap/tap_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/3/2017 3:55 PM, Matan Azrad wrote: > Missed 4 spaces were added after break if line. > > Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") What do you think fixing this when that code has been touched next time? > > Signed-off-by: Matan Azrad <matan@mellanox.com> > --- > drivers/net/tap/tap_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c > index eefa868..aa33960 100644 > --- a/drivers/net/tap/tap_flow.c > +++ b/drivers/net/tap/tap_flow.c > @@ -1093,7 +1093,7 @@ struct tap_flow_items { > goto exit_action_not_supported; > action = 1; > if (!queue || > - (queue->index > pmd->dev->data->nb_rx_queues - 1)) > + (queue->index > pmd->dev->data->nb_rx_queues - 1)) > goto exit_action_not_supported; > if (flow) > err = add_action_skbedit(flow, queue->index); >
Hi, I'm surprised there's only one place in the file with indent problem, but I'm ok with the patch otherwise. Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in patch 2/2, right? Best regards, Pascal On 04/10/2017 00:07, Ferruh Yigit wrote: > On 10/3/2017 3:55 PM, Matan Azrad wrote: >> Missed 4 spaces were added after break if line. >> >> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") > What do you think fixing this when that code has been touched next time? > >> Signed-off-by: Matan Azrad <matan@mellanox.com> >> --- >> drivers/net/tap/tap_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c >> index eefa868..aa33960 100644 >> --- a/drivers/net/tap/tap_flow.c >> +++ b/drivers/net/tap/tap_flow.c >> @@ -1093,7 +1093,7 @@ struct tap_flow_items { >> goto exit_action_not_supported; >> action = 1; >> if (!queue || >> - (queue->index > pmd->dev->data->nb_rx_queues - 1)) >> + (queue->index > pmd->dev->data->nb_rx_queues - 1)) >> goto exit_action_not_supported; >> if (flow) >> err = add_action_skbedit(flow, queue->index); >>
On 10/4/2017 9:15 AM, Pascal Mazon wrote: > Hi, > > I'm surprised there's only one place in the file with indent problem, > but I'm ok with the patch otherwise. > > Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in > patch 2/2, right? I wasn't sure about getting the patch that fixes only syntax in one place. Good to have proper syntax but a commit for this looked like overkill to me. So I was suggesting keep it as it is and fix syntax when that piece of code updated later. But you are the maintainer of the driver, if you have strong opinion to get it, sure I can. Thanks, ferruh > > Best regards, > Pascal > > On 04/10/2017 00:07, Ferruh Yigit wrote: >> On 10/3/2017 3:55 PM, Matan Azrad wrote: >>> Missed 4 spaces were added after break if line. >>> >>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >> What do you think fixing this when that code has been touched next time? >> >>> Signed-off-by: Matan Azrad <matan@mellanox.com> >>> --- >>> drivers/net/tap/tap_flow.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c >>> index eefa868..aa33960 100644 >>> --- a/drivers/net/tap/tap_flow.c >>> +++ b/drivers/net/tap/tap_flow.c >>> @@ -1093,7 +1093,7 @@ struct tap_flow_items { >>> goto exit_action_not_supported; >>> action = 1; >>> if (!queue || >>> - (queue->index > pmd->dev->data->nb_rx_queues - 1)) >>> + (queue->index > pmd->dev->data->nb_rx_queues - 1)) >>> goto exit_action_not_supported; >>> if (flow) >>> err = add_action_skbedit(flow, queue->index); >>> >
On 10/4/2017 6:26 PM, Ferruh Yigit wrote: > On 10/4/2017 9:15 AM, Pascal Mazon wrote: >> Hi, >> >> I'm surprised there's only one place in the file with indent problem, >> but I'm ok with the patch otherwise. >> >> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in >> patch 2/2, right? > > I wasn't sure about getting the patch that fixes only syntax in one place. > Good to have proper syntax but a commit for this looked like overkill to > me. So I was suggesting keep it as it is and fix syntax when that piece > of code updated later. > > But you are the maintainer of the driver, if you have strong opinion to > get it, sure I can. What has been fixed is still in next-net, so I can squash this. <...> >>>> Missed 4 spaces were added after break if line. >>>> >>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >>> What do you think fixing this when that code has been touched next time? >>> >>>> Signed-off-by: Matan Azrad <matan@mellanox.com> Squashed into relevant commit in next-net, thanks.
Hi, Sorry for the delay, I was on vacation. Nevermind this indent patch for now. Matan, could you integrate it (squashed) when you'll have a new patch modifying tap_flow.c? Thank you. Regards, Pascal On 05/10/2017 23:33, Ferruh Yigit wrote: > On 10/4/2017 6:26 PM, Ferruh Yigit wrote: >> On 10/4/2017 9:15 AM, Pascal Mazon wrote: >>> Hi, >>> >>> I'm surprised there's only one place in the file with indent problem, >>> but I'm ok with the patch otherwise. >>> >>> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in >>> patch 2/2, right? >> I wasn't sure about getting the patch that fixes only syntax in one place. >> Good to have proper syntax but a commit for this looked like overkill to >> me. So I was suggesting keep it as it is and fix syntax when that piece >> of code updated later. >> >> But you are the maintainer of the driver, if you have strong opinion to >> get it, sure I can. > What has been fixed is still in next-net, so I can squash this. > > <...> > >>>>> Missed 4 spaces were added after break if line. >>>>> >>>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >>>> What do you think fixing this when that code has been touched next time? >>>> >>>>> Signed-off-by: Matan Azrad <matan@mellanox.com> > Squashed into relevant commit in next-net, thanks.
diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index eefa868..aa33960 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1093,7 +1093,7 @@ struct tap_flow_items { goto exit_action_not_supported; action = 1; if (!queue || - (queue->index > pmd->dev->data->nb_rx_queues - 1)) + (queue->index > pmd->dev->data->nb_rx_queues - 1)) goto exit_action_not_supported; if (flow) err = add_action_skbedit(flow, queue->index);