From patchwork Wed Aug 23 08:49:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xie RongQiang X-Patchwork-Id: 27753 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D4E6B7D4F; Wed, 23 Aug 2017 10:50:52 +0200 (CEST) Received: from zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 487B47D42 for ; Wed, 23 Aug 2017 10:50:50 +0200 (CEST) X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20170823165031 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 23 Aug 2017 08:50:31 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v7N8o3hE080908; Wed, 23 Aug 2017 16:50:03 +0800 (GMT-8) (envelope-from xie.rongqiang@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.171]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017082316500709-602765 ; Wed, 23 Aug 2017 16:50:07 +0800 From: Rongqiang XIE To: johndale@cisco.com Cc: dev@dpdk.org, Rongqiang XIE Date: Wed, 23 Aug 2017 16:49:24 +0800 Message-Id: <1503478164-13185-1-git-send-email-xie.rongqiang@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-08-23 16:50:07, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-08-23 16:49:55, Serialize complete at 2017-08-23 16:49:55 X-MAIL: mse01.zte.com.cn v7N8o3hE080908 X-HQIP: 127.0.0.1 Subject: [dpdk-dev] [PATCH] net/enic:fix no return value bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In enic_alloc_consistent() function, if the value mze malloc faile, !mze is true, free the rz should return NULL. Signed-off-by: Rongqiang XIE Reviewed-by: Ferruh Yigit --- drivers/net/enic/enic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 40dbec7..1d956cd 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -368,6 +368,7 @@ void enic_init_vnic_resources(struct enic *enic) pr_err("%s : Failed to allocate memory for memzone list\n", __func__); rte_memzone_free(rz); + return NULL; } mze->rz = rz;