[dpdk-dev] app/testpmd: fix wrong cmdline message
Checks
Commit Message
In testpmd, GRO is supported by csum forwarding engine, but the cmdline
message shows GRO is supported by io forwarding engine. This patch is
to fix this issue.
Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 8/3/2017 10:45 AM, Jiayu Hu wrote:
> In testpmd, GRO is supported by csum forwarding engine, but the cmdline
> message shows GRO is supported by io forwarding engine. This patch is
> to fix this issue.
>
> Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
03/08/2017 13:11, Ferruh Yigit:
> On 8/3/2017 10:45 AM, Jiayu Hu wrote:
> > In testpmd, GRO is supported by csum forwarding engine, but the cmdline
> > message shows GRO is supported by io forwarding engine. This patch is
> > to fix this issue.
> >
> > Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
More precise title:
app/testpmd: fix GRO command description
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, August 4, 2017 5:40 AM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message
>
> 03/08/2017 13:11, Ferruh Yigit:
> > On 8/3/2017 10:45 AM, Jiayu Hu wrote:
> > > In testpmd, GRO is supported by csum forwarding engine, but the cmdline
> > > message shows GRO is supported by io forwarding engine. This patch is
> > > to fix this issue.
> > >
> > > Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
> > >
> > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied, thanks
>
> More precise title:
> app/testpmd: fix GRO command description
Thanks a lot and I will choose a good title next time.
BRs,
Jiayu
@@ -424,8 +424,8 @@ static void cmd_help_long_parsed(void *parsed_result,
" Display the status of TCP Segmentation Offload.\n\n"
"gro (on|off) (port_id)"
- " Enable or disable Generic Receive Offload in io"
- " forward engine.\n\n"
+ " Enable or disable Generic Receive Offload in"
+ " csum forwarding engine.\n\n"
"gro set (max_flow_num) (max_item_num_per_flow) (port_id)\n"
" Set max flow number and max packet number per-flow"