[dpdk-dev] bond: update the NTT flag when partner's state changes from slow to fast

Message ID 1495439531-10608-1-git-send-email-zhangsha.zhang@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

zhangsha (A) May 22, 2017, 7:52 a.m. UTC
  From: Sha Zhang <zhangsha.zhang@huawei.com>

According to the standard, state machine of lacp should transmit lacpdu
when partner's state changes from slow to fast, rather than from fast
 to slow.

Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit June 27, 2017, 10:12 a.m. UTC | #1
On 5/22/2017 8:52 AM, zhangsha.zhang@huawei.com wrote:
> From: Sha Zhang <zhangsha.zhang@huawei.com>
> 
> According to the standard, state machine of lacp should transmit lacpdu
> when partner's state changes from slow to fast, rather than from fast
>  to slow.
> 
> Signed-off-by: Sha Zhang <zhangsha.zhang@huawei.com>

Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 7b863d6..742fd44 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -435,7 +435,7 @@ 
 			 * In other case (was fast and now it is slow) just switch
 			 * timeout to slow without forcing send of LACP (because standard
 			 * say so)*/
-			if (!is_partner_fast)
+			if (is_partner_fast)
 				SM_FLAG_SET(port, NTT);
 		} else
 			return; /* Nothing changed */