diff mbox

[dpdk-dev] net/i40e: add return value checks

Message ID 1494340654-29221-1-git-send-email-herakliusz.lipiec@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Lipiec, Herakliusz May 9, 2017, 2:37 p.m. UTC
Coverity issue: 1379362
Coverity issue: 1379365
Fixes: 71d35259ff67 ("i40e: tear down flow director")

Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
 drivers/net/i40e/i40e_fdir.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Helin Zhang May 11, 2017, 1:04 a.m. UTC | #1
> -----Original Message-----
> From: Lipiec, Herakliusz
> Sent: Tuesday, May 9, 2017 10:38 PM
> To: Zhang, Helin; Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: [DPDK] net/i40e: add return value checks
> 
> Coverity issue: 1379362
> Coverity issue: 1379365
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
> 
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_fdir.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index
> 28cc554..b8cfa0f 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -300,8 +300,12 @@ i40e_fdir_teardown(struct i40e_pf *pf)
>  	vsi = pf->fdir.fdir_vsi;
>  	if (!vsi)
>  		return;
> -	i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> -	i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> +	int err = i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> +	if (err)
> +		PMD_DRV_LOG(DEBUG, "Failed to do FDIR TX switch off");
> +	err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> +	if (err)
> +		PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off");
>  	i40e_dev_rx_queue_release(pf->fdir.rxq);
>  	pf->fdir.rxq = NULL;
>  	i40e_dev_tx_queue_release(pf->fdir.txq);
> --
> 2.7.4
Ferruh Yigit May 12, 2017, 12:05 p.m. UTC | #2
On 5/11/2017 2:04 AM, Zhang, Helin wrote:
> 
> 
>> -----Original Message-----
>> From: Lipiec, Herakliusz
>> Sent: Tuesday, May 9, 2017 10:38 PM
>> To: Zhang, Helin; Wu, Jingjing
>> Cc: dev@dpdk.org
>> Subject: [DPDK] net/i40e: add return value checks
>>
>> Coverity issue: 1379362
>> Coverity issue: 1379365
>> Fixes: 71d35259ff67 ("i40e: tear down flow director")
>>
>> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 28cc554..b8cfa0f 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -300,8 +300,12 @@  i40e_fdir_teardown(struct i40e_pf *pf)
 	vsi = pf->fdir.fdir_vsi;
 	if (!vsi)
 		return;
-	i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
-	i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
+	int err = i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
+	if (err)
+		PMD_DRV_LOG(DEBUG, "Failed to do FDIR TX switch off");
+	err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
+	if (err)
+		PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off");
 	i40e_dev_rx_queue_release(pf->fdir.rxq);
 	pf->fdir.rxq = NULL;
 	i40e_dev_tx_queue_release(pf->fdir.txq);