From patchwork Fri Apr 28 10:47:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingjing Wu X-Patchwork-Id: 24000 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id BBF1F2935; Fri, 28 Apr 2017 12:52:00 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 681AA3B5; Fri, 28 Apr 2017 12:51:58 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 03:51:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.37,387,1488873600"; d="scan'208"; a="1162122585" Received: from dpdk2.sh.intel.com ([10.239.128.246]) by fmsmga002.fm.intel.com with ESMTP; 28 Apr 2017 03:51:39 -0700 From: Jingjing Wu To: dev@dpdk.org Cc: jingjing.wu@intel.com, stable@dpdk.org Date: Fri, 28 Apr 2017 18:47:44 +0800 Message-Id: <1493376464-97074-1-git-send-email-jingjing.wu@intel.com> X-Mailer: git-send-email 2.4.11 In-Reply-To: <1493189530-84124-1-git-send-email-jingjing.wu@intel.com> References: <1493189530-84124-1-git-send-email-jingjing.wu@intel.com> Subject: [dpdk-dev] [PATCH v2] examples/l3fwd-power: fix zero rxq handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If the number of rx queues is zero, it is meaningless to enable rx interrupt. This patch fixes it. Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: stable@dpdk.org Signed-off-by: Jingjing Wu --- v2 changes: - fix typo. examples/l3fwd-power/main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index ec40a17..57636e9 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1654,6 +1654,7 @@ main(int argc, char **argv) uint32_t n_tx_queue, nb_lcores; uint32_t dev_rxq_num, dev_txq_num; uint8_t portid, nb_rx_queue, queue, socketid; + uint16_t org_rxq_intr = port_conf.intr_conf.rxq; /* catch SIGINT and restore cpufreq governor to ondemand */ signal(SIGINT, signal_exit_now); @@ -1714,8 +1715,13 @@ main(int argc, char **argv) n_tx_queue = dev_txq_num; printf("Creating queues: nb_rxq=%d nb_txq=%u... ", nb_rx_queue, (unsigned)n_tx_queue ); + /* If number of Rx queue is 0, no need to enable Rx interrupt */ + if (nb_rx_queue == 0) + port_conf.intr_conf.rxq = 0; ret = rte_eth_dev_configure(portid, nb_rx_queue, (uint16_t)n_tx_queue, &port_conf); + /* Revert to original value */ + port_conf.intr_conf.rxq = org_rxq_intr; if (ret < 0) rte_exit(EXIT_FAILURE, "Cannot configure device: " "err=%d, port=%d\n", ret, portid);