[dpdk-dev] crypto/qat: fix dequeue count stats retrieval

Message ID 1493307077-14100-1-git-send-email-gage.eads@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Eads, Gage April 27, 2017, 3:31 p.m. UTC
  The QAT device's dequeued_count and dequeue_err_count stats were
incorrectly assigned the enqueued_count and enqueue_err_count values,
respectively.

Signed-off-by: Gage Eads <gage.eads@intel.com>
Fixes: 1703e94a ("qat: add driver for QuickAssist devices")
---
 drivers/crypto/qat/qat_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Fiona Trahe April 27, 2017, 3:47 p.m. UTC | #1
> -----Original Message-----
> From: Eads, Gage
> Sent: Thursday, April 27, 2017 4:31 PM
> To: dev@dpdk.org
> Cc: Griffin, John <john.griffin@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] crypto/qat: fix dequeue count stats retrieval
> 
> The QAT device's dequeued_count and dequeue_err_count stats were
> incorrectly assigned the enqueued_count and enqueue_err_count values,
> respectively.
> 
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> Fixes: 1703e94a ("qat: add driver for QuickAssist devices")

Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  
De Lara Guarch, Pablo April 28, 2017, 7:54 a.m. UTC | #2
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Trahe, Fiona
> Sent: Thursday, April 27, 2017 4:47 PM
> To: Eads, Gage; dev@dpdk.org
> Cc: Griffin, John; Jain, Deepak K; stable@dpdk.org; Trahe, Fiona
> Subject: Re: [dpdk-stable] [PATCH] crypto/qat: fix dequeue count stats
> retrieval
> 
> 
> 
> > -----Original Message-----
> > From: Eads, Gage
> > Sent: Thursday, April 27, 2017 4:31 PM
> > To: dev@dpdk.org
> > Cc: Griffin, John <john.griffin@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH] crypto/qat: fix dequeue count stats retrieval
> >
> > The QAT device's dequeued_count and dequeue_err_count stats were
> > incorrectly assigned the enqueued_count and enqueue_err_count values,
> > respectively.
> >
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > Fixes: 1703e94a ("qat: add driver for QuickAssist devices")
> 
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Fixed "fixes line" with 6 SHA-1 bytes: 1703e94ac5ce
Added Cc: stable@dpdk.org

Applied to dpdk-next-crypto.
Thanks,

Pablo
  

Patch

diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 679b257..386aa45 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -1275,9 +1275,9 @@  void qat_crypto_sym_stats_get(struct rte_cryptodev *dev,
 		}
 
 		stats->enqueued_count += qp[i]->stats.enqueued_count;
-		stats->dequeued_count += qp[i]->stats.enqueued_count;
+		stats->dequeued_count += qp[i]->stats.dequeued_count;
 		stats->enqueue_err_count += qp[i]->stats.enqueue_err_count;
-		stats->dequeue_err_count += qp[i]->stats.enqueue_err_count;
+		stats->dequeue_err_count += qp[i]->stats.dequeue_err_count;
 	}
 }