diff mbox

[dpdk-dev] net/i40e: fix default PFC setting

Message ID 1491896149-29328-1-git-send-email-jingjing.wu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wu, Jingjing April 11, 2017, 7:35 a.m. UTC
To keep consistent with previous release, PFC need to be disabled
by default. This patch fixes it.

Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

David Hunt April 11, 2017, 10:11 a.m. UTC | #1
On 11/4/2017 8:35 AM, Jingjing Wu wrote:
> To keep consistent with previous release, PFC need to be disabled
> by default. This patch fixes it.
>
> Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
>   drivers/net/i40e/i40e_ethdev.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 6927fde..3e640b3 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
>   			hw->local_dcbx_config.pfc.willing = 0;
>   			hw->local_dcbx_config.pfc.pfccap =
>   						I40E_MAX_TRAFFIC_CLASS;
> -			hw->local_dcbx_config.pfc.pfcenable =
> -						I40E_DEFAULT_TCMAP;
>   			/* FW needs one App to configure HW */
>   			hw->local_dcbx_config.numapps = 1;
>   			hw->local_dcbx_config.app[0].selector =

This also fixes an issue I was having occasionally where traffic was not 
forwarded by testpmd on my platform. In those cases I was seeing ~4770 
pps on one of the ports rather than the full rate (>20mpps).
A git bisect confirmed that this commit (6f0a707e5b55) was the source of 
the issue.

Tested-by: David Hunt <david.hunt@intel.com>
Ferruh Yigit April 11, 2017, 11:24 a.m. UTC | #2
On 4/11/2017 11:11 AM, Hunt, David wrote:
> 
> On 11/4/2017 8:35 AM, Jingjing Wu wrote:
>> To keep consistent with previous release, PFC need to be disabled
>> by default. This patch fixes it.
>>
>> Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
>> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>> ---
>>   drivers/net/i40e/i40e_ethdev.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 6927fde..3e640b3 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
>>   			hw->local_dcbx_config.pfc.willing = 0;
>>   			hw->local_dcbx_config.pfc.pfccap =
>>   						I40E_MAX_TRAFFIC_CLASS;
>> -			hw->local_dcbx_config.pfc.pfcenable =
>> -						I40E_DEFAULT_TCMAP;
>>   			/* FW needs one App to configure HW */
>>   			hw->local_dcbx_config.numapps = 1;
>>   			hw->local_dcbx_config.app[0].selector =
> 
> This also fixes an issue I was having occasionally where traffic was not 
> forwarded by testpmd on my platform. In those cases I was seeing ~4770 
> pps on one of the ports rather than the full rate (>20mpps).
> A git bisect confirmed that this commit (6f0a707e5b55) was the source of 
> the issue.
> 
> Tested-by: David Hunt <david.hunt@intel.com>

Applied to dpdk-next-net/master, thanks.

(problem described by Dave added into commit log)
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 6927fde..3e640b3 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10266,8 +10266,6 @@  i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
 			hw->local_dcbx_config.pfc.willing = 0;
 			hw->local_dcbx_config.pfc.pfccap =
 						I40E_MAX_TRAFFIC_CLASS;
-			hw->local_dcbx_config.pfc.pfcenable =
-						I40E_DEFAULT_TCMAP;
 			/* FW needs one App to configure HW */
 			hw->local_dcbx_config.numapps = 1;
 			hw->local_dcbx_config.app[0].selector =