[dpdk-dev,1/2] net/ark: update packet Rx path to set mbuf time stamp field

Message ID 1491827199-4853-1-git-send-email-ed.czeck@atomicrules.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ed Czeck April 10, 2017, 12:26 p.m. UTC
  Time stamp was carried in the packet meta data, but not
place in the mbuf. The new time stamp field is the proper
destination.

Remove the setting of data offset since this is done by
rte_pktmbuf_free()

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
 drivers/net/ark/ark_ethdev_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

John Miller April 11, 2017, 10:10 a.m. UTC | #1
> On Apr 10, 2017, at 8:26 AM, Ed Czeck <ed.czeck@atomicrules.com> wrote:
> 
> Time stamp was carried in the packet meta data, but not
> place in the mbuf. The new time stamp field is the proper
> destination.
> 
> Remove the setting of data offset since this is done by
> rte_pktmbuf_free()
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>

Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
  

Patch

diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
index 97bfba3..f39e6f6 100644
--- a/drivers/net/ark/ark_ethdev_rx.c
+++ b/drivers/net/ark/ark_ethdev_rx.c
@@ -292,7 +292,7 @@  eth_ark_recv_pkts(void *rx_queue,
 		mbuf->port = meta->port;
 		mbuf->pkt_len = meta->pkt_len;
 		mbuf->data_len = meta->pkt_len;
-		mbuf->data_off = RTE_PKTMBUF_HEADROOM;
+		mbuf->timestamp = meta->timestamp;
 		mbuf->udata64 = meta->user_data;
 
 		if (ARK_RX_DEBUG) {	/* debug sanity checks */
@@ -322,6 +322,7 @@  eth_ark_recv_pkts(void *rx_queue,
 				mbuf->pkt_len = 63;
 				meta->pkt_len = 63;
 			}
+			/* seqn is only set under debug */
 			mbuf->seqn = cons_index;
 		}