From patchwork Fri Mar 31 05:29:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 22981 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C4433108D; Fri, 31 Mar 2017 07:23:32 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0055.outbound.protection.outlook.com [104.47.36.55]) by dpdk.org (Postfix) with ESMTP id 38DB9FE5 for ; Fri, 31 Mar 2017 07:23:30 +0200 (CEST) Received: from BN3PR03CA0113.namprd03.prod.outlook.com (10.174.66.31) by BY2PR03MB394.namprd03.prod.outlook.com (10.141.141.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Fri, 31 Mar 2017 05:23:29 +0000 Received: from BL2FFO11FD037.protection.gbl (2a01:111:f400:7c09::101) by BN3PR03CA0113.outlook.office365.com (2603:10b6:400:4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14 via Frontend Transport; Fri, 31 Mar 2017 05:23:28 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD037.mail.protection.outlook.com (10.173.161.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5 via Frontend Transport; Fri, 31 Mar 2017 05:23:27 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2V5NN2I013221; Thu, 30 Mar 2017 22:23:24 -0700 From: Shreyansh Jain To: CC: , , , , Shreyansh Jain Date: Fri, 31 Mar 2017 10:59:16 +0530 Message-ID: <1490938158-936-1-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com> References: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131354114082405424; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39410400002)(39380400002)(39400400002)(39850400002)(39860400002)(39840400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(9170700003)(6916009)(6666003)(2950100002)(33646002)(47776003)(81166006)(2351001)(36756003)(86362001)(38730400002)(104016004)(105606002)(110136004)(106466001)(4326008)(8936002)(50226002)(8676002)(50986999)(53936002)(5660300001)(8656002)(54906002)(77096006)(2906002)(305945005)(48376002)(85426001)(50466002)(5003940100001)(189998001)(76176999)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB394; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD037; 1:Gfo+gb85AbCiGE8BR7qaZwdKGsxus3lGV9Jb/2kFBgPPczkNQIw+46fHTrHsxZemZLFY3fx8l3WLJy6fOdpqT9YQPZ1+kkAvfiKggWPLjEZ62EVwlGlTcTswR80wBKD6Uti88oimBTNIf6ZDVxRhfRsbcGCCAk54dmRK1B4OF7PXyuDg0fHoZZx+o5kn4njQzndQ7D5ma8yzQrYxaChI0NLvlMnoYS85b4ALdm1KxMsMFxfm3XfCErXraGWS2/6ABD2fREV5y+Qg6X+gTCmCScE++OFXmc034Ns8G1lyHbdU3O0aIaSYC8BLgdeTsRAOkADQ6KqX6BUSARx8dbNEDxRAdApwLDhhRU8nfa8+SkVxuLt490CHfkOWtt9tz77WkkBbwIAP+udZOtt3EkiCIQoz1xnF6kz72MttD4ty6BC0fEs+ACaNKO5up14KMHb1pS1A5S/LjtvUQQGZA2m0vwRsw9sWzcG2MyJSUbu8R5vKOFF5PHQxFkZ+re4NJ6BQUXTcTSzUy8TrXeH41v9LLA3pY1nnYy26asHKiDGzP8tOyA+2i1/lhHkTyRH61mNDei4VD+QNvXJ5dE4LkDjV+pzT+LbSO86ma/dtGOU+YzVoDaXM+kkQtk80qw2ZwlQubVMrWn1m8rXNFM9cOgzqa3x3CnAOZyyV3IDgnKetchmY0q9CRAfkgIE2rcTmekZ2HY49YcnY0xSqY7Pvm5SrQChuBwqckjaVnlHibPQ7psGCjRAUSJYp0n2E3ghexzRDfIo6v/BynKBEv4tUUCHpsQ== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: dfaa876e-5026-4fa5-9acf-08d477f6101f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030255075)(201703131430075)(201703131517081); SRVR:BY2PR03MB394; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 3:DAGe8+79BhV0OQpf6+3x7vEmh45V4qCJ4x1YHpwsVzY26YYe5aOJqiHvyNMtSzbn9PV6WFVIeSMq2Zb2NNMN9IdxVbDc2Okq2ppsXXZlvfolS2g2XJHdePprGAQ2mvvJf9Iot291bb7WxbIS/KCfvNiTE5FFvHJ/MpxBUHm0pX4Zn8J/W5VcOnc6nshexIpDGRbiY2KyW1VbDWzcIT54NW4PGpF3Nfqr+ZF+p5uJdVq7FN9QHjS1FhoTPtCFNxgOs7X9fr/Vxr/6W+OsdqvBplmcbZNGfD3EC6RgIvV8Rl5loLn5r4ZhJxU+Ap/6Xlc1WWU+hE5y5+LgW/RgLUGijNbZlbXP6ta9Gm3iW6cUvoyA/W9PjZz3cS3fCwdy4yhv4chQVoE8UPM7/4sIAlDVt8y425lK37DgEV4w/7Nat+XGr9L3RwnLAFmM2Cl5QEZ3ckwUq/qZ/NvLfYFGN0CB2A==; 25:1Gz5/gPtzEptcCy6TJ2eDZEah+jzVUp6NjArwxC719L7aq97p1hKt8buTeXV8XJ3DFaRygsCT1oIs4FGj4jcb5GKhhJ02ugXbBG3nrkc+QgQ/2j6/+iNKCrrMoj2k+TiuKC0o7EryxUjPvd44mWI8daOayKj5a/s/uTIrk2krPTGKBAQHlaI8uprzeuQ/H8gGymAy/T71feZ9GGUpcMXFEydDw4eWUSapH9LRAS+XWopgs7znTYR8cXKAodmePL/1B9iFxYapxeBh5qcz+oO70mgygqBLlf9Z2SERXElEZuZrknl7JGPq4Lxf0n0Wn6gGuHznJ9mxQTa1IoFmc4KctzSzL8+de2IUdHMk68tGt8F/B7qJDapIDdGfECb2i04E7lgsSH3KySvxSMCSBQSzSLCiA1KvDk5ncncO9zGpBYkiKLJvTEiZ9+VHztN3MQ7e9j+CrTQ5DPpnsc0tRLo7w== X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 31:xxGdEFi/5ltdnq3dhvBnNbdPOBmUs60Q0CS25ukD4UmR/LAVdh1S5zlD6kMAOSFU8alKDVAKrflj/9uct9miS36Vfu7sx/aIT1K8smzMq84MEbECTyT1LYaGvFC0NL/qFzPg8xCm/0Zm0rUi3TY+zVjQCuzo06uI01d7nUFcK1iI3rIl6wrJXdgD3PQbai10Cjg+7BIbgkMg0EvnivLQU5ddBw84QrYP+DciZxaww2A/pROHLA8WQVXKQSjiJRHlBw19ef/Z28FKQFPexpRTew== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13023025)(13018025)(5005006)(8121501046)(13024025)(13017025)(13015025)(3002001)(10201501046)(6055026)(6096035)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259075)(20161123561025)(20161123565025)(20161123556025)(20161123563025); SRVR:BY2PR03MB394; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR03MB394; X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 4:lon+LLRhksEw4V5L8ZpG9GDQOcTSmo560sE0sCf8tS8JBAkGiSMQ8AQs8Fxk3trscoTfVQKeg1G5D+krQdgsYLOFRxTTI3MY7yeB12ROqqhI6qdGsnLa/ORDHZF1FkBU1jJzH5T79WLbMqal29xhqfMGDuIOuiZiOxU/ivRWGrXYvAqw3mX7C04hciAvnLlVmrHqENFD0cfO7M9JMnF9J6InzaxxPqjER4NaroRFzVWnSp0zzlEUqX4nDV7CRbilusrqYpNh0sTu01tqIcAXS8LBM9B3RoIaZUJdlZx/bBZmsK2D9llsPTRTfdMYpXk4pe/li6RL6vvHQYRUOMtE/w3Z9y2F8KdspKObabqbUVnFxxnG/3UrKM4nBN3uK02UZ3C/4ia1N52LSaiJtGyFxZH9s0JZS24IlHrh3tP/VvpGlgHOwVTuBVc4tzJ63Selg8Ad5ZUobFGfuL3LtD59XrFDEP6qw2is4dsIllkCpxZNQ9WbZEcyVx3xRDr4gllsls2Q5/yRYsyY3CJcVUG337y0T8YSRyEP3JNjQSuWSIRNAD7qPau45/lStqjWCDGT+QpxiYkwRhhy5B04Q0iYPvHEdRxnuPF8nP0oOSPepIdstppQFTyVETKXRKew0I6rISPDmUx0ejx3y0LuSNjGn1SunKyNYzX7Z8gAEx/N6W1GL4dyZ88mbdsm80q7IJ53vVGj1+9EhLK257P+4XoS4ER/BJDDoFXDrmmjwkyKKvyaIRWVfA8jSQkjE101w1bg+hxZ1ST/4uIORzlVr47w3QY6ZcOywKOHQlqD+4uApqKcmPBwQ0hqF9LeYReagBK/yK0GFzki5kUja6XAlb70M0M8bQagmZ1diqLm5K2VTP4rNRVuy5vFFHPfIuwyNBh1 X-Forefront-PRVS: 02638D901B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR03MB394; 23:sqEiNkJ0WOGn4hjxPdirL4FnO6ZqWYj2eaxESq1/Yo?= jtgcIamaeG6X6UqkT2P3PbvdWc40xd8FjMRMvu+h2222sfW/otZntEywz0denWZW0Gy0WiaIrourgQCyxLHsuw9HTEXXpFZOY1vdpS2GCPDjrGkHq+ugejOyAuU04jZ+sj7hvUNzyNPISIWzyMSdURdy8MIJfgZI/5w07KsPMCoFUfZ4hYNfsIaSz5WzqqOfIrLRqzDq66ZjSpmDBcpMbl3lAwnfyzYuFFrAYl9vB2cc77zoBsAm4s597thBNBzEe2J86y2+H1kolnfDJya2kemilfQs7PUqr19KP7yXQyckk/xWMd/0hysRAqQ1LBe1+BiNofFAk5m4URPnqfSZcYfNyVi0UpQMCt69JZwBorAUnoNUUm8o+GJn8TJGmH5OV/aSnz7TCqZpm6EoHJQloK10/VhLmGs4ho79SP7xV97Nai23nFrxw2p9qYJFE3WA1mzylevXLDwETR88kJPB1emxgjSZOdeAaWxe6UZxVRgTCGwvSUD00DrAhogU6VOpadpWsRRmt3kaQqQTEQY92fDlrkLzVEzBiSL+k2PmvhDR+tXKoZ3fPaN81ceW+w6SLhZ6UUkitdoV/Ygz93fm0ITTQE0VOE1HGOepPtpY/jnfl9HY7Ix3lXXYGYxgbzcCYQFr1suRYRsXEAiNTM+lWg3ggMXd2UNZz1LN9M5YaoatjwekKTM3aLgolxsI9cqZsYGBuURJ8OaFkMyr9R+ruDsr4PazccZ1q8PDzeepbxLEurMXCKtj+5ahsrOgTrwE7pU5F4sjB0i6bLtmeRNv6IdOkW1M+oc1uy1GV6G6A80K+p7NqnfGcZHFJ4r6+AERi+tLfg/hYnj3/+baNCTLhccrQfo7W71/CxSqwcfsHoYqBMmu44fWGGBXR5aQL8GpNd2tJJtAHuHciTb1L2G6tf/8l8Zo6rvDvhb1oPC+XwQeWuFPVWxnAh610U9Y0eXBEop/lV3Cem9EkQqoDbuhE38DSR/YgO8ajMEierYzvPdcXaakpebqO1xh5VdYqzp/m1TyZ+8QY0FUAzJQ9YzGCrbJOeHJqwM7ubdonYsswPn482R2GHD70f2JBJKuEC8y7WmmHINImW0dCNZYTv+ZTTvySmV+L9y4zI9f86rikUclHofnk8daGev0cEGjOgDKVTkaws1bz3cUIQkjVO8fDA X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 6:Nw53c1yp85xhhZCemW1ZZkibiXqsC4qsQJO1zPChtpRRqPh68vz6n+MvzZwlB1yyZyEHkr766oflUEbkr6dti0oPcYa4v/Z2eJu98P7LeY2zpTlwvKiG4O1+g2Hpa3jjzaYBUxWTms2XkAnmwn1qoe3V239xmi5o+tV/lton8nlIAUdMyRzo6eXR9iHbkkbmj3CwjqzNi/w3qss63ogCV3bjVFh0soCSqX5OHJGNQYHp1yxw4AJWeZWBQcTVIrch+RSVKyqzflisq/olXtOjIT8XBH9WCVqx6rk5fWQFGBUcdIErJpXN0InXvOlVGfg6B/A6O5Yoq0dvdWuInT1cHV6PisPG17rjbzFPzLO2pJc0D6pxP3tzxy4tWNMgiUrPxVvVwk5qcNBpwwFfD3KSfw==; 5:VtZnlr/3mRpM94wagUrxxCQfRX/tAyzwpNEnr9kVrKa2PhVj9erTWHvrSNEGtZRQMittzEOFjTATODi5e5ePKNu1B4VgcjY6rD8L88LcL7MOAqP/iHXHb9NiyD6+HXi4BAjiotSXbycih+H6bLPJARNIMSrDDiG4PFeitHZCB3bjTO8QnHEX+58Xi+yRht/O; 24:csFyJkuIPEiuCKxMaWgdYjs5kg5pZ4xgYiAvcnvn+u3/vPK/9eqIndH0DIGqoVyc0tCzD1gpUenkDFhKMOJxWLpBksyQAC4eEvh3GxYX+PE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR03MB394; 7:xXUBsi14DbEffERz5JH6Pw1aSbxgSc7uNR8L5nLwIrmKcPnxw+RFKpCI3h9eInBGoKdRxpwfo8JJ9VaTIyQBT2vSKzi1+quaqNmh91sa38VkHkea6OrGKsMjIX6pbgmb82u31fwxaZeQANfCVjO21DcuD6YLEFDqz0hUgVai/OYXutycVhsWeaAu9vVSq3h1OI25C9g2D634JIKQWXTC4SZHsvVQ7K8CMcbeDmycdJMta01xESP3XcMbCgVZUcyF0wKiNp+NCN08rdbSSbSZQH3bWHb5dhSlSzkqrVhsVebyUV2kRJ7q6mzTadEv2nIVPThu6Yd4vuXBJxr7ynK6eA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2017 05:23:27.4761 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB394 Subject: [dpdk-dev] [PATCH 1/3] mempool: fix segfault for unlinked mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 449c49b93a6b ("mempool: support handler operations") In case the stack or ring mempool handler are compiled as shared library and not linked in with test binary, segfault is reported. This is because return value of rte_mempool_set_ops_byname is not being checked in rte_mempool_ops_alloc. This patch handles error returned from rte_mempool_set_ops_byname when a mempool is not found. Signed-off-by: Shreyansh Jain --- lib/librte_mempool/rte_mempool.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 40d3afd..ef7d3d1 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -868,6 +868,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size, rte_mempool_obj_cb_t *obj_init, void *obj_init_arg, int socket_id, unsigned flags) { + int ret; struct rte_mempool *mp; mp = rte_mempool_create_empty(name, n, elt_size, cache_size, @@ -880,13 +881,16 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size, * set the correct index into the table of ops structs. */ if ((flags & MEMPOOL_F_SP_PUT) && (flags & MEMPOOL_F_SC_GET)) - rte_mempool_set_ops_byname(mp, "ring_sp_sc", NULL); + ret = rte_mempool_set_ops_byname(mp, "ring_sp_sc", NULL); else if (flags & MEMPOOL_F_SP_PUT) - rte_mempool_set_ops_byname(mp, "ring_sp_mc", NULL); + ret = rte_mempool_set_ops_byname(mp, "ring_sp_mc", NULL); else if (flags & MEMPOOL_F_SC_GET) - rte_mempool_set_ops_byname(mp, "ring_mp_sc", NULL); + ret = rte_mempool_set_ops_byname(mp, "ring_mp_sc", NULL); else - rte_mempool_set_ops_byname(mp, "ring_mp_mc", NULL); + ret = rte_mempool_set_ops_byname(mp, "ring_mp_mc", NULL); + + if (ret) + goto fail; /* call the mempool priv initializer */ if (mp_init)