From patchwork Mon Mar 6 10:00:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Blunck X-Patchwork-Id: 21439 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 2C12DF958; Mon, 6 Mar 2017 11:01:45 +0100 (CET) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 1D848567F for ; Mon, 6 Mar 2017 11:00:58 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id l37so20983018wrc.3 for ; Mon, 06 Mar 2017 02:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=WpAd9Ods4s0awefruuE6LZcKn3EOTMXvWfXGBOfs6Fs=; b=hvMIaXWc2FGi5H1SeUTIQTkb8KXyI2ZV3brnOP6Lt8FkA88qGE0LP/kOjNklradN56 m9E3JKx8g0Fn8llm660bQobfuTMHndYqa1Ihlgv8VNuoP8AkkocVMaQVU2Q5/QKTRnoe BcDDIdw3TmOk+IahGqNHRUvPl9KmaJ85eWssDW0GHrOW8KPKF/iuVlw5Dk6dcMhwjcgl MNhD/xqwAovKBE6CLAqkAp3HNie1JjBHFpvGkUUf7XEs+j0/IZ4JZuYxbrGAfhYCpTNd FDMTWMLld9E5Z9jxnjKukxlXVV1e1x+z7rpEn+ZXzk8F/SxzbfEl9j2mICUfacKv24e/ VP0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=WpAd9Ods4s0awefruuE6LZcKn3EOTMXvWfXGBOfs6Fs=; b=nrXauSPaGGqTKMkrZtWTKe3GUwf3lifSkzRvXmjG3rUIIIylh9VH56MLfz6wCrWEJn J/Tq/wvlyNPNMNrtJ5Bd9YndxS1iIRnXYWnbthLSohQqi0ZTctgEQuUS36NZ3kH5z8iG 1x/KApPOLCF6QY0YJsVlBL7VEJOgg8fu6IQha0xpoL33a5FBRSfUfWJYveW0Y6OhJkYN rT0AwdCNMitL8AdpdpfH2U3mBWZvggWpLMpGE101Dap+xIY607JzklSr7idZKittZ7ba 2ItRvc/7HKzoQ271AZt3D0nUC7UV+Hn0ecXU2JjmtYIQ33Z6sEPnUWjNDCBOVcG9HhQm 7kjQ== X-Gm-Message-State: AMke39n0oivSPdaJf7ykNMNC1yvM0dImfoekIS1dlsc+ZvaS5U2tKGbh2zP3l9+Xq10ofw== X-Received: by 10.223.138.250 with SMTP id z55mr14778035wrz.130.1488794457449; Mon, 06 Mar 2017 02:00:57 -0800 (PST) Received: from weierstrass.local.net ([91.200.109.169]) by smtp.gmail.com with ESMTPSA id u145sm3829237wmu.1.2017.03.06.02.00.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 02:00:56 -0800 (PST) From: Jan Blunck To: dev@dpdk.org Date: Mon, 6 Mar 2017 11:00:03 +0100 Message-Id: <1488794430-25179-12-git-send-email-jblunck@infradead.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1488794430-25179-1-git-send-email-jblunck@infradead.org> References: <1488794430-25179-1-git-send-email-jblunck@infradead.org> Subject: [dpdk-dev] [PATCH 11/38] net/null: internalize eth_dev_null_create() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no need to export this API. Remaining users should use the rte_eal_vdev_init() function instead. Signed-off-by: Jan Blunck --- drivers/net/null/Makefile | 7 +----- drivers/net/null/rte_eth_null.c | 4 +--- drivers/net/null/rte_eth_null.h | 40 ------------------------------- drivers/net/null/rte_pmd_null_version.map | 7 ------ test/test/test_link_bonding_rssconf.c | 1 - 5 files changed, 2 insertions(+), 57 deletions(-) delete mode 100644 drivers/net/null/rte_eth_null.h diff --git a/drivers/net/null/Makefile b/drivers/net/null/Makefile index 0c909c6..80abb52 100644 --- a/drivers/net/null/Makefile +++ b/drivers/net/null/Makefile @@ -41,18 +41,13 @@ CFLAGS += $(WERROR_FLAGS) EXPORT_MAP := rte_pmd_null_version.map -LIBABIVER := 1 +LIBABIVER := 2 # # all source are stored in SRCS-y # SRCS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += rte_eth_null.c -# -# Export include files -# -SYMLINK-y-include += rte_eth_null.h - # this lib depends upon: DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_eal DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index b856073..14f35d7 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -39,8 +39,6 @@ #include #include -#include "rte_eth_null.h" - #define ETH_NULL_PACKET_SIZE_ARG "size" #define ETH_NULL_PACKET_COPY_ARG "copy" @@ -480,7 +478,7 @@ static const struct eth_dev_ops ops = { static struct rte_vdev_driver pmd_null_drv; -int +static int eth_dev_null_create(const char *name, const unsigned numa_node, unsigned packet_size, diff --git a/drivers/net/null/rte_eth_null.h b/drivers/net/null/rte_eth_null.h deleted file mode 100644 index abada8c..0000000 --- a/drivers/net/null/rte_eth_null.h +++ /dev/null @@ -1,40 +0,0 @@ -/*- - * BSD LICENSE - * - * Copyright(c) 2015 Intel Corporation. All rights reserved. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Intel Corporation nor the names of its - * contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -#ifndef RTE_ETH_NULL_H_ -#define RTE_ETH_NULL_H_ - -int eth_dev_null_create(const char *name, const unsigned numa_node, - unsigned packet_size, unsigned packet_copy); - -#endif /* RTE_ETH_NULL_H_ */ diff --git a/drivers/net/null/rte_pmd_null_version.map b/drivers/net/null/rte_pmd_null_version.map index 84b1d0f..ef35398 100644 --- a/drivers/net/null/rte_pmd_null_version.map +++ b/drivers/net/null/rte_pmd_null_version.map @@ -2,10 +2,3 @@ DPDK_2.0 { local: *; }; - -DPDK_2.2 { - global: - - eth_dev_null_create; - -} DPDK_2.0; diff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c index 1023f7f..8bd69ad 100644 --- a/test/test/test_link_bonding_rssconf.c +++ b/test/test/test_link_bonding_rssconf.c @@ -52,7 +52,6 @@ #include #include #include -#include #include "test.h"