From patchwork Wed Jan 18 09:37:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 19694 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 7F25DF947; Wed, 18 Jan 2017 10:37:56 +0100 (CET) Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 558A3F8AA for ; Wed, 18 Jan 2017 10:37:55 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id c85so236576927wmi.1 for ; Wed, 18 Jan 2017 01:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4JlQnjyrOUDajxhKINA5v7R2nznkpLgM0dLHD09/VTE=; b=A59+IokVDjv43k61uwzD3DRRasT4ld+gr7AbjqKzWuo4fYG5ZFA5+jd6m27l3Wxdoa sdaD8CRkZkF2oIZG4p5xNCiAhByKbnxaoiYBCjRdjmbQbg9ofjKAeF2rXGYqFVRPIJ3T BIlsLwP8IK7vi8OBKDyBm332xtlJEwhHU3MSxIUBjGk7brYMx+Zaad2FDTYf1TW369P8 OhoXwTsm6w1gB7RQNowUvvvEX3+KlwOH+mDujoWQWGFL16XOrUuwvMCJ0C0b3xGqHYEm LQZBYAq0rIxt7f0Qtn3a4whkMd+V+7trsdUwMEbRIRoHSCuk2a9LJMvSqhBaAFttHrw5 o6AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4JlQnjyrOUDajxhKINA5v7R2nznkpLgM0dLHD09/VTE=; b=NXaJ2m5Ox1OJoh5d5ODNzatwTX2OodeY1G+Xsym41QrBqHJ43lw+QML7Tho9LxvC7m 5WYUaznic2K4yNP7XW0crRo3pUfCZhyM5jHqxx6e2x8rE19txiobNT1lsE4AnSjXkk5J T0EWhN64FhoD360LwAGWIgGEL0LklaZBZpD30fRA+ELsKt22byE9PtScc0xZY1lLJWHT m2G+LFtyYGUm2uU5Y8+R0XCCbgjJ6vXjwWWVvcF6ieMQFEK2ALkpeykgYRKkG/oH6NhR YhbjYb+bPW033R4zXA9Mdxs0CecN8fzsuwnwj1X0PImNm9t8e8G8MGNd/Ksh0Hryruzf MhCg== X-Gm-Message-State: AIkVDXI5OtRZNNOtH408iPzbdOTjXlxRbXUE5rCq60PMUyujZVbmV7RKV7W+AcdWbsVb1FZq X-Received: by 10.223.152.210 with SMTP id w76mr2212801wrb.72.1484732275089; Wed, 18 Jan 2017 01:37:55 -0800 (PST) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u81sm3568688wmu.10.2017.01.18.01.37.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 18 Jan 2017 01:37:54 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org Date: Wed, 18 Jan 2017 10:37:52 +0100 Message-Id: <1484732272-29137-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> References: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> Subject: [dpdk-dev] [PATCH v2] devtools: relax tag checking in fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The tag "Cc: stable@dpdk.org" must be set when the commit must be backported to a stable branch. The reminder is reworded. It should be located just below the "Fixes:" tag (without blank line) and followed by a blank line, separated from SoB and review tags below. However, there is no strong need for checking blank lines. Signed-off-by: Thomas Monjalon Reviewed-by: Yuanhan Liu --- v2: relax checking and reword reminder v1: strict checking of blank lines while allowing Cc: stable --- devtools/check-git-log.sh | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index f6a35d2..62b5f43 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -170,12 +170,6 @@ bad=$(echo "$tags" | sed 's,^.,\t&,') [ -z "$bad" ] || printf "Wrong tag:\n$bad\n" -# check blank line after last Fixes: tag -bad=$(echo "$bodylines" | - sed -n 'N;/\nFixes:/D;/\n$/D;/^Fixes:/P' | - sed 's,^.,\t&,') -[ -z "$bad" ] || printf "Missing blank line after 'Fixes' tag:\n$bad\n" - # check missing Fixes: tag bad=$(for fix in $fixes ; do git log --format='%b' -1 $fix | grep -q '^Fixes: ' || @@ -198,9 +192,9 @@ bad=$(for fixtag in $fixtags ; do done | sed 's,^,\t,') [ -z "$bad" ] || printf "Wrong 'Fixes' reference:\n$bad\n" -# check CC:stable for fixes +# check Cc: stable@dpdk.org for fixes bad=$(for fix in $stablefixes ; do - git log --format='%b' -1 $fix | grep -qi '^CC: *stable@dpdk.org' || + git log --format='%b' -1 $fix | grep -qi '^Cc: *stable@dpdk.org' || git log --format='\t%s' -1 $fix done) -[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n" +[ -z "$bad" ] || printf "Is it candidate for Cc: stable@dpdk.org backport?\n$bad\n"