From patchwork Tue Jan 17 14:53:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 19620 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D64352B83; Tue, 17 Jan 2017 15:53:13 +0100 (CET) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 204D02A62 for ; Tue, 17 Jan 2017 15:53:12 +0100 (CET) Received: by mail-lf0-f46.google.com with SMTP id k86so109628659lfi.0 for ; Tue, 17 Jan 2017 06:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=q0Vl1wWsfOTq34bjJG/n6692dmVpcbq7hJXKbVDAv8Y=; b=IQXaAzrr7OwQqVypD4sEmje1YP+bwCsf8Jhv1S5dWSI1+LqWErZRRHjFUTFR4bbWQR g/pVziPjuRp6howRxKO9SECu1sRYotcuTpuCPKsaPm7AnZIuqOPgkklubkTvsbVm8ayl b6ZX4+4tBdlQJ4APm9DP28nsfeC1IS9Z2bBaMtJ2jVRpRe7wBl//ZsYM18q4yzp0Wp61 5Uv6RTc9Imt9BLwT3nAdSkx5Iqcp2WzWfff0Fx3CyJLzjhVuYvb6jpkKjEiLA3cTX8Kk LJIq2BX9i8j7Hbwd0Qx4eMmQyujumCPazrXqJENIW9umH8zY6uwZuVbnysPFIMWlYxvu 98bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=q0Vl1wWsfOTq34bjJG/n6692dmVpcbq7hJXKbVDAv8Y=; b=pU+iqhzxDS49YrteH7Nwhm6PcKRB5u93Vnpy3Okc0GH3DaVD88y3aOQnOed554KGGZ w2G7Y/yLz0vtr8XjiEQV7Ks0Uae6PxQfiWI1lU8m66pgeTQvNeItz4A1xaQYqK5+sISv szZSnHqqHhyjlxx+EDqeoSnzOeS0Yi4fMichlWHfuvtTGFMFsZOTUX/fAwRxE8UZgoYB 4+wYGY9bbZbLb77fyjcdp4rBpe7pEqZhgAW3dKu8a3NeaetyTuBS2rdbxlBoZA9VjLhU E6Eap3SvsO3wcuLkrOjwe6g4N33dPWKbbU1D+hjmJLafu8Q+XCWiJVCSzJVBuxsjSAte ciZQ== X-Gm-Message-State: AIkVDXIszgRdSoxdeKYZR5TTOvvvaXExhvgb5rSbrzETC03vn4MoltRaRbOJUU4Qxq2BuZI+ X-Received: by 10.25.158.147 with SMTP id h141mr6544262lfe.160.1484664791465; Tue, 17 Jan 2017 06:53:11 -0800 (PST) Received: from XPS13.localdomain (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v2sm910311ljb.44.2017.01.17.06.53.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Jan 2017 06:53:10 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 17 Jan 2017 15:53:05 +0100 Message-Id: <1484664785-26788-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH] devtools: fix lookup commit fixing a fix of many commits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was a bug when looking at a commit fixing a commit which itself was fixing many commits: % devtools/git-log-fixes.sh 12ee45a36~..12ee45a36 devtools/git-log-fixes.sh: 96: local: 5499c1fc9baa: bad variable name In this case, the list of commits was not quoted in variable assignment. Signed-off-by: Thomas Monjalon --- devtools/git-log-fixes.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh index 4824c7f..d590735 100755 --- a/devtools/git-log-fixes.sh +++ b/devtools/git-log-fixes.sh @@ -90,7 +90,7 @@ origin_version () # ... git rev-parse -q --verify $1 >&- || continue # get version of this bug origin local origver=$(commit_version $origin) - local roothashes=$(origin_filter $origin) + local roothashes="$(origin_filter $origin)" if [ -n "$roothashes" ] ; then # look chained fix of fix recursively local rootver="$(origin_version $roothashes)"