From patchwork Fri Dec 2 07:41:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 17387 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 5796EFA33; Fri, 2 Dec 2016 08:42:54 +0100 (CET) Received: from nbfkord-smmo04.seg.att.com (nbfkord-smmo04.seg.att.com [209.65.160.86]) by dpdk.org (Postfix) with ESMTP id 078ED68A5 for ; Fri, 2 Dec 2016 08:42:21 +0100 (CET) Received: from unknown [12.187.104.26] (EHLO webmail.solarflare.com) by nbfkord-smmo04.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id ed521485.2b8154cb3940.1033553.00-2431.1126912.nbfkord-smmo04.seg.att.com (envelope-from ); Fri, 02 Dec 2016 07:42:22 +0000 (UTC) X-MXL-Hash: 584125de34c227fa-7a162fbda00ddcb33d50db45572d551d96d003d6 Received: from unknown [12.187.104.26] (EHLO webmail.solarflare.com) by nbfkord-smmo04.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id ec521485.0.1033197.00-2373.1126538.nbfkord-smmo04.seg.att.com (envelope-from ); Fri, 02 Dec 2016 07:42:07 +0000 (UTC) X-MXL-Hash: 584125cf5f04377a-45ab3b129b12cb9e812b0c38066654a26dfadf42 Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 1 Dec 2016 23:42:03 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25 via Frontend Transport; Thu, 1 Dec 2016 23:42:03 -0800 Received: from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com [10.17.10.10]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id uB27g2Iv005702; Fri, 2 Dec 2016 07:42:02 GMT Received: from uklogin.uk.solarflarecom.com (localhost.localdomain [127.0.0.1]) by uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id uB27fZXu026464; Fri, 2 Dec 2016 07:42:02 GMT From: Andrew Rybchenko To: CC: Ivan Malov Date: Fri, 2 Dec 2016 07:41:21 +0000 Message-ID: <1480664481-26427-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1480664481-26427-1-git-send-email-arybchenko@solarflare.com> References: <1480664481-26427-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-AnalysisOut: [v=2.1 cv=TYuQwEkh c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==] X-AnalysisOut: [:17 a=n5n_aSjo0skA:10 a=pK7X0mNQAAAA:8 a=zRKbQ67AAAAA:8 a=] X-AnalysisOut: [sJ7lo5_aL9YDCf_HnusA:9 a=5HA-qpC1VU4iIGLgRoNS:22 a=PA03WX8] X-AnalysisOut: [tBzeizutn5_OT:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [12.187.104.26] Subject: [dpdk-dev] [PATCH 2/2] net/sfc: restart TxQ in case of exception on its event queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ivan Malov Examples of recoverable exceptions because of Tx error are: - Tx descriptor PCI read error - invalid Tx option descriptor - Tx option descriptor not supported by the firmware variant - unexpected Tx option descriptor (e.g. missing FATSO2A before FATSO2B, missing FATSO2B after FATSO2A) - incomplete packet push (CONT bit set in the latest pushed DMA descriptor) Reviewed-by: Andrew Lee Reviewed-by: Robert Stonehouse Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c index 36aede8..af3c7b2 100644 --- a/drivers/net/sfc/sfc_ev.c +++ b/drivers/net/sfc/sfc_ev.c @@ -339,6 +339,20 @@ sfc_ev_qpoll(struct sfc_evq *evq) rxq_sw_index); } + if (evq->txq != NULL) { + unsigned int txq_sw_index = sfc_txq_sw_index(evq->txq); + + sfc_warn(sa, + "restart TxQ %u because of exception on its EvQ %u", + txq_sw_index, evq->evq_index); + + sfc_tx_qstop(sa, txq_sw_index); + rc = sfc_tx_qstart(sa, txq_sw_index); + if (rc != 0) + sfc_err(sa, "cannot restart TxQ %u", + txq_sw_index); + } + if (evq->exception) sfc_panic(sa, "unrecoverable exception on EvQ %u", evq->evq_index);