From patchwork Mon Nov 21 22:42:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 17172 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id DA5232A5D; Mon, 21 Nov 2016 23:43:07 +0100 (CET) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 64D4F29D6 for ; Mon, 21 Nov 2016 23:43:06 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id g23so7123828wme.1 for ; Mon, 21 Nov 2016 14:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=fCx55luXamQwpoSNneCADtDYFKaYq2DP0lqZV5kK8hk=; b=scOacqc2idgqvoR/m5CCDUOiyB7hca4FCINXrF5xXQcmOFmJ/HvDt6FZgDblVMC8oJ FwXGC0zTreIPfFGQC2bGkmNzOXYJ+fa1qW01t9MJ2tmy9yk1g07zao4QGIZneoZ78QX7 S/pFAuCxASUITHtfpbBB3GTQG7a27Y2zfN8a7qOlGTZS+scR+zgDtdluwAsM+JKKMLRV /WY3OLnh+oDWYLcbgt0HJR5+Fm/03uhqPefrPSDDC7eFtD2lnVD5Mjl6ORUOiYWWNrat kmaIqQ9OPRjx9pVvYB/L9Mq2RvUw964S5VWLMAwB4Mlh6FJGNqH7UL/nPHTpH8PQzHVA K4OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=fCx55luXamQwpoSNneCADtDYFKaYq2DP0lqZV5kK8hk=; b=c5dFze6yHqwocZUZZXKMWdllcukQzV3DZ6VCCgsabCZlQHSUyz20/hnfqDhW1J5Ow1 TMEXlR4MB3s98BtRwZ+JLKn3jb/F/HH5Wvhz9MMCZkchJmqD4jUoYSTJ2QCLYNHO5JbI B7E65tGd1KszbGCODpRbnyqY0MDxqBeMtiUuYMyrpct9TisDwfBdzNIC6XB+zNv6b1ei 1TOCIbxlEsV5JYJddnaBDNcXmQmCkm2al199AiX2nTOjpF6RcDPlZ++YwNIi10zXnngl ICUXFStIhmtmASXMf1W34Fa/b+EZ5KSmbnRgfa8xW3bBhCuaCAAI4t2E6+x7e8qKDno4 IJaA== X-Gm-Message-State: AKaTC02D1gz6Imd2FQ86gipN1/v62Suu5aUZVCvR1mD3RozFD0TNzTE97njC3BV8dmO6V5Ar X-Received: by 10.28.6.203 with SMTP id 194mr17353490wmg.16.1479768183733; Mon, 21 Nov 2016 14:43:03 -0800 (PST) Received: from XPS13.localdomain (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id v202sm21946257wmv.8.2016.11.21.14.43.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Nov 2016 14:43:02 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Mon, 21 Nov 2016 23:42:41 +0100 Message-Id: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH] scripts: fix checkpatch from standard input X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When checking a valid patch from standard input, the footer lines of the report are not filtered out. The function check is called outside of any loop, so the statement continue has no effect and the footer is printed. Fixes: 8005feef421d ("scripts: add standard input to checkpatch") Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz --- scripts/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh index 336cc7b..cfe262b 100755 --- a/scripts/checkpatches.sh +++ b/scripts/checkpatches.sh @@ -94,7 +94,7 @@ check () { # else report=$($DPDK_CHECKPATCH_PATH $options - 2>/dev/null) fi - [ $? -ne 0 ] || continue + [ $? -ne 0 ] || return 0 $verbose || printf '\n### %s\n\n' "$3" printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p' status=$(($status + 1))