diff mbox

[dpdk-dev] examples/ip_pipeline: fix load balancing function in pass-through pipeline

Message ID 1479735457-147785-1-git-send-email-jasvinder.singh@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
checkpatch/checkpatch success coding style OK

Commit Message

Jasvinder Singh Nov. 21, 2016, 1:37 p.m. UTC 
  This patch fixes the configuration file parsing error when load balancing
function is enabled in pass-through pipeline.

error log:
pipeline> [APP] Initializing PIPELINE1 ...
[PIPELINE1] Pass-through
Parse error in section "PIPELINE1": entry "lb" has invalid value ("hash")

Fixes: cbe82f6cfb0a ("examples/ip_pipeline: add swap action in pass-through")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/ip_pipeline/pipeline/pipeline_passthrough_be.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cristian Dumitrescu Dec. 28, 2016, 6:49 p.m. UTC | #1 
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, November 21, 2016 1:38 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix load balancing function in pass-
> through pipeline
> 
> This patch fixes the configuration file parsing error when load balancing
> function is enabled in pass-through pipeline.
> 
> error log:
> pipeline> [APP] Initializing PIPELINE1 ...
> [PIPELINE1] Pass-through
> Parse error in section "PIPELINE1": entry "lb" has invalid value ("hash")
> 
> Fixes: cbe82f6cfb0a ("examples/ip_pipeline: add swap action in pass-
> through")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/ip_pipeline/pipeline/pipeline_passthrough_be.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thomas Monjalon Jan. 17, 2017, 5:31 p.m. UTC | #2 
> > This patch fixes the configuration file parsing error when load balancing
> > function is enabled in pass-through pipeline.
> > 
> > error log:
> > pipeline> [APP] Initializing PIPELINE1 ...
> > [PIPELINE1] Pass-through
> > Parse error in section "PIPELINE1": entry "lb" has invalid value ("hash")
> > 
> > Fixes: cbe82f6cfb0a ("examples/ip_pipeline: add swap action in pass-
> > through")
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c b/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c
index 8b71a7d..7ab0afe 100644
--- a/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c
+++ b/examples/ip_pipeline/pipeline/pipeline_passthrough_be.c
@@ -589,7 +589,7 @@  pipeline_passthrough_parse_args(struct pipeline_passthrough_params *p,
 				params->name, arg_name);
 			dma_hash_lb_present = 1;
 
-			if (strcmp(arg_value, "hash") ||
+			if (strcmp(arg_value, "hash") &&
 				strcmp(arg_value, "HASH"))
 
 				PIPELINE_PARSE_ERR_INV_VAL(0,