From patchwork Thu Nov 17 17:16:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Blunck X-Patchwork-Id: 17077 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id BCB6D5686; Thu, 17 Nov 2016 18:16:50 +0100 (CET) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 80891558A for ; Thu, 17 Nov 2016 18:16:32 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id a20so23260368wme.2 for ; Thu, 17 Nov 2016 09:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z8j0bRNDcQUmuv8Rwsem2brCLUxDxY1oBiQQQbGno5c=; b=YL7DNYV/CMa2V7PUo3whmXxxurz1Ljxxw5HvXDFc0X9Q+cq3sk+Zd2k9LAltEioRAd pntxd0viCaZg9coWYXVpmNqUoTEXyhTc18nk/kwyKhTHax7PqtNc5fncMfhswLFrEv4T +egv4badDj4P6POxSfLmGztOO1ZjhpDxgxCzUkbQSo1SOghFPY3mqBc7h4DyJwDRtC+6 K1fHwJUJe2ycxORF0la8YsLCN/hlmFGCY7hZzPxflynwZ36C6FqosKlJoK4SZG/0CBB8 zCG3zTa7weYpAjePotbOcLy+VcakLSBL9vMUVETKbMGF4ao+rg9thO0mGEVk//CltG9F zs/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Z8j0bRNDcQUmuv8Rwsem2brCLUxDxY1oBiQQQbGno5c=; b=b+2YSdHy42Fhu26+7KuK9wdbvqrZgmjc6l/a0+mKof+e3j0vpybZh51eBKkQiuhoFo iLFW7uj3Eer3CstNG7GBBH1Dc2pQgjkmXj9ki/XFwe6Dcrm9Ucv4sCVGGtwiQRaSsHLn FfkMYspQ4IMtYsHsj9ZTXJdD47lcK09KQSJ5dddMOG+6GhGh0qeL1Tnj/+Q98BucbVmB 5FcP1Xp4W5gM2GotDvsSeoI3CWqhQ9rSlUbxFaAP20CxA0eErnb+uTlFN42eUxC/l0un BPbGZkrQKQhxvBsqv2OFw7f3e13DTg11Ccz4u3xkpw5V/gGG9YHDJKGQYt5K4qNIAtVW 2iCQ== X-Gm-Message-State: AKaTC01pbnvoAaAXqw3qj4l3IPJa4WRKGnBUfuPN8hg3vLGbE7MkhH9k4qrDV0W4N7EWwQ== X-Received: by 10.194.36.70 with SMTP id o6mr2826938wjj.45.1479402991960; Thu, 17 Nov 2016 09:16:31 -0800 (PST) Received: from weierstrass.local.net ([91.200.110.70]) by smtp.gmail.com with ESMTPSA id f67sm16672684wmd.13.2016.11.17.09.16.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 09:16:31 -0800 (PST) From: Jan Blunck To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 17 Nov 2016 18:16:12 +0100 Message-Id: <1479402972-27470-2-git-send-email-jblunck@infradead.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479402972-27470-1-git-send-email-jblunck@infradead.org> References: <1479402972-27470-1-git-send-email-jblunck@infradead.org> Subject: [dpdk-dev] [PATCH v2 2/2] Move non-PCI related eth_dev initialization to rte_eth_dev_allocate() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This moves the non-PCI related initialization of the link state interrupt callback list and the setting of the default MTU to rte_eth_dev_allocate() so that drivers only need to set non-default values. Signed-off-by: Jan Blunck Reviewed-by: Ferruh Yigit --- app/test/virtual_pmd.c | 2 -- drivers/net/bonding/rte_eth_bond_api.c | 2 -- drivers/net/cxgbe/cxgbe_main.c | 2 -- drivers/net/mlx4/mlx4.c | 2 -- drivers/net/mlx5/mlx5.c | 3 --- drivers/net/null/rte_eth_null.c | 2 -- drivers/net/ring/rte_eth_ring.c | 2 -- drivers/net/vhost/rte_eth_vhost.c | 2 -- lib/librte_ether/rte_ethdev.c | 11 +++-------- 9 files changed, 3 insertions(+), 25 deletions(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 65b44c6..bd969f9 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -601,8 +601,6 @@ virtual_ethdev_create(const char *name, struct ether_addr *mac_addr, eth_dev->data->nb_rx_queues = (uint16_t)1; eth_dev->data->nb_tx_queues = (uint16_t)1; - TAILQ_INIT(&(eth_dev->link_intr_cbs)); - eth_dev->data->dev_link.link_status = ETH_LINK_DOWN; eth_dev->data->dev_link.link_speed = ETH_SPEED_NUM_10G; eth_dev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX; diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index ed75c28..19347d8 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -200,8 +200,6 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id) eth_dev->data->nb_rx_queues = (uint16_t)1; eth_dev->data->nb_tx_queues = (uint16_t)1; - TAILQ_INIT(&(eth_dev->link_intr_cbs)); - eth_dev->data->mac_addrs = rte_zmalloc_socket(name, ETHER_ADDR_LEN, 0, socket_id); if (eth_dev->data->mac_addrs == NULL) { diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c index 922155b..9e8402b 100644 --- a/drivers/net/cxgbe/cxgbe_main.c +++ b/drivers/net/cxgbe/cxgbe_main.c @@ -1172,8 +1172,6 @@ int cxgbe_probe(struct adapter *adapter) rte_eth_copy_pci_info(pi->eth_dev, pi->eth_dev->pci_dev); - TAILQ_INIT(&pi->eth_dev->link_intr_cbs); - pi->eth_dev->data->mac_addrs = rte_zmalloc(name, ETHER_ADDR_LEN, 0); if (!pi->eth_dev->data->mac_addrs) { diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 9264242..d815a52 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -5834,7 +5834,6 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) eth_dev->rx_pkt_burst = mlx4_rx_burst_secondary_setup; } else { eth_dev->data->dev_private = priv; - eth_dev->data->mtu = ETHER_MTU; eth_dev->data->mac_addrs = priv->mac; } eth_dev->pci_dev = pci_dev; @@ -5845,7 +5844,6 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) priv->dev = eth_dev; eth_dev->dev_ops = &mlx4_dev_ops; - TAILQ_INIT(ð_dev->link_intr_cbs); /* Bring Ethernet device up. */ DEBUG("forcing Ethernet interface up"); diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index b57cad1..0e91f02 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -652,7 +652,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) eth_dev->rx_pkt_burst = mlx5_rx_burst_secondary_setup; } else { eth_dev->data->dev_private = priv; - eth_dev->data->mtu = ETHER_MTU; eth_dev->data->mac_addrs = priv->mac; } @@ -662,8 +661,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) priv->dev = eth_dev; eth_dev->dev_ops = &mlx5_dev_ops; - TAILQ_INIT(ð_dev->link_intr_cbs); - /* Bring Ethernet device up. */ DEBUG("forcing Ethernet interface up"); priv_set_flags(priv, ~IFF_UP, IFF_UP); diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 836d982..f09caf1 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -550,8 +550,6 @@ eth_dev_null_create(const char *name, eth_dev->data = data; eth_dev->dev_ops = &ops; - TAILQ_INIT(ð_dev->link_intr_cbs); - eth_dev->driver = NULL; data->dev_flags = RTE_ETH_DEV_DETACHABLE; data->kdrv = RTE_KDRV_NONE; diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index c1767c4..c7726f4 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -346,8 +346,6 @@ do_eth_dev_ring_create(const char *name, data->drv_name = drivername; data->numa_node = numa_node; - TAILQ_INIT(&(eth_dev->link_intr_cbs)); - /* finally assign rx and tx ops */ eth_dev->rx_pkt_burst = eth_ring_rx; eth_dev->tx_pkt_burst = eth_ring_tx; diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 766d4ef..1912346 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1032,8 +1032,6 @@ eth_dev_vhost_create(const char *name, char *iface_name, int16_t queues, if (vring_state == NULL) goto error; - TAILQ_INIT(ð_dev->link_intr_cbs); - /* now put it all together * - store queue data in internal, * - store numa_node info in ethdev data diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 12af4b1..1def33e 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -215,6 +215,9 @@ rte_eth_dev_allocate(const char *name) memset(eth_dev->data, 0, sizeof(*eth_dev->data)); snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name); eth_dev->data->port_id = port_id; + eth_dev->data->mtu = ETHER_MTU; + TAILQ_INIT(&(eth_dev->link_intr_cbs)); + eth_dev->attached = DEV_ATTACHED; eth_dev_last_created_port = port_id; nb_ports++; @@ -261,14 +264,6 @@ rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv, eth_dev->pci_dev = pci_dev; eth_dev->driver = eth_drv; - /* init user callbacks */ - TAILQ_INIT(&(eth_dev->link_intr_cbs)); - - /* - * Set the default MTU. - */ - eth_dev->data->mtu = ETHER_MTU; - /* Invoke PMD device initialization function */ diag = (*eth_drv->eth_dev_init)(eth_dev); if (diag == 0)