From patchwork Thu Nov 17 14:24:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Blunck X-Patchwork-Id: 17074 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 605435587; Thu, 17 Nov 2016 15:25:14 +0100 (CET) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 77FFC5587 for ; Thu, 17 Nov 2016 15:25:12 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id a20so21807038wme.2 for ; Thu, 17 Nov 2016 06:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id; bh=Iyi6DJdeDtjc4eULs9QXghwmnMMSibvHSCoKwpWgnfk=; b=HcikQSnnjVXyIbJfr9I5S+OQ4RCxdoZmeC8/PywisVxxj+iRBs9Fjvm2xQwvj3NeIp +rjBxHkNBlqd9KEtknC+7yUGbbyqonmTrbIeYpxnjjPEMc53CPc4iKs8EAAOKB4aHbhy 05iIalQP6hlNRvmakP2940W1g+OTAPU7hnvuRXtM9tMH94eJBo7981L34i4oXWgQKKM6 pSMkMgpaQUNzps0pPUiN0eFDUs0VINOnEQfB+NVmp7IXWolzwzooznuw2naRJCt5Dxrv YPC+TFhdHOrzmSn0gSeLO+MZjW5hGqMrG7akuvjidbuZR1mW3YAKFZhCES4Hvl4LU5ff AZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=Iyi6DJdeDtjc4eULs9QXghwmnMMSibvHSCoKwpWgnfk=; b=kds0UEo3ZNWBmBTLVD0t5RFaYFrJ05iKdOGm9EyaTqCPJ2lx7WX6bdX+sq1rKG6aUj GP+lrjRCB8WSOny8oWOIv6ZQufPWYFoE06jnQNOMs5TFVS5ivwke416VXE6FO6bmLvdH LY6ac5B7gsdwVaKRHSYZd0HPWvnivENJ92mgM0BISytMe/uy/OetYFEj1TZz8QDgX/1d YQKvorMwvn+SleFJReDCKSzTgwa9v8uhSzi8Nxdx4PyQTbr0ruR/rNXDAeOsERH/G3/o klcEs04nLUb5uKx1zdSIlq/HzEy7d6QSu09nsFf9l1T165LbH4GxrueBe3DN1F48mknq rrwQ== X-Gm-Message-State: ABUngvd3o/sGBVbntM7MDy6gQp11Bh5/GYGnm5MiBFm9cVrHztoA0ydMMalU4y/9qxAoaw== X-Received: by 10.28.236.205 with SMTP id h74mr16065782wmi.104.1479392711999; Thu, 17 Nov 2016 06:25:11 -0800 (PST) Received: from weierstrass.local.net ([91.200.110.70]) by smtp.gmail.com with ESMTPSA id kq7sm3512737wjb.30.2016.11.17.06.25.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 06:25:11 -0800 (PST) From: Jan Blunck To: dev@dpdk.org Date: Thu, 17 Nov 2016 15:24:44 +0100 Message-Id: <1479392685-19608-1-git-send-email-jblunck@infradead.org> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 1/2] Clear eth_dev->data in rte_eth_dev_allocate() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Lets clear the eth_dev->data when allocating a new rte_eth_dev so that drivers only need to set non-zero values. Signed-off-by: Jan Blunck --- drivers/net/mlx4/mlx4.c | 1 - drivers/net/mlx5/mlx5.c | 1 - lib/librte_ether/rte_ethdev.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index da61a85..9264242 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -5834,7 +5834,6 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) eth_dev->rx_pkt_burst = mlx4_rx_burst_secondary_setup; } else { eth_dev->data->dev_private = priv; - eth_dev->data->rx_mbuf_alloc_failed = 0; eth_dev->data->mtu = ETHER_MTU; eth_dev->data->mac_addrs = priv->mac; } diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 90cc35e..b57cad1 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -652,7 +652,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) eth_dev->rx_pkt_burst = mlx5_rx_burst_secondary_setup; } else { eth_dev->data->dev_private = priv; - eth_dev->data->rx_mbuf_alloc_failed = 0; eth_dev->data->mtu = ETHER_MTU; eth_dev->data->mac_addrs = priv->mac; } diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index fde8112..12af4b1 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -212,6 +212,7 @@ rte_eth_dev_allocate(const char *name) eth_dev = &rte_eth_devices[port_id]; eth_dev->data = &rte_eth_dev_data[port_id]; + memset(eth_dev->data, 0, sizeof(*eth_dev->data)); snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name); eth_dev->data->port_id = port_id; eth_dev->attached = DEV_ATTACHED; @@ -259,7 +260,6 @@ rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv, } eth_dev->pci_dev = pci_dev; eth_dev->driver = eth_drv; - eth_dev->data->rx_mbuf_alloc_failed = 0; /* init user callbacks */ TAILQ_INIT(&(eth_dev->link_intr_cbs));