From patchwork Tue Nov 15 19:11:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 17020 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9092947CD; Tue, 15 Nov 2016 20:12:02 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0083.outbound.protection.outlook.com [104.47.36.83]) by dpdk.org (Postfix) with ESMTP id 27D05378E for ; Tue, 15 Nov 2016 20:11:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=i/911QbR5vMkgrN5G8Tqk9mgFELRUQMT4T/mgbska3Y=; b=Ql05ruZt/uppvOjLyD66vnvC4qM9mSvE+DDttWNcTpBXw5VMMTrAXN98NMcMGg/QYraYsQ6/s9y9+JIHhHrwiR0Rs7KQBnTDk9nE2IoiSWQoUFSJRSOUErBYfjyJ00nQMK9mzjXwmastCwgeYs/Sdv0/Y56+FF3LA6vpUr7Xaj4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from svelivela-lt.caveonetworks.com (50.233.148.156) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Tue, 15 Nov 2016 19:11:55 +0000 From: Jerin Jacob To: CC: , Jerin Jacob Date: Wed, 16 Nov 2016 00:41:43 +0530 Message-ID: <1479237103-7166-1-git-send-email-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.5.5 MIME-Version: 1.0 X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: CY4PR02CA0047.namprd02.prod.outlook.com (10.175.57.161) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:fF2qGRpD3FU2dNqrryKGTNY/iME07NAA3h3L+ggf+jz2b5FYaWgk+1rYOBOTdxfGjYtyVy5MlYKsLszfK2dCqKBoHTd9CvBiPmdFUE0PWWo+gpucOsQQ9RM0wZtaw6LSX+xqtwZkzi1nyJR/Yjlaa/NYLujktqML488Z8gifJn0=; 3:XX44BSyPY3UH3ldNiBEl48eJg0ry3j0KupmMb83mGYSEwHdjYtT4dqsd+ZXlbCt+wrlVOiCPpOCVmSgSR5ZACk1ddeKzCfHSe4KWM8oIdgSgkyx5gvSRYhVx9dMneINO+p+gk1tb3vZOON7sstpLoNmEOk74DwKClDpvCXrlEdE=; 25:11zuwqMkYkKobE3fdq7ayqK4dkBwr0zKHp+/WY0Cd98PJra3jP50qXKGDW8mUSPtcEi9CTxMjDJ7OGQI1gyuiGrR8rFn8k2CkH3/8u/XS308utcgDFTh3a1i6MNeS6oZLRxGkwTDfCBpdwXnExUkj/jcfcdYMSFJitpy9fg7IrFHVxjuVRlugQxG5hCol/JeAal8zZHRVoynNTWA6rlkVrHPccC4lD7Ghdv3b0hUk9w2qXnqd8uSgosCQTcER6CczCSW3J4YpapTSK6blq86hEqCdlgsvwoHzyTTNVwoEUi3cmZnaB5ONxnAkbV8d+g21P6M5SS+x8P/NP/y6/1aT4Qto5ZQjmmFnyqz+qbMNLSiWvsym8Zhokg6Cv1ohVw1WQr3Oq/OC3rBgvuydZ5ayqrgJmnxDrugrm6PBZkh8etJ9/zJXUu1tk0/+YbYZhcifhIojAmurVV7GeRlBWCheQ== X-MS-Office365-Filtering-Correlation-Id: b6426bfa-99a3-485c-7a73-08d40d8b4430 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 31:hBAHUmRReyZL/pU/E39kMbDVgmm19lr9bB2tf+fVSOjnDCEvj5IxfN9m/DEtDphFK/WvV/LXXxqFbrcZ/Ts82FckAzOkHCgiVBuelVVQOQuNqAkaKerqGyon13Mjfu3A5tf4lmmRyeoCK++RPLjip2mS0fou9fABYfJF7htgV6oc5LdT7y2A2aNZoVWA5xKTzq/jh+Myh8x4bkjB6e8Tv/z7sv5UTgqbLVCM4cm5UjPE2webHnVz/6x/K0uEmXOjR1Qy/Sv13qHvSzskwaOuIKMPwDNbqKSf3/oj6YpRQ6s=; 20:59iHUsyvjwxH+kkik4vUD1LOBcqBiMePiR0Y9fo8QnI/Pfy6Gw795psWC2eAqyC/M2qUxWctjyGAIlAgJneRuBaW+wa/FVBvmFVL76nIJ/zr3ZwP6qii39eUcePKqlS/OA6cUZ5WpQdwButZq/B2iR+jd8yv8J/AuKX5PLbdP8ms6+61k03acFWCVcdHVDqYQ/W27tdcUbBp/S289DGpQpy2EpXiwBQAHY6Fh5l70e5DTovc6caym34b9vusIYpteBSdt+MuIKXEiULSlLut+3MkjQLiT+09E+D1BxSfQJH0OWW7o5BofwsRiVI9cvU3PyEAZFVo5varvbQUW648SbjkbmbU9109Q0pwMpOTHc3YVVRpJagbLO++3unqzNbYvyJsrg8gYenN6m0+VyvUJ2G5PsG1uGpFmjlkB8ZU64TV2HpBYCGi46z0sU7FoNvJgBp1sRj/8f+EZBT7JnUCd0MYDREDg38+JlM6JXJ4i2Svt4NEb89lWdMFszwgR+30c0eUMl+xR3ffHTWPlLThB0vlxUloT7B2P1xTnbBZFEV/JuvqEwNywKgtMT8YrB0BxUVU46kwjcDUs2hTJKr5ifkv/bzNuGldmnQCwnegOcA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6060326)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6061324); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:GGl4blmbR+PEEgnoBSLUJ3T7FK0zRSd8n8oW2TwcUXYST5eLzYjWtKuepcosExx8MkggcXpzyf+aKPL2OlBaHgfAh4hkgQyPQm13PaO4wFSVnRf8bbCsFWwz1/AA/oFo1IgUTcuqinb3Vr9ZnpjWSrkoMsYaKOSPiMjQFDjhq23W468Csc8OOpf5x9bCTgEiBgQVWSkRMVesSaCQnDAYgZJudMMUe/pJAEj02aU+WHEp5qMioSOqLiJ1CAak7Wf2iyJA/o+LqxkBBgwHyQ8KDJhFLD3gkDW1l4F+tv5+NoO/+7NNNFwX/nY9ufTVjhKEMGCU2QKF7eEls0wIPZ6dbiBsNySBFM2OvUl+nGDejCRV5d4HBKB5XoHnXVDdv4Fw1t5/N7uTPkl1qouFjoHzdgapl35Ph/whON9mUPoN1z4= X-Forefront-PRVS: 012792EC17 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(81166006)(2906002)(5660300001)(97736004)(81156014)(69596002)(33646002)(53416004)(47776003)(50986999)(77096005)(42186005)(92566002)(48376002)(50466002)(101416001)(66066001)(42882006)(6666003)(4326007)(6916009)(36756003)(105586002)(110136003)(189998001)(305945005)(106356001)(50226002)(5890100001)(3846002)(4001430100002)(8676002)(2351001)(7736002)(7846002)(5003940100001)(68736007)(107886002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:svelivela-lt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:Cw/UdW+dO3Oc7Qo38TAYusbERXKgCgsbN+I/lSh?= =?us-ascii?Q?3c/8GIppXTX0tR3I+TOYpTC3+lXbDGYZ7555xr4YGKboQ9NVYFMsDZtnkzCE?= =?us-ascii?Q?I1kM3482cR6YYIzRiw/mVyhwkkdwwjJVHU+KQpJV568LmX987CmvhsWtAe8c?= =?us-ascii?Q?9ahf+t8zz+ARazyNxg6wlsV4YvkbMTrha9+68sSsaDKVs3AKNJhkvpuD6noK?= =?us-ascii?Q?ByKvG18JH8Lh9yuMtRR7gEN8P1UMNybi+52lHMfFEtc5xyTcW4KXkM2a/TOb?= =?us-ascii?Q?KliFn71UsYcKJnAB96y1xJqQc5bVyKN6/hBTI4j1HvxmtuJB9d32stKEY8q7?= =?us-ascii?Q?bjiW9GLEfy9uqwVpKiH2YlpOx+7S1egO0SA9EGMh1bVosi3jJabi1OsXpuZl?= =?us-ascii?Q?s30kV0Rj+PyhkKGY0ds2b7CiAN6ycaw44EpIVDulSZfMov4I7k7dUXlpgxPq?= =?us-ascii?Q?nla17z/Gz7zif3zFhKFCZPe0VkrXSil8kYlMOmX0SPT8C2E8hiKdW6J5RS3Q?= =?us-ascii?Q?gKoTdNGSTLUbH/X0P+ZOIc7crmPOwBEWLzg5vEXsKnfuuzjB92o+ZcN0UncW?= =?us-ascii?Q?nLEsq8cU28/RlOuexyZGjL+BRI9PhNDuekZBPSNyNuSGfPp2PeYO8QBIjNL/?= =?us-ascii?Q?JI22ESTzJGvoruf7nPLEyCmdZxBJOEwGONmZl24TdDI9wecMkTecQtudZcTr?= =?us-ascii?Q?lylCyrV+43ODVkOOGAUy9ninsxF4CS98SOI/toTqeEjEsgKAxz/AldUYDwkS?= =?us-ascii?Q?3IqS2redus5251wgT67eD3y5y1d6KlnDvQ/uoOatl3frpky7zSQprKFyB1gT?= =?us-ascii?Q?n1ohNMNP1MqhWMIuc8JOMzAKOPXLJQC14X44qgVgkqZIfDDaYsIz4qgB2+ZL?= =?us-ascii?Q?mz+vvJ3gA5SZxw8+XZmqEHnHW844ou6J9Blsfi9vnF39rDL39AHplzp90U6e?= =?us-ascii?Q?EdsFFD07rYdzwlDdl0bCTJEpFXkWJGzUU5iim3CILbYedmolme6OUlHLIJjf?= =?us-ascii?Q?+8ZcY90cIEA5GiJS5pZsVjdsm2PGDsQXpXmuxaAQ+7dSpl+B2WSZfLuSE1ic?= =?us-ascii?Q?AAPeZxSHC0wwFCpEMvbb1fEzJmOU9aDL0ax26lbItH6ra4W6uDB2+Oc1rDI1?= =?us-ascii?Q?LdYYCBOq1o9Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 6:6i7TvXZTB/k+oOYQm12zx3w2iaDmjUTgX4iwwSbUg5kBWXBjMI0CAHX7cPZvg410Vp/VWU4KWymDKKimGtKURSM3f+EHxdbjgBoqW8ge2IWUz1TqUnfpyrFDz1lucj2oq4r4yj4/Ovxtxv1zKYO2hqw1pFjW5QBRWX+chZ5vS63MX53Oqr74eN6tdSbFF6enr1egcjcSl0THDc/7Fu2sbnNBkpSPzthUmBFgA0yVfxmHezkXHoNVo4qqhs/W9RXxAcSiTUqfTbpHqDmKVMRXCb/Wc5FH9oc6T828XU4zHN2WvDCa3NlFdZKqyuW98jP+tAVmtoYrsBLFy6zpH7O7dTM5l6Djhvt1zaLMbe+qHtg=; 5:Bah3eRsWj3mw1BxiZyuAKh/N6gNKa3YuueUL6gXPC5uLGhg6tB8iUl2LxMOow6+bQWbkWD+oSAWFIszlhGOAJErxX+nGX7fhByimecsBXfCxu/xSiIktk+eEXSst6iFePSLgbyHGTVMgEpQn4PVbYDLs768S8OPxwXTmmFP4SH4=; 24:eJ04pll10EchZU2N9QTlAOZKrYwF41LKqaAgU6/B68sL5YQDxuadDmysiKG5VTUpyIWPDrb+MNlSNZePI4w02U0ezoXkHs8Pr4Czoh6BEy4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 7:hDzeT3uxnUw/f6SMUaEyaNm2hsZEChZEyS+6h9SRyfMROgNVOQmESnE1AdF1BBvWlIofRpmp7g8ksTQp33JbNc26fE4yz4tlCF88Yhq6lET23DeKi9jtB2mZGGq8HHVp/pb2MBMy3DjMkvyYMWmzw1WQ6kFO9px1CUPYM5kUlx4coqHsLH6j5Clly6GOVzTJhe6mv9ZCr+SbjqIaOMhBWJ9yQAIxFY1QcblTkluj5yNOQF/RKKK9x4wpwCPjYSxVjKnxy++HavujxuVJbbB7ycNunLaiE4/kZIz8qSzMcTHQi4ek4yTgwNYj42ZaTI9ieVn+qb+6pfcyavakSlF4SinUxicpBEKM2em6CURP6Og= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2016 19:11:55.7819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: [dpdk-dev] [PATCH] cryptodev: fix crash on null dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" crypodev->data->name will be null when rte_cryptodev_get_dev_id() invoked without a valid crypto device instance. Signed-off-by: Jerin Jacob Acked-by: Arek Kusztal --- lib/librte_cryptodev/rte_cryptodev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 127e8d0..54e95d5 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -225,13 +225,14 @@ rte_cryptodev_create_vdev(const char *name, const char *args) } int -rte_cryptodev_get_dev_id(const char *name) { +rte_cryptodev_get_dev_id(const char *name) +{ unsigned i; if (name == NULL) return -1; - for (i = 0; i < rte_cryptodev_globals->max_devs; i++) + for (i = 0; i < rte_cryptodev_globals->nb_devs; i++) if ((strcmp(rte_cryptodev_globals->devs[i].data->name, name) == 0) && (rte_cryptodev_globals->devs[i].attached ==