diff mbox

[dpdk-dev,v2,1/2] arch/arm: fix file descriptor leakage when getting CPU features

Message ID 1478252803-14672-1-git-send-email-jianbo.liu@linaro.org (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
tmonjalo/checkpatch success coding style OK

Commit Message

Jianbo Liu Nov. 4, 2016, 9:46 a.m. UTC 
  close the file descriptor after finish using it.

Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7)
Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8)

Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 lib/librte_eal/common/arch/arm/rte_cpuflags.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Viktorin Nov. 4, 2016, 11:19 a.m. UTC | #1 
On Fri,  4 Nov 2016 15:16:42 +0530
Jianbo Liu <jianbo.liu@linaro.org> wrote:

> close the file descriptor after finish using it.

s/close/Close/

> 
> Fixes: b94e5c94 (eal/arm: add CPU flags for ARMv7)
> Fixes: 97523f82 (eal/arm: add CPU flags for ARMv8)
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>

Acked-by: Jan Viktorin <viktorin@rehivetech.com>
diff mbox

Patch

diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
index 23240ef..79160a6 100644
--- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
@@ -148,6 +148,7 @@  rte_cpu_get_features(hwcap_registers_t out)
 				out[REG_PLATFORM] = 0x0001;
 		}
 	}
+	close(auxv_fd);
 }
 
 /*